Page MenuHomePhabricator

miscco (Michael Schellenberger Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2018, 6:48 AM (109 w, 4 d)

Recent Activity

Wed, Sep 2

miscco committed rGafe8ca867337: [libcxx] Fix whitespace error (authored by miscco).
[libcxx] Fix whitespace error
Wed, Sep 2, 12:44 PM
miscco committed rG737a4501e815: Add constexpr to pair (authored by miscco).
Add constexpr to pair
Wed, Sep 2, 12:22 PM
miscco closed D80558: Add constexpr to pair.
Wed, Sep 2, 12:22 PM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.
  • Fix formatting of meow.version.pass.cpp
Wed, Sep 2, 4:11 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Once again into the breach

Wed, Sep 2, 2:42 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Please use all the changes

Wed, Sep 2, 2:41 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Remove the unused member function from CountAssign

Wed, Sep 2, 2:37 AM · Restricted Project

Tue, Sep 1

miscco added inline comments to D80558: Add constexpr to pair.
Tue, Sep 1, 12:13 PM · Restricted Project

Jul 21 2020

miscco added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

Thanks a lot for taking the time.

Jul 21 2020, 11:28 PM · Restricted Project

Jun 22 2020

miscco updated the diff for D80558: Add constexpr to pair.

Missed some changes

Jun 22 2020, 4:16 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Updated tests

Jun 22 2020, 4:16 AM · Restricted Project
miscco added a comment to D80558: Add constexpr to pair.

Could someone have a look at this?

Jun 22 2020, 1:34 AM · Restricted Project

Jun 16 2020

miscco added inline comments to D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 1:12 PM · Restricted Project
miscco added a comment to D81954: Remove the try/catch codepath if `swap` is `noexcept`..

I would second @ldionne that we should add some static_assert(noexcept(...) tests

Jun 16 2020, 11:32 AM · Restricted Project

Jun 14 2020

miscco accepted D81823: adds equality for spaceship types for themselves.

This looks obviously correct.

Jun 14 2020, 11:58 PM · Restricted Project

Jun 11 2020

miscco added a comment to D80558: Add constexpr to pair.

Took the opportunity to look through this again. Mostly nits about the tests

Jun 11 2020, 12:01 AM · Restricted Project
miscco added a comment to D80558: Add constexpr to pair.

Ping, a second *pair* of eyes wouldn't hurt.

Jun 11 2020, 12:01 AM · Restricted Project

Jun 10 2020

miscco added a comment to D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).

Thanks, that was what i expected but wanted to be safe

Jun 10 2020, 8:12 AM · Restricted Project
miscco added a comment to D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).

Do we need to reenable the test somewhere?

Jun 10 2020, 7:04 AM · Restricted Project

Jun 4 2020

miscco added a comment to D81174: [libcxx] Return "real" pointer from array<T, 0>::data..

I am still having trouble to unterstand what benefit this has.

Jun 4 2020, 10:26 AM · Restricted Project

Jun 1 2020

miscco added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
Jun 1 2020, 10:46 AM
miscco updated subscribers of D80891: [libcxx] adds operator<=> for basic_string_view.
Jun 1 2020, 10:46 AM
miscco added inline comments to D80904: [libcxx] adds spaceship for vector.
Jun 1 2020, 10:45 AM · Restricted Project

May 31 2020

miscco added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80904: [libcxx] adds spaceship for vector.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80899: [libcxx] adds std::compare_three_way.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
May 31 2020, 11:25 PM
miscco added a comment to D80891: [libcxx] adds operator<=> for basic_string_view.

Thanks for working on this. I have some small nits.

May 31 2020, 11:25 PM

May 29 2020

miscco accepted D80821: [libc++] Fix issues with the triviality of std::array.
May 29 2020, 1:06 PM · Restricted Project
miscco added a comment to D80790: [libc++] Remove redundant empty specialization in std::array.

I have to say that this is rather worse than what we had before.

May 29 2020, 12:33 PM · Restricted Project
miscco added a comment to D80821: [libc++] Fix issues with the triviality of std::array.

I think this is the "least worse" solution to the mess that is array<T, 0>.

May 29 2020, 12:33 PM · Restricted Project

May 28 2020

miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

I had two minor nits and a general OMG moment about the diverging constexpr status wrt indexing .

May 28 2020, 12:30 AM · Restricted Project

May 26 2020

miscco added a comment to D80588: Optimize vector push_back to avoid continuous load and store of end pointer..

That are great numbers!

May 26 2020, 11:57 PM · Restricted Project
miscco added a comment to D74292: [libcxx] adds [concept.derived].

One correctness comment and some minor nits

May 26 2020, 8:38 AM
miscco added a comment to D80558: Add constexpr to pair.

I somehow missed to add the description to the PR so here it is:

May 26 2020, 8:38 AM · Restricted Project
miscco created D80558: Add constexpr to pair.
May 26 2020, 8:38 AM · Restricted Project
miscco added a comment to D74351: [libcxx][type_traits] Implement C++20 common_ref.

ping

May 26 2020, 7:00 AM · Restricted Project
miscco added inline comments to D80452: [libc++] Complete overhaul of constexpr support in std::array.
May 26 2020, 12:30 AM · Restricted Project

May 23 2020

miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 23 2020, 4:12 AM · Restricted Project, Restricted Project
miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

What I completely forgot, thisimplements the array portion of the [[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1032r1.html | misc_constexpr ]]paper so you should adopt/add the feature test macro `__cpp_lib_array_constexpr = 201811L``

May 23 2020, 2:05 AM · Restricted Project

May 22 2020

miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

Thanks a lot for improving the tests. I am not yet comfortable with libc++ tests so I have some general questions inline

May 22 2020, 1:25 PM · Restricted Project

May 20 2020

miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

It seems the spacing of the binary operator is not yet stable. This test is breaking for me:

May 20 2020, 8:10 AM · Restricted Project, Restricted Project
miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Question: Should I add my wip work as a child revision or what would you suggest

May 20 2020, 6:29 AM · Restricted Project, Restricted Project

May 19 2020

miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 11:02 PM · Restricted Project, Restricted Project
miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 6:28 AM · Restricted Project, Restricted Project
miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 5:22 AM · Restricted Project, Restricted Project
miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

You are missing to check the boolean in CHECK_PARSE_BOOL in FormatTest.cpp

May 19 2020, 5:22 AM · Restricted Project, Restricted Project
miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 3:45 AM · Restricted Project, Restricted Project
miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Awesome, Thank you very much, I dragged my feet on starting to implement something for real.

May 19 2020, 2:40 AM · Restricted Project, Restricted Project

May 18 2020

miscco committed rGc579ab9962b1: [libcxx][type_traits] Add C++20 changes to common_type (authored by miscco).
[libcxx][type_traits] Add C++20 changes to common_type
May 18 2020, 5:20 AM
miscco closed D74350: [libcxx][type_traits] Add C++20 changes to common_type.
May 18 2020, 5:20 AM · Restricted Project

May 15 2020

miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

@ldionne I added additional tests and removed the spurious character

May 15 2020, 6:27 AM · Restricted Project
miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

I really "love" arcanist. Gonna check why it is adding unrelated stuff again

May 15 2020, 6:27 AM · Restricted Project
miscco updated the diff for D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Fix incorrect symbol in copied text and add some more tests

May 15 2020, 6:27 AM · Restricted Project
miscco committed rGf58e78f99205: [libcxx][span] trivial whitespace fix to test commit rights (authored by miscco).
[libcxx][span] trivial whitespace fix to test commit rights
May 15 2020, 1:36 AM
miscco closed D79986: [libcxx][span] trivial whitespace fix to test commit rights.
May 15 2020, 1:35 AM · Restricted Project
miscco created D79986: [libcxx][span] trivial whitespace fix to test commit rights.
May 15 2020, 12:52 AM · Restricted Project
miscco accepted D79986: [libcxx][span] trivial whitespace fix to test commit rights.
May 15 2020, 12:52 AM · Restricted Project

May 14 2020

miscco added inline comments to D74350: [libcxx][type_traits] Add C++20 changes to common_type.
May 14 2020, 1:03 PM · Restricted Project

May 13 2020

miscco added a comment to D75640: [libcxx][span] Remove tuple interface.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D75706: [libcxx][span] Implement solution to LWG-3255.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

Thanks for the review. I do not have commit rights though.

May 13 2020, 6:27 AM · Restricted Project

May 12 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Only update spans feature test macro

May 12 2020, 10:05 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

It seems it finally worked. No idea what went wrong as the changes were still in there

May 12 2020, 10:43 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

second try

May 12 2020, 10:43 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Add changes?!

May 12 2020, 10:43 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

That is unfortunate, i will restore them later in the evening

May 12 2020, 10:11 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Rebase on master

May 12 2020, 6:57 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

@ldionne Thanks a lot for the hint. I updated the generate_feature_test_macro_components.py script and also fixed the incorrect value provided to __cpp_lib_to_array

May 12 2020, 2:07 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.
  • [libcxx][span] Update synopsis
  • Update feature test macro
May 12 2020, 2:07 AM · Restricted Project

May 8 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.
  • [libcxx][span] Update synopsis
May 8 2020, 12:52 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

@ldionne Thanks a lot for the review. I have added the feature test macro as I did not find it anywhere else.

May 8 2020, 12:52 PM · Restricted Project

May 4 2020

miscco added a comment to D74351: [libcxx][type_traits] Implement C++20 common_ref.

ping

May 4 2020, 11:57 PM · Restricted Project
miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

ping

May 4 2020, 11:57 PM · Restricted Project

Apr 27 2020

miscco added a comment to D75706: [libcxx][span] Implement solution to LWG-3255.

ping

Apr 27 2020, 2:01 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

ping

Apr 27 2020, 2:01 PM · Restricted Project

Apr 22 2020

miscco added a comment to D75640: [libcxx][span] Remove tuple interface.

Ping

Apr 22 2020, 1:35 AM · Restricted Project

Apr 21 2020

miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

Looks like there are still white-space changes in the tests. And there are warning from the CI? Are those formatting warnings or "real" warnings?

Apr 21 2020, 2:06 PM · Restricted Project

Apr 20 2020

miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

ping, this is now without whitespace changes so I would guess it is ready to go?

Apr 20 2020, 4:16 AM · Restricted Project
miscco added inline comments to D77961: WIP: Adds `std::convertible_to` to <concepts>.
Apr 20 2020, 4:16 AM · Restricted Project

Apr 17 2020

miscco added inline comments to D67052: Add reference type transformation builtins.
Apr 17 2020, 6:59 AM · Restricted Project, Restricted Project

Apr 12 2020

miscco added a comment to D77961: WIP: Adds `std::convertible_to` to <concepts>.

I left mostly some nits with respect to readability. Great job

Apr 12 2020, 3:43 AM · Restricted Project

Apr 9 2020

miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Thanks to @CaseyCarter for the example

Apr 9 2020, 1:32 PM · Restricted Project
miscco updated the diff for D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Add test for a reference wrapper type

Apr 9 2020, 1:31 PM · Restricted Project

Apr 8 2020

miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Actually I was having trouble comming up with a test case for bullet 4.

Apr 8 2020, 11:12 PM · Restricted Project
Herald added a reviewer for D75706: [libcxx][span] Implement solution to LWG-3255: Restricted Project.

ping

Apr 8 2020, 11:57 AM · Restricted Project
Herald added a reviewer for D74351: [libcxx][type_traits] Implement C++20 common_ref: Restricted Project.

ping

Apr 8 2020, 11:57 AM · Restricted Project
Herald added a reviewer for D74350: [libcxx][type_traits] Add C++20 changes to common_type: Restricted Project.

ping

Apr 8 2020, 11:57 AM · Restricted Project

Apr 2 2020

miscco added inline comments to D77281: [libc] Add libc-tidy..
Apr 2 2020, 4:18 AM · Restricted Project

Mar 29 2020

miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

@ldionne do you require any changes here (especially regarding the feature test macro)

Mar 29 2020, 12:17 PM · Restricted Project
miscco added a comment to D75640: [libcxx][span] Remove tuple interface.

Ping, this is also all red

Mar 29 2020, 11:45 AM · Restricted Project
miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

Ping, this is all red so...

Mar 29 2020, 11:45 AM · Restricted Project
miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

Ping, I guess the clang format should not be applied?

Mar 29 2020, 11:45 AM · Restricted Project

Mar 17 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

[libcxx][span] Update synopsis

Mar 17 2020, 3:07 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

Thanks for the review, I am unsure whether one should really update the feature test macro without the other changes in place (tuple interface, relaxed array constructors etc)

Mar 17 2020, 2:36 PM · Restricted Project
Herald added a reviewer for D75642: [libcxx][span] Remove const_iterator from std::span: Restricted Project.

span-ing more pings

Mar 17 2020, 11:49 AM · Restricted Project
Herald added a reviewer for D75640: [libcxx][span] Remove tuple interface: Restricted Project.

ping

Mar 17 2020, 11:49 AM · Restricted Project
Herald added a reviewer for D74577: [libcxx][span] Implement P1976R2: Restricted Project.

gentle ping

Mar 17 2020, 11:49 AM · Restricted Project