Page MenuHomePhabricator

miscco (Michael Schellenberger Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2018, 6:48 AM (148 w, 1 d)

Recent Activity

Apr 21 2021

miscco added a comment to D101003: [libc++] <span>, like <string_view>, has no use for debug iterators..

Just to be sure, are there ABI concerns for span?

Apr 21 2021, 11:18 PM · Restricted Project

Apr 15 2021

miscco added inline comments to D100269: [libcxx][ranges] adds `ranges::range`, `ranges::common_range`, and range aliases.
Apr 15 2021, 11:53 AM · Restricted Project
miscco accepted D100271: [libcxx][iterator][ranges] adds `input_iterator` and `input_range`.
Apr 15 2021, 11:49 AM · Restricted Project
miscco accepted D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..

LGTM

Apr 15 2021, 11:48 AM · Restricted Project

Apr 12 2021

miscco accepted D100275: [libcxx][iterator][ranges] adds `forward_iterator` and `forward_range`.
Apr 12 2021, 11:00 PM · Restricted Project
miscco accepted D100271: [libcxx][iterator][ranges] adds `input_iterator` and `input_range`.
Apr 12 2021, 10:56 PM · Restricted Project
miscco added a comment to D100271: [libcxx][iterator][ranges] adds `input_iterator` and `input_range`.

I like the test coverage but I believe that we should get @CaseyCarter on board to port the ranges test machinery over. It is quite extensive and rebuilding it for the fun of it seems a waste of time

Apr 12 2021, 10:56 PM · Restricted Project
miscco added inline comments to D100160: [libcxx][iterator] adds `std::input_or_output_iterator` and `std::sentinel_for`.
Apr 12 2021, 10:52 PM · Restricted Project

Apr 7 2021

miscco added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Apr 7 2021, 11:08 PM · Restricted Project
miscco added inline comments to D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class..
Apr 7 2021, 11:49 AM · Restricted Project
miscco updated subscribers of D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.

I can only speak from experience working on the MSVC ranges machinery. The join_view tests take about 5 min to compile.

Apr 7 2021, 11:37 AM · Restricted Project
miscco added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Apr 7 2021, 5:25 AM · Restricted Project

Apr 5 2021

miscco added a comment to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.

I really like @ldionne suggestion. I am a bit unhappy about it being a macro, but meh.

Apr 5 2021, 11:45 PM · Restricted Project

Apr 4 2021

miscco added inline comments to D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`.
Apr 4 2021, 12:28 PM · Restricted Project
miscco added inline comments to D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`.
Apr 4 2021, 12:07 PM · Restricted Project

Mar 4 2021

miscco accepted D97162: [libcxx] adds std::ranges::swap, std::swappable, and std::swappable_with.

Not a maintainer, but this looks good to me

Mar 4 2021, 12:56 AM · Restricted Project

Feb 21 2021

miscco added a comment to D97162: [libcxx] adds std::ranges::swap, std::swappable, and std::swappable_with.

I find the tests really hard to read and follow. I think giving the lambdas an explicit name would be really beneficial.

Feb 21 2021, 11:59 PM · Restricted Project
miscco updated subscribers of D93593: [libc++][format] Add __format_arg_store..

Thanks for working on this. It is a considerable library

Feb 21 2021, 12:07 AM · Restricted Project

Feb 19 2021

miscco added inline comments to D96657: [libcxx] adds common_reference to <type_traits>.
Feb 19 2021, 9:56 AM · Restricted Project
miscco abandoned D74351: [libcxx][type_traits] Implement C++20 common_ref.

@cjdb I am totally fine with dropping this revision. Thanks a lot for working on this!

Feb 19 2021, 9:46 AM · Restricted Project

Feb 18 2021

miscco added inline comments to D97015: [libcxx] cleans up __cpp_concepts mess.
Feb 18 2021, 10:39 PM · Restricted Project
miscco accepted D97015: [libcxx] cleans up __cpp_concepts mess.

Looks good to me

Feb 18 2021, 10:37 PM · Restricted Project

Feb 17 2021

miscco added a comment to D96842: [dfsan] Do not specialize vector<bool> for DFSan.

re "We can't change the API". Is this because C++ standard claims that std::vector<bool> must be specialized?

Can we keep all interfaces unchanged, and add some DFSan logic inside a method when the sanitizer is used?
For example, the problem we have is operator= does not propagate DFSan's meta data correctly, and the 'reserve' method does not initialize DFSan's meta data.
When DATAFLOW_SANITIZER is on, the code may add logic to initialize or propagate DFSan's information. This does not change interfaces.
Is this a better approach?

Feb 17 2021, 11:06 AM · Restricted Project

Feb 16 2021

miscco added a comment to D96660: [libcxx] adds concept `std::common_reference_with`.

As far as I can tell the last clause from common_reference is specifically made for something like reference_wrapper types

Feb 16 2021, 12:58 AM · Restricted Project

Feb 14 2021

miscco added inline comments to D96683: [libcxx] adds concept `std::common_with`.
Feb 14 2021, 11:51 PM · Restricted Project
miscco added a comment to D96660: [libcxx] adds concept `std::common_reference_with`.

Do we need tests for indirections like std::reference_wrapper?

Feb 14 2021, 11:49 PM · Restricted Project

Feb 12 2021

miscco added inline comments to D96577: [libcxx] adds concept `std::uniform_random_bit_generator`.
Feb 12 2021, 1:31 AM · Restricted Project
miscco added a comment to D96577: [libcxx] adds concept `std::uniform_random_bit_generator`.

Thanks for working on this. It is missing uglification but besides that I only have one small nit

Feb 12 2021, 1:25 AM · Restricted Project

Feb 8 2021

miscco added a comment to D74351: [libcxx][type_traits] Implement C++20 common_ref.

@miscco What is the status of this commit? I will review it on Wednesday if it's still in good shape.

Feb 8 2021, 11:54 PM · Restricted Project

Dec 16 2020

miscco added a comment to D93383: [libc++] Use c++20 instead of c++2a consistently..

This looks great, I have some minor concerns regarding the next version and whether we should already prepare for that

Dec 16 2020, 2:07 AM · Restricted Project

Dec 11 2020

miscco added a comment to D93074: [libc++] Split allocator_traits and pointer_traits out of <memory>.

I love hat you start breaking up the headers.

Dec 11 2020, 11:37 AM · Restricted Project

Dec 4 2020

miscco accepted D79773: [clang-format] Improve clang-formats handling of concepts.
Dec 4 2020, 6:56 AM · Restricted Project, Restricted Project

Dec 3 2020

miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

As someone who has extensivly worked with conscepts I cannot stress how much this would improve my live

Dec 3 2020, 1:32 PM · Restricted Project, Restricted Project

Nov 30 2020

miscco added inline comments to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.
Nov 30 2020, 8:56 AM · Restricted Project
miscco accepted D92306: [libc++] [docs] Add C++2b (to be C++23) status page..

Awesome, thanks a lot!

Nov 30 2020, 3:04 AM · Restricted Project

Nov 27 2020

miscco added a comment to D92229: [libc++] Add format check to CI.

Has clang-format been improved enough that it will not "wreck" std::less<void>? Last time I tried it on that code, it pessimized it pretty thoroughly.
Code pasted here for reference:

#if _LIBCPP_STD_VER > 11
template <>
struct _LIBCPP_TEMPLATE_VIS less<void>
{
    template <class _T1, class _T2>
    _LIBCPP_CONSTEXPR_AFTER_CXX11 _LIBCPP_INLINE_VISIBILITY
    auto operator()(_T1&& __t, _T2&& __u) const
    _NOEXCEPT_(noexcept(_VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u)))
    -> decltype        (_VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u))
        { return        _VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u); }
    typedef void is_transparent;
};
#endif

I would like to note that with MSVC STL we simply work around those rare cases via //clang-format off. One main use case are requires clauses that are not yet supported. That said, the vast majority of the code works fine.

Nov 27 2020, 7:40 AM · Restricted Project
miscco added a comment to D92229: [libc++] Add format check to CI.

That would be interesting, but I believe that moving /splitting of lines should be common enough that it is already sorted out

Nov 27 2020, 7:27 AM · Restricted Project
miscco added a comment to D92229: [libc++] Add format check to CI.

I really like that we get clang-format to work. Live is simply to short to worry about formatting.

Nov 27 2020, 7:05 AM · Restricted Project
miscco accepted D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.

I am super in favor of using feature macros everywhere. That said I guess we need to thumbs up from the maintainers

Nov 27 2020, 1:33 AM · Restricted Project
miscco accepted D92214: [libc++] Implement format_error..
Nov 27 2020, 1:25 AM · Restricted Project

Nov 9 2020

miscco added a comment to D91004: [libc++] Implements concept destructible.

One last ask for @ldionne, currently MSVC`s internal test runner seems to require int main() even in compile only tests, as it not yet understands compileonly tests. For the sake ofcompatibility could we for now include int main() {} to enable cross vendor compatibility.

Nov 9 2020, 10:52 AM · Restricted Project

Nov 8 2020

miscco added inline comments to D91004: [libc++] Implements concept destructible.
Nov 8 2020, 11:24 AM · Restricted Project

Nov 7 2020

miscco added a comment to D90999: [libc++] Implements ranges::enable_borrowed_range.

I am wondering whether we should split the ranges header up into a smaller part that we use to include in other headers adn the rest.

Nov 7 2020, 1:16 PM · Restricted Project
miscco accepted D91004: [libc++] Implements concept destructible.

If there is another earnest push for concepts / ranges we should get together with @cjdb, @ldionne to see whether we find a way to not step on our toes and duplicate work.

Nov 7 2020, 1:08 PM · Restricted Project

Nov 3 2020

miscco added a comment to D68365: Prototype implementation of P1004R2 (making std::vector constexpr)..

Some quick review of the the acutal changes to the headers

Nov 3 2020, 11:14 AM · Restricted Project

Oct 6 2020

miscco added a reviewer for D88864: Add assert in `constexpr string_view::operator[]`: ldionne.
Oct 6 2020, 1:45 AM · Restricted Project
miscco added a comment to D88864: Add assert in `constexpr string_view::operator[]`.

Note that I am not a maintainer and you should hold on until one accepts it too

Oct 6 2020, 1:44 AM · Restricted Project
miscco accepted D88864: Add assert in `constexpr string_view::operator[]`.

I wanted to cry at the use of a comma operator, but all the other member functions do the same...

Oct 6 2020, 1:44 AM · Restricted Project

Oct 2 2020

miscco requested changes to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

So the actual problem in the bug report is that the first argument cannot be used to deduce the type.

Oct 2 2020, 5:07 AM · Restricted Project

Sep 29 2020

miscco accepted D88421: Add a regression test for erasing from a vector.

Thanks a lot for improving the test coverage!

Sep 29 2020, 7:33 AM · Restricted Project

Sep 28 2020

miscco added a comment to D88421: Add a regression test for erasing from a vector.

@Quuxplusone I am totally fine with you adding the basic test.

Sep 28 2020, 12:43 PM · Restricted Project
miscco added a comment to D88421: Add a regression test for erasing from a vector.

I mean I do not really want to bother you, but the "correct" thing to do would be to actually not use int but one of the defined arche types (in this case one of those that count how many times they have been moved from.)

Sep 28 2020, 11:00 AM · Restricted Project
miscco added a comment to D88421: Add a regression test for erasing from a vector.

Could we remove from the middle to ensure that we do not tamper with the initial elements

Sep 28 2020, 9:04 AM · Restricted Project

Sep 23 2020

miscco added a comment to D77961: [libcxx] adds concept `std::convertible_to`.

@cjdb This was just a ping to see whether you are still interested.

Sep 23 2020, 12:50 AM · Restricted Project
miscco added a comment to D88131: adds [concepts.arithmetic].

Some small nits

Sep 23 2020, 12:48 AM · Restricted Project

Sep 21 2020

miscco added a comment to D77961: [libcxx] adds concept `std::convertible_to`.

Ping @cjdb I knowit has been a while but are you still planning on working on this?

Sep 21 2020, 1:39 PM · Restricted Project

Sep 2 2020

miscco committed rGafe8ca867337: [libcxx] Fix whitespace error (authored by miscco).
[libcxx] Fix whitespace error
Sep 2 2020, 12:44 PM
miscco committed rG737a4501e815: Add constexpr to pair (authored by miscco).
Add constexpr to pair
Sep 2 2020, 12:22 PM
miscco closed D80558: Add constexpr to pair.
Sep 2 2020, 12:22 PM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.
  • Fix formatting of meow.version.pass.cpp
Sep 2 2020, 4:11 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Once again into the breach

Sep 2 2020, 2:42 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Please use all the changes

Sep 2 2020, 2:41 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Remove the unused member function from CountAssign

Sep 2 2020, 2:37 AM · Restricted Project

Sep 1 2020

miscco added inline comments to D80558: Add constexpr to pair.
Sep 1 2020, 12:13 PM · Restricted Project

Jul 21 2020

miscco added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

Thanks a lot for taking the time.

Jul 21 2020, 11:28 PM · Restricted Project

Jun 22 2020

miscco updated the diff for D80558: Add constexpr to pair.

Missed some changes

Jun 22 2020, 4:16 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Updated tests

Jun 22 2020, 4:16 AM · Restricted Project
miscco added a comment to D80558: Add constexpr to pair.

Could someone have a look at this?

Jun 22 2020, 1:34 AM · Restricted Project

Jun 16 2020

miscco added inline comments to D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 1:12 PM · Restricted Project
miscco added a comment to D81954: Remove the try/catch codepath if `swap` is `noexcept`..

I would second @ldionne that we should add some static_assert(noexcept(...) tests

Jun 16 2020, 11:32 AM · Restricted Project

Jun 14 2020

miscco accepted D81823: adds equality for spaceship types for themselves.

This looks obviously correct.

Jun 14 2020, 11:58 PM · Restricted Project

Jun 11 2020

miscco added a comment to D80558: Add constexpr to pair.

Took the opportunity to look through this again. Mostly nits about the tests

Jun 11 2020, 12:01 AM · Restricted Project
miscco added a comment to D80558: Add constexpr to pair.

Ping, a second *pair* of eyes wouldn't hurt.

Jun 11 2020, 12:01 AM · Restricted Project

Jun 10 2020

miscco added a comment to D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).

Thanks, that was what i expected but wanted to be safe

Jun 10 2020, 8:12 AM · Restricted Project
miscco added a comment to D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).

Do we need to reenable the test somewhere?

Jun 10 2020, 7:04 AM · Restricted Project

Jun 4 2020

miscco added a comment to D81174: [libcxx] Return "real" pointer from array<T, 0>::data..

I am still having trouble to unterstand what benefit this has.

Jun 4 2020, 10:26 AM · Restricted Project

Jun 1 2020

miscco added inline comments to D80895: [libcxx] adds consistent comparison for `basic_string`.
Jun 1 2020, 10:46 AM · Restricted Project
miscco updated subscribers of D80891: [libcxx] adds consistent comparison for `basic_string_view`.
Jun 1 2020, 10:46 AM · Restricted Project
miscco added inline comments to D80904: [libcxx] adds spaceship for vector.
Jun 1 2020, 10:45 AM · Restricted Project

May 31 2020

miscco added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80904: [libcxx] adds spaceship for vector.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80899: [libcxx] adds std::compare_three_way.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80895: [libcxx] adds consistent comparison for `basic_string`.
May 31 2020, 11:25 PM · Restricted Project
miscco added a comment to D80891: [libcxx] adds consistent comparison for `basic_string_view`.

Thanks for working on this. I have some small nits.

May 31 2020, 11:25 PM · Restricted Project

May 29 2020

miscco accepted D80821: [libc++] Fix issues with the triviality of std::array.
May 29 2020, 1:06 PM · Restricted Project
miscco added a comment to D80790: [libc++] Remove redundant empty specialization in std::array.

I have to say that this is rather worse than what we had before.

May 29 2020, 12:33 PM · Restricted Project
miscco added a comment to D80821: [libc++] Fix issues with the triviality of std::array.

I think this is the "least worse" solution to the mess that is array<T, 0>.

May 29 2020, 12:33 PM · Restricted Project

May 28 2020

miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

I had two minor nits and a general OMG moment about the diverging constexpr status wrt indexing .

May 28 2020, 12:30 AM · Restricted Project

May 26 2020

miscco added a comment to D80588: Optimize vector push_back to avoid continuous load and store of end pointer..

That are great numbers!

May 26 2020, 11:57 PM · Restricted Project
miscco added a comment to D74292: [libcxx] adds concept std::derived_from.

One correctness comment and some minor nits

May 26 2020, 8:38 AM · Restricted Project
miscco added a comment to D80558: Add constexpr to pair.

I somehow missed to add the description to the PR so here it is:

May 26 2020, 8:38 AM · Restricted Project
miscco created D80558: Add constexpr to pair.
May 26 2020, 8:38 AM · Restricted Project
miscco added a comment to D74351: [libcxx][type_traits] Implement C++20 common_ref.

ping

May 26 2020, 7:00 AM · Restricted Project
miscco added inline comments to D80452: [libc++] Complete overhaul of constexpr support in std::array.
May 26 2020, 12:30 AM · Restricted Project

May 23 2020

miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 23 2020, 4:12 AM · Restricted Project, Restricted Project
miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

What I completely forgot, thisimplements the array portion of the [[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1032r1.html | misc_constexpr ]]paper so you should adopt/add the feature test macro `__cpp_lib_array_constexpr = 201811L``

May 23 2020, 2:05 AM · Restricted Project

May 22 2020

miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

Thanks a lot for improving the tests. I am not yet comfortable with libc++ tests so I have some general questions inline

May 22 2020, 1:25 PM · Restricted Project

May 20 2020

miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

It seems the spacing of the binary operator is not yet stable. This test is breaking for me:

May 20 2020, 8:10 AM · Restricted Project, Restricted Project
miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Question: Should I add my wip work as a child revision or what would you suggest

May 20 2020, 6:29 AM · Restricted Project, Restricted Project

May 19 2020

miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 11:02 PM · Restricted Project, Restricted Project