Page MenuHomePhabricator

miscco (Michael Schellenberger Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2018, 6:48 AM (127 w, 1 d)

Recent Activity

Dec 16 2020

miscco added a comment to D93383: [libc++] Use c++20 instead of c++2a consistently..

This looks great, I have some minor concerns regarding the next version and whether we should already prepare for that

Dec 16 2020, 2:07 AM · Restricted Project

Dec 11 2020

miscco added a comment to D93074: [libc++] Split allocator_traits and pointer_traits out of <memory>.

I love hat you start breaking up the headers.

Dec 11 2020, 11:37 AM · Restricted Project

Dec 4 2020

miscco accepted D79773: [clang-format] Improve clang-formats handling of concepts.
Dec 4 2020, 6:56 AM · Restricted Project, Restricted Project

Dec 3 2020

miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

As someone who has extensivly worked with conscepts I cannot stress how much this would improve my live

Dec 3 2020, 1:32 PM · Restricted Project, Restricted Project

Nov 30 2020

miscco added inline comments to D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.
Nov 30 2020, 8:56 AM · Restricted Project
miscco accepted D92306: [libc++] [docs] Add C++2b (to be C++23) status page..

Awesome, thanks a lot!

Nov 30 2020, 3:04 AM · Restricted Project

Nov 27 2020

miscco added a comment to D92229: [libc++] Update clang-format configuration.

Has clang-format been improved enough that it will not "wreck" std::less<void>? Last time I tried it on that code, it pessimized it pretty thoroughly.
Code pasted here for reference:

#if _LIBCPP_STD_VER > 11
template <>
struct _LIBCPP_TEMPLATE_VIS less<void>
{
    template <class _T1, class _T2>
    _LIBCPP_CONSTEXPR_AFTER_CXX11 _LIBCPP_INLINE_VISIBILITY
    auto operator()(_T1&& __t, _T2&& __u) const
    _NOEXCEPT_(noexcept(_VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u)))
    -> decltype        (_VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u))
        { return        _VSTD::forward<_T1>(__t) < _VSTD::forward<_T2>(__u); }
    typedef void is_transparent;
};
#endif

I would like to note that with MSVC STL we simply work around those rare cases via //clang-format off. One main use case are requires clauses that are not yet supported. That said, the vast majority of the code works fine.

Nov 27 2020, 7:40 AM · Restricted Project
miscco added a comment to D92229: [libc++] Update clang-format configuration.

That would be interesting, but I believe that moving /splitting of lines should be common enough that it is already sorted out

Nov 27 2020, 7:27 AM · Restricted Project
miscco added a comment to D92229: [libc++] Update clang-format configuration.

I really like that we get clang-format to work. Live is simply to short to worry about formatting.

Nov 27 2020, 7:05 AM · Restricted Project
miscco accepted D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed.

I am super in favor of using feature macros everywhere. That said I guess we need to thumbs up from the maintainers

Nov 27 2020, 1:33 AM · Restricted Project
miscco accepted D92214: [libc++] Implement format_error..
Nov 27 2020, 1:25 AM · Restricted Project

Nov 9 2020

miscco added a comment to D91004: [libc++] Implements concept destructible.

One last ask for @ldionne, currently MSVC`s internal test runner seems to require int main() even in compile only tests, as it not yet understands compileonly tests. For the sake ofcompatibility could we for now include int main() {} to enable cross vendor compatibility.

Nov 9 2020, 10:52 AM · Restricted Project

Nov 8 2020

miscco added inline comments to D91004: [libc++] Implements concept destructible.
Nov 8 2020, 11:24 AM · Restricted Project

Nov 7 2020

miscco added a comment to D90999: [libc++] Implements ranges::enable_borrowed_range.

I am wondering whether we should split the ranges header up into a smaller part that we use to include in other headers adn the rest.

Nov 7 2020, 1:16 PM · Restricted Project
miscco accepted D91004: [libc++] Implements concept destructible.

If there is another earnest push for concepts / ranges we should get together with @cjdb, @ldionne to see whether we find a way to not step on our toes and duplicate work.

Nov 7 2020, 1:08 PM · Restricted Project

Nov 3 2020

miscco added a comment to D68365: Prototype implementation of P1004R2 (making std::vector constexpr)..

Some quick review of the the acutal changes to the headers

Nov 3 2020, 11:14 AM · Restricted Project

Oct 6 2020

miscco added a reviewer for D88864: Add assert in `constexpr string_view::operator[]`: ldionne.
Oct 6 2020, 1:45 AM · Restricted Project
miscco added a comment to D88864: Add assert in `constexpr string_view::operator[]`.

Note that I am not a maintainer and you should hold on until one accepts it too

Oct 6 2020, 1:44 AM · Restricted Project
miscco accepted D88864: Add assert in `constexpr string_view::operator[]`.

I wanted to cry at the use of a comma operator, but all the other member functions do the same...

Oct 6 2020, 1:44 AM · Restricted Project

Oct 2 2020

miscco requested changes to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

So the actual problem in the bug report is that the first argument cannot be used to deduce the type.

Oct 2 2020, 5:07 AM · Restricted Project

Sep 29 2020

miscco accepted D88421: Add a regression test for erasing from a vector.

Thanks a lot for improving the test coverage!

Sep 29 2020, 7:33 AM · Restricted Project

Sep 28 2020

miscco added a comment to D88421: Add a regression test for erasing from a vector.

@Quuxplusone I am totally fine with you adding the basic test.

Sep 28 2020, 12:43 PM · Restricted Project
miscco added a comment to D88421: Add a regression test for erasing from a vector.

I mean I do not really want to bother you, but the "correct" thing to do would be to actually not use int but one of the defined arche types (in this case one of those that count how many times they have been moved from.)

Sep 28 2020, 11:00 AM · Restricted Project
miscco added a comment to D88421: Add a regression test for erasing from a vector.

Could we remove from the middle to ensure that we do not tamper with the initial elements

Sep 28 2020, 9:04 AM · Restricted Project

Sep 23 2020

miscco added a comment to D77961: WIP: Adds `std::convertible_to` to <concepts>.

@cjdb This was just a ping to see whether you are still interested.

Sep 23 2020, 12:50 AM · Restricted Project
miscco added a comment to D88131: adds [concepts.arithmetic].

Some small nits

Sep 23 2020, 12:48 AM · Restricted Project

Sep 21 2020

miscco added a comment to D77961: WIP: Adds `std::convertible_to` to <concepts>.

Ping @cjdb I knowit has been a while but are you still planning on working on this?

Sep 21 2020, 1:39 PM · Restricted Project

Sep 2 2020

miscco committed rGafe8ca867337: [libcxx] Fix whitespace error (authored by miscco).
[libcxx] Fix whitespace error
Sep 2 2020, 12:44 PM
miscco committed rG737a4501e815: Add constexpr to pair (authored by miscco).
Add constexpr to pair
Sep 2 2020, 12:22 PM
miscco closed D80558: Add constexpr to pair.
Sep 2 2020, 12:22 PM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.
  • Fix formatting of meow.version.pass.cpp
Sep 2 2020, 4:11 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Once again into the breach

Sep 2 2020, 2:42 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Please use all the changes

Sep 2 2020, 2:41 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Remove the unused member function from CountAssign

Sep 2 2020, 2:37 AM · Restricted Project

Sep 1 2020

miscco added inline comments to D80558: Add constexpr to pair.
Sep 1 2020, 12:13 PM · Restricted Project

Jul 21 2020

miscco added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

Thanks a lot for taking the time.

Jul 21 2020, 11:28 PM · Restricted Project

Jun 22 2020

miscco updated the diff for D80558: Add constexpr to pair.

Missed some changes

Jun 22 2020, 4:16 AM · Restricted Project
miscco updated the diff for D80558: Add constexpr to pair.

Updated tests

Jun 22 2020, 4:16 AM · Restricted Project
miscco added a comment to D80558: Add constexpr to pair.

Could someone have a look at this?

Jun 22 2020, 1:34 AM · Restricted Project

Jun 16 2020

miscco added inline comments to D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 1:12 PM · Restricted Project
miscco added a comment to D81954: Remove the try/catch codepath if `swap` is `noexcept`..

I would second @ldionne that we should add some static_assert(noexcept(...) tests

Jun 16 2020, 11:32 AM · Restricted Project

Jun 14 2020

miscco accepted D81823: adds equality for spaceship types for themselves.

This looks obviously correct.

Jun 14 2020, 11:58 PM · Restricted Project

Jun 11 2020

miscco added a comment to D80558: Add constexpr to pair.

Took the opportunity to look through this again. Mostly nits about the tests

Jun 11 2020, 12:01 AM · Restricted Project
miscco added a comment to D80558: Add constexpr to pair.

Ping, a second *pair* of eyes wouldn't hurt.

Jun 11 2020, 12:01 AM · Restricted Project

Jun 10 2020

miscco added a comment to D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).

Thanks, that was what i expected but wanted to be safe

Jun 10 2020, 8:12 AM · Restricted Project
miscco added a comment to D81559: [libcxx] Fix std::vector construct_iter_iter.pass.cpp test (C++98/03).

Do we need to reenable the test somewhere?

Jun 10 2020, 7:04 AM · Restricted Project

Jun 4 2020

miscco added a comment to D81174: [libcxx] Return "real" pointer from array<T, 0>::data..

I am still having trouble to unterstand what benefit this has.

Jun 4 2020, 10:26 AM · Restricted Project

Jun 1 2020

miscco added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
Jun 1 2020, 10:46 AM
miscco updated subscribers of D80891: [libcxx] adds operator<=> for basic_string_view.
Jun 1 2020, 10:46 AM
miscco added inline comments to D80904: [libcxx] adds spaceship for vector.
Jun 1 2020, 10:45 AM · Restricted Project

May 31 2020

miscco added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80904: [libcxx] adds spaceship for vector.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80899: [libcxx] adds std::compare_three_way.
May 31 2020, 11:57 PM · Restricted Project
miscco added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
May 31 2020, 11:25 PM
miscco added a comment to D80891: [libcxx] adds operator<=> for basic_string_view.

Thanks for working on this. I have some small nits.

May 31 2020, 11:25 PM

May 29 2020

miscco accepted D80821: [libc++] Fix issues with the triviality of std::array.
May 29 2020, 1:06 PM · Restricted Project
miscco added a comment to D80790: [libc++] Remove redundant empty specialization in std::array.

I have to say that this is rather worse than what we had before.

May 29 2020, 12:33 PM · Restricted Project
miscco added a comment to D80821: [libc++] Fix issues with the triviality of std::array.

I think this is the "least worse" solution to the mess that is array<T, 0>.

May 29 2020, 12:33 PM · Restricted Project

May 28 2020

miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

I had two minor nits and a general OMG moment about the diverging constexpr status wrt indexing .

May 28 2020, 12:30 AM · Restricted Project

May 26 2020

miscco added a comment to D80588: Optimize vector push_back to avoid continuous load and store of end pointer..

That are great numbers!

May 26 2020, 11:57 PM · Restricted Project
miscco added a comment to D74292: [libcxx] adds [concept.derived].

One correctness comment and some minor nits

May 26 2020, 8:38 AM
miscco added a comment to D80558: Add constexpr to pair.

I somehow missed to add the description to the PR so here it is:

May 26 2020, 8:38 AM · Restricted Project
miscco created D80558: Add constexpr to pair.
May 26 2020, 8:38 AM · Restricted Project
miscco added a comment to D74351: [libcxx][type_traits] Implement C++20 common_ref.

ping

May 26 2020, 7:00 AM · Restricted Project
miscco added inline comments to D80452: [libc++] Complete overhaul of constexpr support in std::array.
May 26 2020, 12:30 AM · Restricted Project

May 23 2020

miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 23 2020, 4:12 AM · Restricted Project, Restricted Project
miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

What I completely forgot, thisimplements the array portion of the [[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1032r1.html | misc_constexpr ]]paper so you should adopt/add the feature test macro `__cpp_lib_array_constexpr = 201811L``

May 23 2020, 2:05 AM · Restricted Project

May 22 2020

miscco added a comment to D80452: [libc++] Complete overhaul of constexpr support in std::array.

Thanks a lot for improving the tests. I am not yet comfortable with libc++ tests so I have some general questions inline

May 22 2020, 1:25 PM · Restricted Project

May 20 2020

miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

It seems the spacing of the binary operator is not yet stable. This test is breaking for me:

May 20 2020, 8:10 AM · Restricted Project, Restricted Project
miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Question: Should I add my wip work as a child revision or what would you suggest

May 20 2020, 6:29 AM · Restricted Project, Restricted Project

May 19 2020

miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 11:02 PM · Restricted Project, Restricted Project
miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 6:28 AM · Restricted Project, Restricted Project
miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 5:22 AM · Restricted Project, Restricted Project
miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

You are missing to check the boolean in CHECK_PARSE_BOOL in FormatTest.cpp

May 19 2020, 5:22 AM · Restricted Project, Restricted Project
miscco added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
May 19 2020, 3:45 AM · Restricted Project, Restricted Project
miscco added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Awesome, Thank you very much, I dragged my feet on starting to implement something for real.

May 19 2020, 2:40 AM · Restricted Project, Restricted Project

May 18 2020

miscco committed rGc579ab9962b1: [libcxx][type_traits] Add C++20 changes to common_type (authored by miscco).
[libcxx][type_traits] Add C++20 changes to common_type
May 18 2020, 5:20 AM
miscco closed D74350: [libcxx][type_traits] Add C++20 changes to common_type.
May 18 2020, 5:20 AM · Restricted Project

May 15 2020

miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

@ldionne I added additional tests and removed the spurious character

May 15 2020, 6:27 AM · Restricted Project
miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

I really "love" arcanist. Gonna check why it is adding unrelated stuff again

May 15 2020, 6:27 AM · Restricted Project
miscco updated the diff for D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Fix incorrect symbol in copied text and add some more tests

May 15 2020, 6:27 AM · Restricted Project
miscco committed rGf58e78f99205: [libcxx][span] trivial whitespace fix to test commit rights (authored by miscco).
[libcxx][span] trivial whitespace fix to test commit rights
May 15 2020, 1:36 AM
miscco closed D79986: [libcxx][span] trivial whitespace fix to test commit rights.
May 15 2020, 1:35 AM · Restricted Project
miscco created D79986: [libcxx][span] trivial whitespace fix to test commit rights.
May 15 2020, 12:52 AM · Restricted Project
miscco accepted D79986: [libcxx][span] trivial whitespace fix to test commit rights.
May 15 2020, 12:52 AM · Restricted Project

May 14 2020

miscco added inline comments to D74350: [libcxx][type_traits] Add C++20 changes to common_type.
May 14 2020, 1:03 PM · Restricted Project

May 13 2020

miscco added a comment to D75640: [libcxx][span] Remove tuple interface.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D75706: [libcxx][span] Implement solution to LWG-3255.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

Thanks for the review. I do not have commit rights though.

May 13 2020, 6:27 AM · Restricted Project

May 12 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Only update spans feature test macro

May 12 2020, 10:05 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

It seems it finally worked. No idea what went wrong as the changes were still in there

May 12 2020, 10:43 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

second try

May 12 2020, 10:43 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Add changes?!

May 12 2020, 10:43 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

That is unfortunate, i will restore them later in the evening

May 12 2020, 10:11 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Rebase on master

May 12 2020, 6:57 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

@ldionne Thanks a lot for the hint. I updated the generate_feature_test_macro_components.py script and also fixed the incorrect value provided to __cpp_lib_to_array

May 12 2020, 2:07 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.
  • [libcxx][span] Update synopsis
  • Update feature test macro
May 12 2020, 2:07 AM · Restricted Project

May 8 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.
  • [libcxx][span] Update synopsis
May 8 2020, 12:52 PM · Restricted Project