For release/12.x
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
There are a number of common grammar tweaks, I think would make sense. Based on a brief look at other release notes, I think I would phrase things as "XXX is/are now supported/retrained/..." rather than simply "is supported", as it emphasises what has changed. Similarly "XXX now has support for ..." and "XXX can now have/use/...". For "is fixed/added/improved" I'd say "has been fixed/...".
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 48 | Links to one or more reviews? What has been improved about the support? | |
| 62 | Links to one or more reviews? As it is, this release note is rather useless, I think. | |
| 65 | This suggests this item could be a breaking change? Should it be in that section instead? | |
| 70 | ||
comments.
add more items
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 48 | The commits collectively improved the support. I made a bunch of commits, sometimes with one commit regressed some untested cases. | |
Thanks for the update. A few more grammar suggestions for you inline.
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 27 | Same for --lto-pseudo-probe-for-profiling and --no-lto-whole-program-visibility. | |
| 27–29 | Not specific to this change, but you might as well fix it whilst here. | |
| 31 | ||
| 36 | ||
| 38 | ||
| 41 | ||
| 47 | ||
| 52 | ||
| 54 | ||
| 57 | ||
| 58 | ||
| 62 | ||
| 64 | ||
| 67 | ||
| 72 | ||
| 74 | ||
| 76 | Is there a review for this one? | |
| 77 | ||
| 80 | Should this be "many more"? Presumably there were some that were already supported? | |
| 81 | ||
| 84 | ||
| 86 | ||
| 88 | Is there an option (other than the CMake variable) to turn this off at runtime? If not "defaults" should probably be "uses". | |
Same for --lto-pseudo-probe-for-profiling and --no-lto-whole-program-visibility.