Page MenuHomePhabricator

[MLIR][TOSA] Add lowering from TOSA to Linalg for math-based and elementwise ops
ClosedPublic

Authored by NatashaKnk on Feb 17 2021, 5:55 PM.

Details

Summary

This patch adds lowering to Linalg for the following TOSA ops: negate, rsqrt, mul, select, clamp and reluN and includes support for signless integer and floating point types

Diff Detail

Event Timeline

NatashaKnk created this revision.Feb 17 2021, 5:55 PM
NatashaKnk requested review of this revision.Feb 17 2021, 5:55 PM
rsuderman accepted this revision.Feb 17 2021, 5:58 PM
This revision is now accepted and ready to land.Feb 17 2021, 5:58 PM

Your commit description still has typos (duplicated words) FYI.

In general try to start the title with a verb and make it descriptive: "Add lowering from TOSA to Linalg for math-based and elementwise ops".
And descriptive sentence in the description: "This patch adds lowering to Linalg for the following TOSA ops: negate, rsqrt, mul, select, clamp and reluN and includes support for signless integer and floating point types".

(here is a blog post on the topic: https://chris.beams.io/posts/git-commit/ )

rsuderman retitled this revision from [MLIR][TOSA] Math-based and activation elementwise ops for tosa-to-linalg to [MLIR][TOSA] Added Math-based and activation elementwise ops for tosa-to-linalg.Feb 18 2021, 11:54 AM
rsuderman edited the summary of this revision. (Show Details)

I will update the commit messages on push.

rsuderman retitled this revision from [MLIR][TOSA] Added Math-based and activation elementwise ops for tosa-to-linalg to [MLIR][TOSA] Add lowering from TOSA to Linalg for math-based and elementwise ops.Feb 18 2021, 11:57 AM
rsuderman edited the summary of this revision. (Show Details)