This is an archive of the discontinued LLVM Phabricator instance.

Differential D96912

[flang][fir][NFC] clang-tidy change. Add include.
ClosedPublic

Authored by schweitz on Feb 17 2021, 3:38 PM.

Details

Reviewers
jeanPerier
svedanayagam
clementval
sscalpone
kiranchandramohan
Commits
rGfd3297dc32fa: [flang][fir][NFC] clang-tidy change. Add include.

Diff Detail

Event Timeline

schweitz created this revision.Feb 17 2021, 3:38 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptFeb 17 2021, 3:38 PM
schweitz requested review of this revision.Feb 17 2021, 3:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 3:38 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kiranchandramohan accepted this revision.Feb 17 2021, 3:47 PM
kiranchandramohan added a subscriber: kiranchandramohan.

I guess for small format/clang-tidy changes reviews are not required.

You may have a typo in this patch. You can submit with changes (if any needed).

LGTM.

flang/include/flang/Optimizer/Dialect/FIROps.h
16

Is there a typo here or in line 12? Both refer to the same include file.

This revision is now accepted and ready to land.Feb 17 2021, 3:47 PM
Harbormaster completed remote builds in B89623: Diff 324448.Feb 17 2021, 4:55 PM
This revision was landed with ongoing or failed builds.Feb 17 2021, 5:52 PM
Closed by commit rGfd3297dc32fa: [flang][fir][NFC] clang-tidy change. Add include. (authored by schweitz). · Explain Why
This revision was automatically updated to reflect the committed changes.
schweitz added a commit: rGfd3297dc32fa: [flang][fir][NFC] clang-tidy change. Add include..

Revision Contents

PathSize
flang/
include/
flang/
Optimizer/
Dialect/
8 lines

Diff 324448

flang/include/flang/Optimizer/Dialect/FIROps.h

//===-- Optimizer/Dialect/FIROps.h - FIR operations -------------*- C++ -*-===// //===-- Optimizer/Dialect/FIROps.h - FIR operations -------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef OPTIMIZER_DIALECT_FIROPS_H #ifndef FORTRAN_OPTIMIZER_DIALECT_FIROPS_H
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: header guard does not follow preferred style [llvm-header-guard]
not useful

Lint: Pre-merge checks: clang-tidy: warning: header guard does not follow preferred style [llvm-header-guard] [[https…
#define OPTIMIZER_DIALECT_FIROPS_H #define FORTRAN_OPTIMIZER_DIALECT_FIROPS_H
#include "flang/Optimizer/Dialect/FIRType.h" #include "flang/Optimizer/Dialect/FIRType.h"
#include "mlir/Dialect/StandardOps/IR/Ops.h" #include "mlir/Dialect/StandardOps/IR/Ops.h"
#include "mlir/Interfaces/LoopLikeInterface.h" #include "mlir/Interfaces/LoopLikeInterface.h"
#include "mlir/Interfaces/SideEffectInterfaces.h" #include "mlir/Interfaces/SideEffectInterfaces.h"
#include "flang/Optimizer/Dialect/FIRType.h"
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-#include "flang/Optimizer/Dialect/FIRType.h"
-
Lint: Pre-merge checks: clang-format: please reformat the code ``` -#include "flang/Optimizer/Dialect/FIRType.h" - ```
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Is there a typo here or in line 12? Both refer to the same include file.

kiranchandramohan: Is there a typo here or in line 12? Both refer to the same include file.
using namespace mlir; using namespace mlir;
namespace fir { namespace fir {
class FirEndOp; class FirEndOp;
class DoLoopOp; class DoLoopOp;
class RealAttr; class RealAttr;
Show All 18 Linesmlir::ParseResult parseSelector(mlir::OpAsmParser &parser,
mlir::OpAsmParser::OperandType &selector, mlir::OpAsmParser::OperandType &selector,
mlir::Type &type); mlir::Type &type);
} // namespace fir } // namespace fir
#define GET_OP_CLASSES #define GET_OP_CLASSES
#include "flang/Optimizer/Dialect/FIROps.h.inc" #include "flang/Optimizer/Dialect/FIROps.h.inc"
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-
Lint: Pre-merge checks: clang-format: please reformat the code ``` - ```
#endif // OPTIMIZER_DIALECT_FIROPS_H #endif // FORTRAN_OPTIMIZER_DIALECT_FIROPS_H