[flang][f18] Make -fdebug-dump-{} imply -fsyntax-only - revert

[awarzynski]

Summary

This patch reverts the changes in f18 introduced in
https://reviews.llvm.org/D96528.

The new driver will run only the action corresponding to the final
action option. For this reason, we need to make sure that
-fsyntax-only _is not_ the final option on the command line and all
tests are updated to use:

-fsyntax-only -fdebug-dump-symbols

rather than

-fdebug-dump-symbols -fsyntax-only

This way we can guarantee that tests using -fdebug-dump-symbols and
-fdebug-dump-parse-tree will continue working for both drivers,
despite the underlying implementation being a bit different.

The affected dump options:

• -fdebug-dump-symbols
• -fdebug-dump-parse-tree

are introduced in flang-new in https://reviews.llvm.org/D96716.

[awarzynski]

Abandoning, f18 is no longer present in the monorepo.

flang/test/Evaluate/test_folding.sh

 src=$1
 [[ ! -f $src ]] && echo "File not found: $src" && exit 1
 shift
 
 temp=$1
 mkdir -p $temp
 shift
 
-CMD="$* -fdebug-dump-symbols"
+CMD="$* -fsyntax-only -fdebug-dump-symbols"
 
 # Check if tests should assume folding is using libpgmath
 if [[ $LIBPGMATH ]]; then
   CMD="$CMD -DTEST_LIBPGMATH"
   echo "Assuming libpgmath support"
 else
   echo "Not assuming libpgmath support"
 fi

flang/test/Semantics/data05.f90

-!RUN: %f18 -fdebug-dump-symbols %s | FileCheck %s
+!RUN: %f18 -fsyntax-only -fdebug-dump-symbols %s | FileCheck %s
 module m
   interface
     integer function ifunc(n)
       integer, intent(in) :: n
     end function
     real function rfunc(x)
       real, intent(in) :: x
     end function

flang/test/Semantics/data08.f90

-! RUN: %f18 -fdebug-dump-symbols %s 2>&1 | FileCheck %s
+! RUN: %f18 -fsyntax-only -fdebug-dump-symbols %s 2>&1 | FileCheck %s
 ! CHECK: DATA statement value initializes 'jx' of type 'INTEGER(4)' with CHARACTER
 ! CHECK: DATA statement value initializes 'jy' of type 'INTEGER(4)' with CHARACTER
 ! CHECK: DATA statement value initializes 'jz' of type 'INTEGER(4)' with CHARACTER
 ! CHECK: DATA statement value initializes 'kx' of type 'INTEGER(8)' with CHARACTER
 ! CHECK: jx (InDataStmt) size=4 offset=0: ObjectEntity type: INTEGER(4) init:1684234849_4
 ! CHECK: jy (InDataStmt) size=4 offset=4: ObjectEntity type: INTEGER(4) init:543384161_4
 ! CHECK: jz (InDataStmt) size=4 offset=8: ObjectEntity type: INTEGER(4) init:1684234849_4
 ! CHECK: kx (InDataStmt) size=8 offset=16: ObjectEntity type: INTEGER(8) init:7523094288207667809_8
 
 integer :: jx, jy, jz
 integer(8) :: kx
 data jx/4habcd/
 data jy/3habc/
 data jz/5habcde/
 data kx/'abcdefgh'/
 end

flang/test/Semantics/offsets01.f90

-!RUN: %f18 -fdebug-dump-symbols %s | FileCheck %s
+!RUN: %f18 -fsyntax-only -fdebug-dump-symbols %s | FileCheck %s
 
 ! Size and alignment of intrinsic types
 subroutine s1
   integer(1) :: a_i1  !CHECK: a_i1 size=1 offset=0:
   integer(8) :: b_i8  !CHECK: b_i8 size=8 offset=8:
   real(2)    :: c_r2  !CHECK: c_r2 size=2 offset=16:
   real(2)    :: d_r2  !CHECK: d_r2 size=2 offset=18:
   real(8)    :: e_r8  !CHECK: e_r8 size=8 offset=24:

flang/test/Semantics/offsets02.f90

-!RUN: %f18 -fdebug-dump-symbols %s | FileCheck %s
+!RUN: %f18 -fsyntax-only -fdebug-dump-symbols %s | FileCheck %s
 
 ! Size and alignment of derived types
 
 ! Array of derived type with 64-bit alignment
 subroutine s1
   type t1
     real(8) :: a
     real(4) :: b

flang/test/Semantics/offsets03.f90

-!RUN: %f18 -fdebug-dump-symbols %s | FileCheck %s
+!RUN: %f18 -fsyntax-only -fdebug-dump-symbols %s | FileCheck %s
 
 ! Size and alignment with EQUIVALENCE and COMMON
 
 ! a1 depends on a2 depends on a3
 module ma
   real :: a1(10), a2(10), a3(10)
   equivalence(a1, a2(3)) !CHECK: a1, PUBLIC size=40 offset=20:
   equivalence(a2, a3(4)) !CHECK: a2, PUBLIC size=40 offset=12:

flang/test/Semantics/oldparam01.f90

-! RUN: %f18 -falternative-parameter-statement -fdebug-dump-symbols %s 2>&1 | FileCheck %s
+! RUN: %f18 -falternative-parameter-statement -fsyntax-only -fdebug-dump-symbols %s 2>&1 | FileCheck %s
 
 ! Non-error tests for "old style" PARAMETER statements
 
 type :: t
   integer(kind=4) :: n
 end type
 !CHECK: x1, PARAMETER size=4 offset=0: ObjectEntity type: INTEGER(4) init:1_4
 parameter x1 = 1_4 ! integer scalar

flang/test/Semantics/resolve100.f90

-!RUN: %f18 -fdebug-dump-symbols %s | FileCheck %s
+!RUN: %f18 -fsyntax-only -fdebug-dump-symbols %s | FileCheck %s
 
 program p
   ! CHECK: a size=4 offset=0: ObjectEntity type: LOGICAL(4)
   ! CHECK: b size=4 offset=4: ObjectEntity type: REAL(4)
   logical :: a = .false.
   real :: b = 9.73
   ! CHECK: a: AssocEntity type: REAL(4) expr:b
   ! CHECK: b: AssocEntity type: LOGICAL(4) expr:a
   associate (b => a, a => b)
     print*, a, b
   end associate
   print*, a, b
 end

flang/test/Semantics/rewrite01.f90

-! RUN: %f18 -fdebug-dump-parse-tree %s 2>&1 | FileCheck %s
+! RUN: %f18 -fsyntax-only -fdebug-dump-parse-tree %s 2>&1 | FileCheck %s
 ! Ensure that READ(CVAR) [, item-list] is corrected when CVAR is a
 ! character variable so as to be a formatted read from the default
 ! unit, not an unformatted read from an internal unit (which is not
 ! possible in Fortran).
 character :: cvar
 ! CHECK-NOT: IoUnit -> Variable -> Designator -> DataRef -> Name = 'cvar'
 ! CHECK: Format -> Expr = 'cvar'
 read(cvar)
 end

flang/test/Semantics/typeinfo01.f90

-!RUN: %f18 -fdebug-dump-symbols %s | FileCheck %s
+!RUN: %f18 -fsyntax-only -fdebug-dump-symbols %s | FileCheck %s
 ! Tests for derived type runtime descriptions
 
 module m01
   type :: t1
     integer :: n
   end type
 !CHECK: .c.t1, SAVE, TARGET: ObjectEntity type: TYPE(component) shape: 0_8:0_8 init:[component::component(name=.n.n,genre=1_1,category=0_1,kind=4_1,rank=0_1,offset=0_8,characterlen=value(genre=1_1,value=0_8),derived=NULL(),lenvalue=NULL(),bounds=NULL(),initialization=NULL())]
 !CHECK: .dt.t1, SAVE, TARGET: ObjectEntity type: TYPE(derivedtype) init:derivedtype(binding=NULL(),name=.n.t1,sizeinbytes=4_8,parent=NULL(),uninstantiated=NULL(),kindparameter=NULL(),lenparameterkind=NULL(),component=.c.t1,procptr=NULL(),special=NULL())

flang/tools/f18/f18.cpp

while (!args.empty()) {
     } else if (arg == "-falternative-parameter-statement") {
       options.features.Enable(
           Fortran::common::LanguageFeature::OldStyleParameter, true);
     } else if (arg == "-fdebug-dump-provenance") {
       driver.dumpProvenance = true;
       options.needProvenanceRangeToCharBlockMappings = true;
     } else if (arg == "-fdebug-dump-parse-tree") {
       driver.dumpParseTree = true;
-      driver.syntaxOnly = true;
     } else if (arg == "-fdebug-pre-fir-tree") {
       driver.dumpPreFirTree = true;
     } else if (arg == "-fdebug-dump-symbols") {
       driver.dumpSymbols = true;
-      driver.syntaxOnly = true;
     } else if (arg == "-fdebug-module-writer") {
       driver.debugModuleWriter = true;
     } else if (arg == "-fdebug-measure-parse-tree") {
       driver.measureTree = true;
     } else if (arg == "-fdebug-instrumented-parse") {
       options.instrumentedParse = true;
     } else if (arg == "-fdebug-no-semantics") {
       driver.debugNoSemantics = true;