User Details
- User Since
- Dec 15 2020, 3:47 AM (129 w, 1 d)
Feb 19 2021
Remove -fdebug-parsing-log from this patch as it requires additional work that can be implemented in a separate patch.
Also address review comments by @awarzynski
Feb 18 2021
Rebase off main
Feb 17 2021
Make semantics_ private
Feb 16 2021
Rebase off main
Rebase off main
Feb 15 2021
Thanks for clarifying
Thanks for working on this @awarzynski
Do you know what the use of GetActionKindName in FrontendOptions.h is, as it is currently not being called anywhere and whilst this patch currently does not update that method with the 2 new cases, even if it did no change would be visible.
Other than that, looks good to me!
Address review comment
This patch makes sense to me as the behaviour of the new driver is similar to clang in that only the last action-related option is run, e.g:
- Only -emit-llvm is run in: clang -cc1 -ast-dump -emit-llvm file.c
- Only -ast-dump is run in: clang -cc1 -emit-llvm -ast-dump file.c
This change will mean -fsyntax-only does not need to be specified when running -fdebug-dump-parse-tree or -fdebug-dump-symbols as it will always be run when either one of these action-related options are present.
LGTM!
Feb 10 2021
Feb 9 2021
Address review comment
Feb 8 2021
Rebase off main
Feb 4 2021
Thanks for working on this @awarzynski!
I've left a comment on the test but otherwise looks good to me.
Thanks for working on this @awarzynski, this patch allows actions that do not need to run the prescanner to not do so.
I've left a nit, but otherwise LRTM!
Feb 2 2021
Address review comment
Jan 29 2021
Remove -fno-fixed-form and -fno-free-form
Jan 28 2021
Address review comment
Jan 27 2021
Jan 26 2021
Jan 25 2021
Add f18 RUN line
Rename flang-driver to flang
Jan 22 2021
Jan 20 2021
Thanks for working on this @awarzynski
Jan 19 2021
I've built the latest main branch with -DBUILD_SHARED_LIBS=On and it failed. Applying this patch has resolved that.
Looks good to me.
Jan 18 2021
Remove target-specific predefinition
Jan 15 2021
Add helper methods to Utils
Add include-module test
Jan 14 2021
Update regression test
Jan 13 2021
Add a new test
Jan 12 2021
Jan 11 2021
Support more extensions
Jan 7 2021
Rename test files
Jan 6 2021
Address minor changes in review comments
Dec 23 2020
Clean up test
Address review comments
Dec 22 2020
Address review comments