This is the follow up to D93844.
Suppress the diagnostics when applying the child configurations, since they were printed on the first parse.
Paths
| Differential D96760
[clang-format] Suppress diagnostics on second parse ClosedPublic Authored by HazardyKnusperkeks on Feb 16 2021, 1:19 AM.
Details Summary This is the follow up to D93844. Suppress the diagnostics when applying the child configurations, since they were printed on the first parse.
Diff Detail
Event TimelineHazardyKnusperkeks created this revision. HazardyKnusperkeks added a parent revision: D93844: [clang-format] Add possibility to be based on parent directory.Feb 16 2021, 1:19 AM
Comment Actions I did have another plan for a different way to go about this, not sure if its really any better though.
Comment Actions
But then I need to rewrite the complete parsing process? Because in a normal style I can not parse, because it is not apparent which entries are changed because of the config, or do I oversee something?
And this is what you proposed. :)
Comment Actions
The diaghandler is a perfectly good solution, I was just spit balling ideas. But it is possible to store changes, though not much is gained for this use case. This revision is now accepted and ready to land.Mar 4 2021, 8:42 AM Closed by commit rGe7309404536c: [clang-format] Suppress diagnostics on second parse (authored by HazardyKnusperkeks). · Explain WhyMar 5 2021, 12:43 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 328614 clang/include/clang/Format/Format.h
clang/lib/Format/Format.cpp
|
I know this is sufficient for the purpose of this patch, however it doesn't make sense to accept take the handler parameter without also taking a void* for its context.