This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Correct rmw atomics s_waitcnt generation
ClosedPublic

Authored by t-tye on Feb 15 2021, 7:27 PM.

Details

Summary

The AMD GPU SIMemoryLegalizer was using the ordering address space
rather than the instruction address space when determining the
s_waitcnt to generate to ensure that a read-modify-write atomic has
completed. This resulted in additional unnecessary counters being
waited on.

Diff Detail

Event Timeline

t-tye created this revision.Feb 15 2021, 7:27 PM
t-tye requested review of this revision.Feb 15 2021, 7:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2021, 7:27 PM
rampitec accepted this revision.Feb 16 2021, 10:02 AM

LGTM. Thanks Tony!

This revision is now accepted and ready to land.Feb 16 2021, 10:02 AM
This revision was landed with ongoing or failed builds.Feb 16 2021, 5:33 PM
This revision was automatically updated to reflect the committed changes.