[llvm-objdump] Map STT_TLS to ST_Other (previously ST_Data)

[MaskRay]

Summary

ST_Data is used to model BFD BFD_OBJECT.
A STT_TLS symbol does not have the BFD_OBJECT flag in BFD.
This makes sense because a STT_TLS symbol is like in a different address space,
normal data/object properties do not apply on them.

With this change, a STT_TLS symbol will not be displayed as 'O'.
This new behavior matches objdump.

I think llvm-objdump is the only affected component by this change.

[jhenderson]

FYI, I'm off tomorrow and Friday, so won't be able to come back to this until Monday next week.

There are some LLD test failures, according to the pre-merge bot. Are they related to this patch? LGTM, assuming they aren't, or if they are all trivial fixes.

[MaskRay]

fix lld tests

llvm/include/llvm/Object/ELFObjectFile.h

ELFObjectFile<ELFT>::getSymbolType(DataRefImpl Symb) const {
   case ELF::STT_SECTION:
     return SymbolRef::ST_Debug;
   case ELF::STT_FILE:
     return SymbolRef::ST_File;
   case ELF::STT_FUNC:
     return SymbolRef::ST_Function;
   case ELF::STT_OBJECT:
   case ELF::STT_COMMON:
-  case ELF::STT_TLS:
     return SymbolRef::ST_Data;
+  case ELF::STT_TLS:
   default:
     return SymbolRef::ST_Other;
   }
 }
 
 template <class ELFT>
 Expected<uint32_t> ELFObjectFile<ELFT>::getSymbolFlags(DataRefImpl Sym) const {
   Expected<const Elf_Sym *> SymOrErr = getSymbol(Sym);

llvm/test/tools/llvm-objdump/ELF/symbol-table.test

 ## Test how --syms/-t prints the static symbol table.
 # RUN: yaml2obj --docnum=1 %s -o %t
 # RUN: llvm-objdump --syms %t > %t.txt
 # RUN: llvm-objdump -t %t | cmp - %t.txt
 # RUN: FileCheck %s --input-file=%t.txt --match-full-lines --strict-whitespace
 
 #      CHECK:SYMBOL TABLE:
 # CHECK-NEXT:0000000000000000 l    df *ABS* 0000000000000000 a.c
 # CHECK-NEXT:0000000000000000 l    d  .text 0000000000000000 .text
 # CHECK-NEXT:0000000000002000 l     O .data 0000000000000000 local_object
 # CHECK-NEXT:0000000000001fff l     F .text 0000000000000000 local_func
 # CHECK-NEXT:0000000000000000 l       *ABS* 0000000000000000 local_abs
 # CHECK-NEXT:0000000000000000 g       .data 0000000000000000 notype
 # CHECK-NEXT:0000000000000000 g     O .data 0000000000000010 object
 # CHECK-NEXT:0000000000000000 g     F .text 000000000000000f func
 # CHECK-NEXT:0000000000000000 g     O *COM* 0000000000000000 common
-# CHECK-NEXT:0000000000000000 g     O .data 0000000000000000 tls
+# CHECK-NEXT:0000000000000000 g       .data 0000000000000000 tls
 # CHECK-NEXT:0000000000000000 g   i   .text 0000000000000000 ifunc
 # CHECK-NEXT:0000000000000000 g       .text 0000000000000000 invalid_type
 # CHECK-NEXT:0000000000000000 g       .text 0000000000000000 STT_HIOS
 # CHECK-NEXT:0000000000000000 g       .text 0000000000000000 STT_LOPROC
 # CHECK-NEXT:0000000000000000         *UND* 0000000000000000 undef
 # CHECK-NEXT:0000000000000000         *UND* 0000000000000000 SHN_LOPROC
 # CHECK-NEXT:0000000000000000         *UND* 0000000000000000 SHN_LOOS
 # CHECK-NEXT:0000000000000000         *UND* 0000000000000000 reserve