This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] Map STT_TLS to ST_Other (previously ST_Data)
ClosedPublic

Authored by MaskRay on Feb 15 2021, 3:49 PM.

Details

Summary

ST_Data is used to model BFD BFD_OBJECT.
A STT_TLS symbol does not have the BFD_OBJECT flag in BFD.
This makes sense because a STT_TLS symbol is like in a different address space,
normal data/object properties do not apply on them.

With this change, a STT_TLS symbol will not be displayed as 'O'.
This new behavior matches objdump.

I think llvm-objdump is the only affected component by this change.

Diff Detail

Event Timeline

MaskRay created this revision.Feb 15 2021, 3:49 PM
MaskRay requested review of this revision.Feb 15 2021, 3:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2021, 3:49 PM
jhenderson accepted this revision.Feb 17 2021, 1:41 AM

FYI, I'm off tomorrow and Friday, so won't be able to come back to this until Monday next week.

There are some LLD test failures, according to the pre-merge bot. Are they related to this patch? LGTM, assuming they aren't, or if they are all trivial fixes.

This revision is now accepted and ready to land.Feb 17 2021, 1:41 AM
MaskRay updated this revision to Diff 324534.Feb 17 2021, 11:15 PM

fix lld tests

This revision was landed with ongoing or failed builds.Feb 17 2021, 11:17 PM
This revision was automatically updated to reflect the committed changes.