Page MenuHomePhabricator

[ARM] Use rGPR for writeback vldrs
ClosedPublic

Authored by dmgreen on Feb 15 2021, 10:11 AM.

Details

Summary

From what I can tell, a writeback is unpredictable with LR for both loads and stores. This changes the operand from a gprnopc to a rGPR in both cases (which I believe is essentially a NOP due to the tied-def already being a rGPR.)

Diff Detail

Event Timeline

dmgreen created this revision.Feb 15 2021, 10:11 AM
dmgreen requested review of this revision.Feb 15 2021, 10:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2021, 10:11 AM
simon_tatham accepted this revision.Feb 16 2021, 4:44 AM

Oh yes, I must have seen if Rn == '1101' && W == '1' and absentmindedly interpreted the W as a write to memory, not a write back to the register.

This revision is now accepted and ready to land.Feb 16 2021, 4:44 AM
This revision was automatically updated to reflect the committed changes.