This is an archive of the discontinued LLVM Phabricator instance.

Differential D96673

[GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE
ClosedPublic

Authored by porglezomp on Feb 14 2021, 3:39 PM.

Details

Reviewers
aemerson
paquette
arsenm
Commits
rG8f956a5e8f5a: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE

Diff Detail

Event Timeline

porglezomp created this revision.Feb 14 2021, 3:39 PM
Herald added subscribers: hiraditya, rovka. · View Herald TranscriptFeb 14 2021, 3:39 PM
porglezomp requested review of this revision.Feb 14 2021, 3:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2021, 3:39 PM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B89170: Diff 323640.Feb 14 2021, 3:40 PM
porglezomp added a parent revision: D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.Feb 14 2021, 3:40 PM
porglezomp added a child revision: D96676: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization.Feb 14 2021, 3:43 PM
porglezomp updated this revision to Diff 324726.Feb 18 2021, 12:03 PM

Change unittest buildInstr to more specific build* calls

porglezomp updated this revision to Diff 324727.Feb 18 2021, 12:05 PM

Remove ";" file I accidentally added

Harbormaster completed remote builds in B89770: Diff 324727.Feb 18 2021, 1:13 PM
Harbormaster completed remote builds in B89769: Diff 324726.
arsenm added inline comments.Feb 18 2021, 2:56 PM
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
4511

No Optional

porglezomp updated this revision to Diff 324832.Feb 18 2021, 6:04 PM

Change Optional<Register> to Register, change a >= to == since it's all that's needed

arsenm accepted this revision.Feb 18 2021, 6:36 PM

LGTM with test nits

llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
1052–1053

EXPECT_EQ(Legalized, ...)

1078–1081

You don't actually need to define the legalizer rule since you are directly calling the implementation

1091–1092

EXPECT_EQ

1130–1131

EXPECT_EQ

1169–1170

EXPECT_EQ

This revision is now accepted and ready to land.Feb 18 2021, 6:36 PM
Harbormaster completed remote builds in B89835: Diff 324832.Feb 18 2021, 8:25 PM
porglezomp updated this revision to Diff 324890.Feb 18 2021, 10:58 PM

Change some EXPECT_TRUE to EXPECT_EQ

Harbormaster completed remote builds in B89874: Diff 324890.Feb 19 2021, 12:40 AM
arsenm added inline comments.Feb 19 2021, 5:32 AM
llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
1052–1053

These should be swapped to get the correct failure message

porglezomp updated this revision to Diff 325042.Feb 19 2021, 11:00 AM

Flip argument order of EXPECT_EQ for better failure messages

Harbormaster completed remote builds in B89952: Diff 325042.Feb 19 2021, 12:03 PM
Closed by commit rG8f956a5e8f5a: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE (authored by porglezomp). · Explain WhyFeb 22 2021, 5:00 PM
This revision was automatically updated to reflect the committed changes.
porglezomp added a commit: rG8f956a5e8f5a: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Revision Contents

PathSize
llvm/
;/
unittests/
CodeGen/
GlobalISel/
LegalizerHelperTest.cpp
156 lines
lib/
CodeGen/
GlobalISel/
22 lines
unittests/
CodeGen/
GlobalISel/
156 lines

Diff 324726

llvm/;

  • This file was copied from llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp.
Show First 20 Lines • Show All 1,022 Lines • ▼ Show 20 LinesTEST_F(AArch64GISelMITest, NarrowSSUBO) {
CHECK: [[SSUBO1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_ CHECK: [[SSUBO1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[SSUBO2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SSUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_ CHECK: [[SSUBO2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SSUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[SSUBO:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SSUBO0]]:_(s32), [[SSUBO1]]:_(s32), [[SSUBO2]]:_(s32) CHECK: [[SSUBO:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SSUBO0]]:_(s32), [[SSUBO1]]:_(s32), [[SSUBO2]]:_(s32)
)"; )";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF; EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
} }
TEST_F(AArch64GISelMITest, NarrowUADDE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder(G_UADDE).legalFor(
{{LLT::scalar(32), LLT::scalar(1)}});
});
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto UADDE = B.buildUAdde(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*UADDE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[UADDE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_UADDE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[UADDE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_UADDE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[UADDE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_UADDE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[UADDE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[UADDE0]]:_(s32), [[UADDE1]]:_(s32), [[UADDE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, NarrowUSUBE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder(G_USUBE).legalFor(
{{LLT::scalar(32), LLT::scalar(1)}});
});
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto USUBE = B.buildUSube(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*USUBE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[USUBE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_USUBE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[USUBE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[USUBE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_USUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[USUBE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[USUBE0]]:_(s32), [[USUBE1]]:_(s32), [[USUBE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, NarrowSADDE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder({G_SADDE, G_UADDE})
.legalFor({{LLT::scalar(32), LLT::scalar(1)}});
});
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto SADDE = B.buildSAdde(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*SADDE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[SADDE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_UADDE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[SADDE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_UADDE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[SADDE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SADDE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[SADDE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SADDE0]]:_(s32), [[SADDE1]]:_(s32), [[SADDE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, NarrowSSUBE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder({G_SSUBE, G_USUBE})
.legalFor({{LLT::scalar(32), LLT::scalar(1)}});
});
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto SSUBE = B.buildSSube(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*SSUBE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[SSUBE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_USUBE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[SSUBE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[SSUBE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SSUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[SSUBE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SSUBE0]]:_(s32), [[SSUBE1]]:_(s32), [[SSUBE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, FewerElementsAnd) { TEST_F(AArch64GISelMITest, FewerElementsAnd) {
setUp(); setUp();
if (!TM) if (!TM)
return; return;
const LLT V2S32 = LLT::vector(2, 32); const LLT V2S32 = LLT::vector(2, 32);
const LLT V5S32 = LLT::vector(5, 32); const LLT V5S32 = LLT::vector(5, 32);
▲ Show 20 Lines • Show All 2,575 Lines • Show Last 20 Lines

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Show First 20 Lines • Show All 857 Lines • ▼ Show 20 LinesLegalizerHelper::LegalizeResult LegalizerHelper::narrowScalar(MachineInstr &MI,
} }
case TargetOpcode::G_FREEZE: case TargetOpcode::G_FREEZE:
return reduceOperationWidth(MI, TypeIdx, NarrowTy); return reduceOperationWidth(MI, TypeIdx, NarrowTy);
case TargetOpcode::G_ADD: case TargetOpcode::G_ADD:
case TargetOpcode::G_SUB: case TargetOpcode::G_SUB:
case TargetOpcode::G_SADDO: case TargetOpcode::G_SADDO:
case TargetOpcode::G_SSUBO: case TargetOpcode::G_SSUBO:
case TargetOpcode::G_SADDE:
case TargetOpcode::G_SSUBE:
case TargetOpcode::G_UADDO: case TargetOpcode::G_UADDO:
case TargetOpcode::G_USUBO: case TargetOpcode::G_USUBO:
case TargetOpcode::G_UADDE:
case TargetOpcode::G_USUBE:
return narrowScalarAddSub(MI, TypeIdx, NarrowTy); return narrowScalarAddSub(MI, TypeIdx, NarrowTy);
case TargetOpcode::G_MUL: case TargetOpcode::G_MUL:
case TargetOpcode::G_UMULH: case TargetOpcode::G_UMULH:
return narrowScalarMul(MI, NarrowTy); return narrowScalarMul(MI, NarrowTy);
case TargetOpcode::G_EXTRACT: case TargetOpcode::G_EXTRACT:
return narrowScalarExtract(MI, TypeIdx, NarrowTy); return narrowScalarExtract(MI, TypeIdx, NarrowTy);
case TargetOpcode::G_INSERT: case TargetOpcode::G_INSERT:
return narrowScalarInsert(MI, TypeIdx, NarrowTy); return narrowScalarInsert(MI, TypeIdx, NarrowTy);
▲ Show 20 Lines • Show All 3,591 Lines • ▼ Show 20 LinesLegalizerHelper::narrowScalarAddSub(MachineInstr &MI, unsigned TypeIdx,
// Expand in terms of carry-setting/consuming G_<Op>E instructions. // Expand in terms of carry-setting/consuming G_<Op>E instructions.
int NumParts = SizeOp0 / NarrowTy.getSizeInBits(); int NumParts = SizeOp0 / NarrowTy.getSizeInBits();
unsigned Opcode = MI.getOpcode(); unsigned Opcode = MI.getOpcode();
unsigned OpO, OpE, OpF; unsigned OpO, OpE, OpF;
switch (Opcode) { switch (Opcode) {
case TargetOpcode::G_SADDO: case TargetOpcode::G_SADDO:
case TargetOpcode::G_SADDE:
case TargetOpcode::G_UADDO: case TargetOpcode::G_UADDO:
case TargetOpcode::G_UADDE:
case TargetOpcode::G_ADD: case TargetOpcode::G_ADD:
OpO = TargetOpcode::G_UADDO; OpO = TargetOpcode::G_UADDO;
OpE = TargetOpcode::G_UADDE; OpE = TargetOpcode::G_UADDE;
OpF = TargetOpcode::G_UADDE; OpF = TargetOpcode::G_UADDE;
if (Opcode == TargetOpcode::G_SADDO) if (Opcode == TargetOpcode::G_SADDO || Opcode == TargetOpcode::G_SADDE)
OpF = TargetOpcode::G_SADDE; OpF = TargetOpcode::G_SADDE;
break; break;
case TargetOpcode::G_SSUBO: case TargetOpcode::G_SSUBO:
case TargetOpcode::G_SSUBE:
case TargetOpcode::G_USUBO: case TargetOpcode::G_USUBO:
case TargetOpcode::G_USUBE:
case TargetOpcode::G_SUB: case TargetOpcode::G_SUB:
OpO = TargetOpcode::G_USUBO; OpO = TargetOpcode::G_USUBO;
OpE = TargetOpcode::G_USUBE; OpE = TargetOpcode::G_USUBE;
OpF = TargetOpcode::G_USUBE; OpF = TargetOpcode::G_USUBE;
if (Opcode == TargetOpcode::G_SSUBO) if (Opcode == TargetOpcode::G_SSUBO || Opcode == TargetOpcode::G_SSUBE)
OpF = TargetOpcode::G_SSUBE; OpF = TargetOpcode::G_SSUBE;
break; break;
default: default:
llvm_unreachable("Unexpected add/sub opcode!"); llvm_unreachable("Unexpected add/sub opcode!");
} }
// 1 for a plain add/sub, 2 if this is an operation with a carry-out. // 1 for a plain add/sub, 2 if this is an operation with a carry-out.
unsigned NumDefs = MI.getNumExplicitDefs(); unsigned NumDefs = MI.getNumExplicitDefs();
Register Src1 = MI.getOperand(NumDefs).getReg(); Register Src1 = MI.getOperand(NumDefs).getReg();
Register Src2 = MI.getOperand(NumDefs + 1).getReg(); Register Src2 = MI.getOperand(NumDefs + 1).getReg();
Register CarryDst; Register CarryDst;
if (NumDefs == 2) if (NumDefs == 2)
CarryDst = MI.getOperand(1).getReg(); CarryDst = MI.getOperand(1).getReg();
Optional<Register> CarryIn = None;
arsenmUnsubmitted
Not Done
ReplyInline Actions

No Optional

arsenm: No Optional
if (MI.getNumOperands() >= NumDefs + 3)
CarryIn = MI.getOperand(NumDefs + 2).getReg();
SmallVector<Register, 2> Src1Regs, Src2Regs, DstRegs; SmallVector<Register, 2> Src1Regs, Src2Regs, DstRegs;
extractParts(Src1, NarrowTy, NumParts, Src1Regs); extractParts(Src1, NarrowTy, NumParts, Src1Regs);
extractParts(Src2, NarrowTy, NumParts, Src2Regs); extractParts(Src2, NarrowTy, NumParts, Src2Regs);
Register CarryIn;
for (int i = 0; i < NumParts; ++i) { for (int i = 0; i < NumParts; ++i) {
Register DstReg = MRI.createGenericVirtualRegister(NarrowTy); Register DstReg = MRI.createGenericVirtualRegister(NarrowTy);
Register CarryOut = MRI.createGenericVirtualRegister(LLT::scalar(1)); Register CarryOut = MRI.createGenericVirtualRegister(LLT::scalar(1));
// Forward the final carry-out to the destination register // Forward the final carry-out to the destination register
if (i == NumParts - 1 && CarryDst) if (i == NumParts - 1 && CarryDst)
CarryOut = CarryDst; CarryOut = CarryDst;
if (i == 0) { if (!CarryIn) {
MIRBuilder.buildInstr(OpO, {DstReg, CarryOut}, MIRBuilder.buildInstr(OpO, {DstReg, CarryOut},
{Src1Regs[i], Src2Regs[i]}); {Src1Regs[i], Src2Regs[i]});
} else if (i == NumParts - 1) { } else if (i == NumParts - 1) {
MIRBuilder.buildInstr(OpF, {DstReg, CarryOut}, MIRBuilder.buildInstr(OpF, {DstReg, CarryOut},
{Src1Regs[i], Src2Regs[i], CarryIn}); {Src1Regs[i], Src2Regs[i], *CarryIn});
} else { } else {
MIRBuilder.buildInstr(OpE, {DstReg, CarryOut}, MIRBuilder.buildInstr(OpE, {DstReg, CarryOut},
{Src1Regs[i], Src2Regs[i], CarryIn}); {Src1Regs[i], Src2Regs[i], *CarryIn});
} }
DstRegs.push_back(DstReg); DstRegs.push_back(DstReg);
CarryIn = CarryOut; CarryIn = CarryOut;
} }
MIRBuilder.buildMerge(DstReg, DstRegs); MIRBuilder.buildMerge(DstReg, DstRegs);
MI.eraseFromParent(); MI.eraseFromParent();
return Legalized; return Legalized;
▲ Show 20 Lines • Show All 1,796 Lines • Show Last 20 Lines

llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

  • This file was copied to llvm/;.
Show First 20 Lines • Show All 1,022 Lines • ▼ Show 20 LinesTEST_F(AArch64GISelMITest, NarrowSSUBO) {
CHECK: [[SSUBO1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_ CHECK: [[SSUBO1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[SSUBO2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SSUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_ CHECK: [[SSUBO2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SSUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[SSUBO:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SSUBO0]]:_(s32), [[SSUBO1]]:_(s32), [[SSUBO2]]:_(s32) CHECK: [[SSUBO:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SSUBO0]]:_(s32), [[SSUBO1]]:_(s32), [[SSUBO2]]:_(s32)
)"; )";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF; EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
} }
TEST_F(AArch64GISelMITest, NarrowUADDE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder(G_UADDE).legalFor(
{{LLT::scalar(32), LLT::scalar(1)}});
});
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto UADDE = B.buildUAdde(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*UADDE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
arsenmUnsubmitted
Not Done
ReplyInline Actions

EXPECT_EQ(Legalized, ...)

arsenm: EXPECT_EQ(Legalized, ...)
arsenmUnsubmitted
Not Done
ReplyInline Actions

These should be swapped to get the correct failure message

arsenm: These should be swapped to get the correct failure message
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[UADDE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_UADDE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[UADDE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_UADDE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[UADDE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_UADDE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[UADDE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[UADDE0]]:_(s32), [[UADDE1]]:_(s32), [[UADDE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, NarrowUSUBE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder(G_USUBE).legalFor(
{{LLT::scalar(32), LLT::scalar(1)}});
});
arsenmUnsubmitted
Not Done
ReplyInline Actions

You don't actually need to define the legalizer rule since you are directly calling the implementation

arsenm: You don't actually need to define the legalizer rule since you are directly calling the…
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto USUBE = B.buildUSube(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*USUBE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
arsenmUnsubmitted
Not Done
ReplyInline Actions

EXPECT_EQ

arsenm: EXPECT_EQ
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[USUBE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_USUBE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[USUBE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[USUBE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_USUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[USUBE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[USUBE0]]:_(s32), [[USUBE1]]:_(s32), [[USUBE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, NarrowSADDE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder({G_SADDE, G_UADDE})
.legalFor({{LLT::scalar(32), LLT::scalar(1)}});
});
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto SADDE = B.buildSAdde(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*SADDE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
arsenmUnsubmitted
Not Done
ReplyInline Actions

EXPECT_EQ

arsenm: EXPECT_EQ
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[SADDE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_UADDE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[SADDE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_UADDE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[SADDE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SADDE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[SADDE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SADDE0]]:_(s32), [[SADDE1]]:_(s32), [[SADDE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, NarrowSSUBE) {
setUp();
if (!TM)
return;
LLT S1 = LLT::scalar(1);
LLT S32 = LLT::scalar(32);
LLT S96 = LLT::scalar(96);
DefineLegalizerInfo(A, {
getActionDefinitionsBuilder({G_SSUBE, G_USUBE})
.legalFor({{LLT::scalar(32), LLT::scalar(1)}});
});
auto Op0 = B.buildUndef(S96);
auto Op1 = B.buildUndef(S96);
auto Op2 = B.buildUndef(S1);
auto SSUBE = B.buildSSube(S96, S1, Op0, Op1, Op2);
AInfo Info(MF->getSubtarget());
DummyGISelObserver Observer;
LegalizerHelper Helper(*MF, Info, Observer, B);
EXPECT_TRUE(Helper.narrowScalar(*SSUBE, 0, S32) ==
LegalizerHelper::LegalizeResult::Legalized);
arsenmUnsubmitted
Not Done
ReplyInline Actions

EXPECT_EQ

arsenm: EXPECT_EQ
const char *CheckStr = R"(
CHECK: [[IMP_DEF0:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF1:%[0-9]+]]:_(s96) = G_IMPLICIT_DEF
CHECK: [[IMP_DEF2:%[0-9]+]]:_(s1) = G_IMPLICIT_DEF
CHECK: [[OP0_0:%[0-9]+]]:_(s32), [[OP0_1:%[0-9]+]]:_(s32), [[OP0_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF0]]
CHECK: [[OP1_0:%[0-9]+]]:_(s32), [[OP1_1:%[0-9]+]]:_(s32), [[OP1_2:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[IMP_DEF1]]
CHECK: [[SSUBE0:%[0-9]+]]:_(s32), [[CARRY0:%[0-9]+]]:_(s1) = G_USUBE [[OP0_0]]:_, [[OP1_0]]:_, [[IMP_DEF2]]:_
CHECK: [[SSUBE1:%[0-9]+]]:_(s32), [[CARRY1:%[0-9]+]]:_(s1) = G_USUBE [[OP0_1]]:_, [[OP1_1]]:_, [[CARRY0]]:_
CHECK: [[SSUBE2:%[0-9]+]]:_(s32), [[CARRY2:%[0-9]+]]:_(s1) = G_SSUBE [[OP0_2]]:_, [[OP1_2]]:_, [[CARRY1]]:_
CHECK: [[SSUBE:%[0-9]+]]:_(s96) = G_MERGE_VALUES [[SSUBE0]]:_(s32), [[SSUBE1]]:_(s32), [[SSUBE2]]:_(s32)
)";
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
}
TEST_F(AArch64GISelMITest, FewerElementsAnd) { TEST_F(AArch64GISelMITest, FewerElementsAnd) {
setUp(); setUp();
if (!TM) if (!TM)
return; return;
const LLT V2S32 = LLT::vector(2, 32); const LLT V2S32 = LLT::vector(2, 32);
const LLT V5S32 = LLT::vector(5, 32); const LLT V5S32 = LLT::vector(5, 32);
▲ Show 20 Lines • Show All 2,575 Lines • Show Last 20 Lines