This is an archive of the discontinued LLVM Phabricator instance.

Differential D96645

fix linalg ods gen cross compiling like other gen executables
ClosedPublic

Authored by daquexian on Feb 13 2021, 3:25 AM.

Details

Reviewers
nicolasvasilache
vinograd47
ftynse
Commits
rG6e31a6b7c25f: fix linalg ods gen cross compiling like other gen executables
Summary

Signed-off-by: daquexian <daquexian566@gmail.com>

Diff Detail

Event Timeline

daquexian created this revision.Feb 13 2021, 3:25 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 15 others. · View Herald TranscriptFeb 13 2021, 3:25 AM
daquexian requested review of this revision.Feb 13 2021, 3:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2021, 3:25 AM
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
daquexian updated this revision to Diff 323543.Feb 13 2021, 3:28 AM

Add cmake cache var for mlir-linalg-ods-gen like tablegen executables

daquexian added reviewers: nicolasvasilache, vinograd47, ftynse.Feb 13 2021, 3:32 AM
Harbormaster completed remote builds in B89104: Diff 323542.Feb 13 2021, 3:55 AM
vinograd47 accepted this revision.Feb 13 2021, 4:03 AM

Looks OK to me.

This revision is now accepted and ready to land.Feb 13 2021, 4:03 AM
Harbormaster completed remote builds in B89105: Diff 323543.Feb 13 2021, 4:04 AM
daquexian added a comment.Feb 13 2021, 5:15 AM

@vinograd47 I don't have commit access. Could you please help me land it? Thanks very much!

Closed by commit rG6e31a6b7c25f: fix linalg ods gen cross compiling like other gen executables (authored by daquexian, committed by mehdi_amini). · Explain WhyFeb 13 2021, 11:18 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG6e31a6b7c25f: fix linalg ods gen cross compiling like other gen executables.
MaskRay mentioned this in rG3643828b5147: [CMake][mlir] Fix mlir-linalg-ods-gen/CMakeLists.txt after D96645.Feb 13 2021, 2:17 PM

Revision Contents

PathSize
mlir/
tools/
mlir-linalg-ods-gen/
19 lines

Diff 323563

mlir/tools/mlir-linalg-ods-gen/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Core Core
Support Support
) )
add_llvm_tool(mlir-linalg-ods-gen add_llvm_tool(mlir-linalg-ods-gen
mlir-linalg-ods-gen.cpp mlir-linalg-ods-gen.cpp
) )
llvm_update_compile_flags(mlir-linalg-ods-gen) llvm_update_compile_flags(mlir-linalg-ods-gen)
target_link_libraries(mlir-linalg-ods-gen PRIVATE target_link_libraries(mlir-linalg-ods-gen PRIVATE
MLIRSupport MLIRSupport
MLIRIR MLIRIR
) )
set(MLIR_LINALG_ODS_GEN_EXE mlir-linalg-ods-gen PARENT_SCOPE) set(MLIR_LINALG_ODS_GEN mlir-linalg-ods-gen CACHE
STRING "Native mlir-linalg-ods-gen executable. Saves building one when cross-compiling.")
set(MLIR_LINALG_ODS_GEN_EXE ${MLIR_LINALG_ODS_GEN} PARENT_SCOPE)
set(MLIR_LINALG_ODS_GEN_TARGET mlir-linalg-ods-gen PARENT_SCOPE) set(MLIR_LINALG_ODS_GEN_TARGET mlir-linalg-ods-gen PARENT_SCOPE)
if(LLVM_USE_HOST_TOOLS) if(LLVM_USE_HOST_TOOLS)
if (${MLIR_LINALG_ODS_GEN_EXE} STREQUAL mlir-linalg-ods-gen)
build_native_tool(mlir-linalg-ods-gen MLIR_LINALG_ODS_GEN_EXE DEPENDS mlir-linalg-ods-gen) build_native_tool(mlir-linalg-ods-gen MLIR_LINALG_ODS_GEN_EXE DEPENDS mlir-linalg-ods-gen)
set(MLIR_LINALG_ODS_GEN_EXE ${MLIR_LINALG_ODS_GEN_EXE} PARENT_SCOPE) set(MLIR_LINALG_ODS_GEN_EXE ${MLIR_LINALG_ODS_GEN_EXE} PARENT_SCOPE)
add_custom_target(mlir-linalg-ods-gen-host DEPENDS ${MLIR_LINALG_ODS_GEN_EXE}) add_custom_target(mlir-linalg-ods-gen-host DEPENDS ${MLIR_LINALG_ODS_GEN_EXE})
set(MLIR_LINALG_ODS_GEN_TARGET mlir-linalg-ods-gen-host DEPENDS PARENT_SCOPE) set(MLIR_LINALG_ODS_GEN_TARGET mlir-linalg-ods-gen-host DEPENDS PARENT_SCOPE)
if(NOT LLVM_BUILD_UTILS) if(NOT LLVM_BUILD_UTILS)
set_target_properties(mlir-linalg-ods-gen PROPERTIES EXCLUDE_FROM_ALL ON) set_target_properties(mlir-linalg-ods-gen PROPERTIES EXCLUDE_FROM_ALL ON)
endif() endif()
endif() endif()
endif()