This is an archive of the discontinued LLVM Phabricator instance.

Differential D96618

[CMake] Don't optimize tests so much under ThinLTO
ClosedPublic

Authored by aeubanks on Feb 12 2021, 10:47 AM.

Details

Reviewers
thakis
hans
Commits
rGe765324d89ef: [CMake] Don't optimize tests so much under ThinLTO
Summary

This drops check-llvm under -DLLVM_ENABLE_LTO=Thin from 13m to 10m20s on Windows and 20m to 15m35s on Linux.

Diff Detail

Unit TestsFailed

TimeTest
290 msx64 debian > MemProfiler-x86_64-linux-dynamic.TestCases::test_malloc_load_store.c
430 msx64 debian > MemProfiler-x86_64-linux.TestCases::test_malloc_load_store.c
2,400 msx64 debian > libarcher.races::lock-unrelated.c

Event Timeline

aeubanks created this revision.Feb 12 2021, 10:47 AM
Herald added subscribers: mstorsjo, inglorion, mgorny. · View Herald TranscriptFeb 12 2021, 10:47 AM
aeubanks requested review of this revision.Feb 12 2021, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2021, 10:47 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks edited the summary of this revision. (Show Details)Feb 12 2021, 11:30 AM
aeubanks added reviewers: thakis, hans.
Harbormaster completed remote builds in B89028: Diff 323398.Feb 12 2021, 12:15 PM
hans accepted this revision.Feb 16 2021, 5:27 AM
This revision is now accepted and ready to land.Feb 16 2021, 5:27 AM
This revision was landed with ongoing or failed builds.Feb 22 2021, 3:14 PM
Closed by commit rGe765324d89ef: [CMake] Don't optimize tests so much under ThinLTO (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGe765324d89ef: [CMake] Don't optimize tests so much under ThinLTO.

Revision Contents

PathSize
llvm/
cmake/
modules/
12 lines

Diff 323398

llvm/cmake/modules/AddLLVM.cmake

Show First 20 Lines • Show All 1,445 Lines • ▼ Show 20 Linesfunction(add_unittest test_suite test_name)
if(SUPPORTS_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS_FLAG) if(SUPPORTS_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS_FLAG)
list(APPEND LLVM_COMPILE_FLAGS "-Wno-gnu-zero-variadic-macro-arguments") list(APPEND LLVM_COMPILE_FLAGS "-Wno-gnu-zero-variadic-macro-arguments")
endif() endif()
set(LLVM_REQUIRES_RTTI OFF) set(LLVM_REQUIRES_RTTI OFF)
list(APPEND LLVM_LINK_COMPONENTS Support) # gtest needs it for raw_ostream list(APPEND LLVM_LINK_COMPONENTS Support) # gtest needs it for raw_ostream
add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH ${ARGN}) add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH ${ARGN})
# The runtime benefits of ThinLTO don't outweight the compile time costs for tests.
if(uppercase_LLVM_ENABLE_LTO STREQUAL "THIN")
if((UNIX OR MINGW) AND LLVM_USE_LINKER STREQUAL "lld")
set_property(TARGET ${test_name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,--lto-O0")
elseif(LINKER_IS_LLD_LINK)
set_property(TARGET ${test_name} APPEND_STRING PROPERTY
LINK_FLAGS " /opt:lldlto=0")
endif()
endif()
set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}) set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR})
set_output_directory(${test_name} BINARY_DIR ${outdir} LIBRARY_DIR ${outdir}) set_output_directory(${test_name} BINARY_DIR ${outdir} LIBRARY_DIR ${outdir})
# libpthreads overrides some standard library symbols, so main # libpthreads overrides some standard library symbols, so main
# executable must be linked with it in order to provide consistent # executable must be linked with it in order to provide consistent
# API for all shared libaries loaded by this executable. # API for all shared libaries loaded by this executable.
target_link_libraries(${test_name} PRIVATE gtest_main gtest ${LLVM_PTHREAD_LIB}) target_link_libraries(${test_name} PRIVATE gtest_main gtest ${LLVM_PTHREAD_LIB})
add_dependencies(${test_suite} ${test_name}) add_dependencies(${test_suite} ${test_name})
▲ Show 20 Lines • Show All 711 Lines • Show Last 20 Lines