Page MenuHomePhabricator

[mlir] Allow users of `PromoteBuffersToStackPass` to customize `small buffer` func.
ClosedPublic

Authored by pifon2a on Feb 12 2021, 12:54 AM.

Diff Detail

Event Timeline

pifon2a created this revision.Feb 12 2021, 12:54 AM
pifon2a requested review of this revision.Feb 12 2021, 12:54 AM
rriddle added inline comments.Feb 12 2021, 12:58 AM
mlir/lib/Transforms/BufferOptimizations.cpp
302

Use function_ref here instead.

377–384

This looks like something that should be computed during initialization.

388

The = nullptr is unnecessary.

pifon2a updated this revision to Diff 323239.Feb 12 2021, 12:59 AM

Add explicit

pifon2a updated this revision to Diff 323241.Feb 12 2021, 1:04 AM
pifon2a marked 2 inline comments as done.

Address River's comments.

pifon2a marked an inline comment as done.Feb 12 2021, 1:05 AM
pifon2a added inline comments.
mlir/lib/Transforms/BufferOptimizations.cpp
377–384

I tried it before, but then the command-line options won't work.

akuegel accepted this revision.Feb 12 2021, 1:08 AM
This revision is now accepted and ready to land.Feb 12 2021, 1:08 AM
This revision was landed with ongoing or failed builds.Feb 12 2021, 1:12 AM
This revision was automatically updated to reflect the committed changes.
pifon2a marked an inline comment as done.
rriddle added inline comments.Feb 12 2021, 1:14 AM
mlir/lib/Transforms/BufferOptimizations.cpp
377–384

You can either override initialize or override initializeOptions and do it there.

pifon2a added inline comments.Feb 12 2021, 1:30 AM