Implements parts of:
- P0898R3 Standard Library Concepts
- P1754 Rename concepts to standard_case for C++20, while we still can
Paths
| Differential D96577
[libcxx] adds concept `std::uniform_random_bit_generator` ClosedPublic Authored by cjdb on Feb 12 2021, 12:21 AM.
Details
Summary Implements parts of:
Diff Detail
Event TimelineComment Actions Thanks for working on this. It is missing uglification but besides that I only have one small nit
Comment Actions @ldionne can we override the Mac OS format failure? What it's proposing is abominable. Comment Actions
Yes there seems to be a bug in that code. I've put it in a block for GCC specific code. (This is not obvious due to the lack of indention of the section.)
Comment Actions
Oh, it might be because Clang's concepts are incomplete and so the feature-test macro's value is too high for us? Anyway, if you update everything in one fell swoop, I think that'd be best :-) Comment Actions
No it was the placement in the file. But I'll fix <random> and <concept> after the fix has landed.
Comment Actions LGTM apart for the nitpick. Let's settle on what we do about it and ship this.
This revision is now accepted and ready to land.Feb 17 2021, 2:28 PM
Closed by commit rG9f4f6ac94bfc: [libcxx] adds concept `std::uniform_random_bit_generator` (authored by cjdb). · Explain WhyFeb 18 2021, 5:48 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 323232 libcxx/include/random
libcxx/test/std/concepts/lang/arithmetic.pass.cpp
libcxx/test/std/numerics/rand/rand.req/rand.req.urng/nothing_to_do.pass.cpp
libcxx/test/std/numerics/rand/rand.req/rand.req.urng/uniform_random_bit_generator.compile.pass.cpp
|
Please add comment this has been added in C++20.