This is an archive of the discontinued LLVM Phabricator instance.

Differential D96573

[Clang][ASan] Teach Clang to not emit ASan module destructors when compiling with `-mkernel` or `-fapple-kext`.
ClosedPublic

Authored by delcypher on Feb 11 2021, 7:38 PM.

Details

Reviewers
arphaman
kubamracek
yln
aralisza
kcc
vitalybuka
Commits
rGfdce098b49cb: [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling…
Summary

rdar://71609176

Diff Detail

Unit TestsFailed

TimeTest
360 msx64 debian > libarcher.races::task-dependency.c
360 msx64 debian > libarcher.races::task-taskgroup-unrelated.c
310 msx64 debian > libarcher.races::task-taskwait-nested.c
400 msx64 debian > libarcher.races::task-two.c
340 msx64 debian > libarcher.task::task-barrier.c
View Full Test Results (13 Failed)

Revision Contents

PathSize
clang/
lib/
Driver/
6 lines
test/
Driver/
15 lines

Diff 323214

clang/lib/Driver/SanitizerArgs.cpp

Show First 20 Lines • Show All 819 Lines • ▼ Show 20 Lines if (AllAddedKinds & SanitizerKind::Address) {
if (AllAddedKinds & SanitizerKind::PointerCompare & ~AllRemove) { if (AllAddedKinds & SanitizerKind::PointerCompare & ~AllRemove) {
AsanInvalidPointerCmp = true; AsanInvalidPointerCmp = true;
} }
if (AllAddedKinds & SanitizerKind::PointerSubtract & ~AllRemove) { if (AllAddedKinds & SanitizerKind::PointerSubtract & ~AllRemove) {
AsanInvalidPointerSub = true; AsanInvalidPointerSub = true;
} }
if (TC.getTriple().isOSDarwin() &&
(Args.hasArg(options::OPT_mkernel) ||
Args.hasArg(options::OPT_fapple_kext))) {
AsanDtorKind = llvm::AsanDtorKind::None;
}
if (const auto *Arg = if (const auto *Arg =
Args.getLastArg(options::OPT_sanitize_address_destructor_kind_EQ)) { Args.getLastArg(options::OPT_sanitize_address_destructor_kind_EQ)) {
auto parsedAsanDtorKind = AsanDtorKindFromString(Arg->getValue()); auto parsedAsanDtorKind = AsanDtorKindFromString(Arg->getValue());
if (parsedAsanDtorKind == llvm::AsanDtorKind::Invalid) { if (parsedAsanDtorKind == llvm::AsanDtorKind::Invalid) {
TC.getDriver().Diag(clang::diag::err_drv_unsupported_option_argument) TC.getDriver().Diag(clang::diag::err_drv_unsupported_option_argument)
<< Arg->getOption().getName() << Arg->getValue(); << Arg->getOption().getName() << Arg->getValue();
} }
AsanDtorKind = parsedAsanDtorKind; AsanDtorKind = parsedAsanDtorKind;
▲ Show 20 Lines • Show All 407 Lines • Show Last 20 Lines

clang/test/Driver/darwin-asan-mkernel-kext.c

  • This file was added.
// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=address -mkernel -### \
// RUN: %s 2>&1 | FileCheck %s
// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=address -fapple-kext \
// RUN: -### %s 2>&1 | FileCheck %s
// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=address -fapple-kext \
// RUN: -mkernel -### %s 2>&1 | FileCheck %s
// CHECK: "-fsanitize-address-destructor-kind=none"
// Check it's possible to override the driver's decision.
// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=address -fapple-kext \
// RUN: -mkernel -### -fsanitize-address-destructor-kind=global %s 2>&1 | \
// RUN: FileCheck -check-prefix=CHECK-OVERRIDE %s
// CHECK-OVERRIDE: "-fsanitize-address-destructor-kind=global"