[clang-tidy] add -use-color option to clang-tidy-diff.py

[ottojo]

Summary

add -use-color option to enable colored output in clang-tidy-diff.py

Clang-tidy seems to output color only when printing directly to terminal, but an option to force color-output has been added in https://reviews.llvm.org/D79477

[aaron.ballman]

LGTM!

[ottojo]

I can't commit this myself, as i don't have commit access to the repo.

[aaron.ballman]

In D96561#2571193, @ottojo wrote:

I can't commit this myself, as i don't have commit access to the repo.

Thanks for letting me know -- I've commit on your behalf in af06ff1cf87ecd387a65a6f7d4d00e0b06e983fb. Thank you for the patch!

clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py

def main():
   parser.add_argument('-timeout', type=int, default=None,
                       help='timeout per each file in seconds.')
   parser.add_argument('-fix', action='store_true', default=False,
                       help='apply suggested fixes')
   parser.add_argument('-checks',
                       help='checks filter, when not specified, use clang-tidy '
                       'default',
                       default='')
+  parser.add_argument('-use-color', action='store_true',
+                      help='Use colors in output')
   parser.add_argument('-path', dest='build_path',
                       help='Path used to read a compile command database.')
   if yaml:
     parser.add_argument('-export-fixes', metavar='FILE', dest='export_fixes',
                         help='Create a yaml file to store suggested fixes in, '
                         'which can be applied with clang-apply-replacements.')
   parser.add_argument('-extra-arg', dest='extra_arg',
                       action='append', default=[],
def main():
   if args.fix:
     common_clang_tidy_args.append('-fix')
   if args.checks != '':
     common_clang_tidy_args.append('-checks=' + args.checks)
   if args.quiet:
     common_clang_tidy_args.append('-quiet')
   if args.build_path is not None:
     common_clang_tidy_args.append('-p=%s' % args.build_path)
+  if args.use_color:
+    common_clang_tidy_args.append('--use-color')
   for arg in args.extra_arg:
     common_clang_tidy_args.append('-extra-arg=%s' % arg)
   for arg in args.extra_arg_before:
     common_clang_tidy_args.append('-extra-arg-before=%s' % arg)
 
   for name in lines_by_file:
     line_filter_json = json.dumps(
       [{"name": name, "lines": lines_by_file[name]}],