Ignore assume like calls by default in hasAddressTaken()

[rampitec]

ping. Do we need this?

[rampitec]

Ping. It is there for quite a while already, nothing seems to be broken even though it is set to true in call graph builder.

[jdoerfert]

I don't think we ever needed this flag and, TBH, I would remove it entirely.

[rampitec]

In D96179#2693585, @jdoerfert wrote:

I don't think we ever needed this flag and, TBH, I would remove it entirely.

I can remove it instead and do it always.

[madhur13490]

I hope this doesn't run into the issues I observed in D98884. Doing bootstrap builds locally would strengthen testing.

[rampitec]

In D96179#2693666, @madhur13490 wrote:

I hope this doesn't run into the issues I observed in D98884. Doing bootstrap builds locally would strengthen testing.

That's the point. It is effectively default on for a long time already.

[madhur13490]

In D96179#2693680, @rampitec wrote:

In D96179#2693666, @madhur13490 wrote:

I hope this doesn't run into the issues I observed in D98884. Doing bootstrap builds locally would strengthen testing.

That's the point. It is effectively default on for a long time already.

"On" from CG builder but not from *all* places. Not all callers of this function are passing "true" for IgnoreAssumeLikeCalls.

llvm/include/llvm/IR/Function.h

/// @}
   /// hasAddressTaken - returns true if there are any uses of this function
   /// other than direct calls or invokes to it, or blockaddress expressions.
   /// Optionally passes back an offending user for diagnostic purposes,
   /// ignores callback uses, assume like pointer annotation calls, and
   /// references in llvm.used and llvm.compiler.used variables.
   ///
   bool hasAddressTaken(const User ** = nullptr,
                        bool IgnoreCallbackUses = false,
-                       bool IgnoreAssumeLikeCalls = false,
+                       bool IgnoreAssumeLikeCalls = true,
                        bool IngoreLLVMUsed = false) const;
 
   /// isDefTriviallyDead - Return true if it is trivially safe to remove
   /// this function definition from the module (because it isn't externally
   /// visible, does not have its address taken, and has no callers).  To make
   /// this more accurate, call removeDeadConstantUsers first.
   bool isDefTriviallyDead() const;