This is an archive of the discontinued LLVM Phabricator instance.

Move implementation of isAssumeLikeIntrinsic into IntrinsicInst
ClosedPublic

Authored by rampitec on Feb 4 2021, 2:28 PM.

Details

Summary

This is remove dependency on ValueTracking in the future patch.

Diff Detail

Event Timeline

rampitec created this revision.Feb 4 2021, 2:28 PM
rampitec requested review of this revision.Feb 4 2021, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 2:28 PM
Herald added a subscriber: wdng. · View Herald Transcript

Not sure I'm the best person to review this, but I have a couple of drive-by questions.

llvm/include/llvm/IR/IntrinsicInst.h
104

Usually we'd have a default: break; or default: return false; if the switch isn't totally covered... is there a reason you removed it when moving the code?

llvm/lib/Analysis/ValueTracking.cpp
526

Should this FIXME be kept?

rampitec added inline comments.Feb 4 2021, 4:04 PM
llvm/include/llvm/IR/IntrinsicInst.h
104

Will add, thanks!

llvm/lib/Analysis/ValueTracking.cpp
526

I have checked, it is not relevant anymore. The list there is way longer now.

rampitec updated this revision to Diff 321612.Feb 4 2021, 4:30 PM
rampitec marked an inline comment as done.
arsenm accepted this revision.Feb 11 2021, 11:21 AM
This revision is now accepted and ready to land.Feb 11 2021, 11:21 AM