This is an archive of the discontinued LLVM Phabricator instance.

Differential D96069

[flang][msvc] Fix compilation of external-hello-world test with MSVC.
ClosedPublic

Authored by MehdiChinoune on Feb 4 2021, 11:32 AM.

Details

Reviewers
Meinersbur
awarzynski
ChinouneMehdi
Group Reviewers
Restricted Project
Commits
rG0a7d2b5f50a1: [flang][msvc] Fix compilation of external-hello-world test with MSVC.
Summary

MSVC doesn't accept division by zero.

Diff Detail

Event Timeline

ChinouneMehdi created this revision.Feb 4 2021, 11:32 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptFeb 4 2021, 11:32 AM
ChinouneMehdi requested review of this revision.Feb 4 2021, 11:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 11:32 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
ChinouneMehdi retitled this revision from [flang][msvc] Fix compilation of external-hello-world with MSVC. to [flang][msvc] Fix compilation of external-hello-world test with MSVC..Feb 4 2021, 11:33 AM
Meinersbur added a comment.Feb 4 2021, 12:53 PM

Division by zero is undefined behavior. I think this should use ,std::numeric_limits<double>::infinity() and std::numeric_limits<double>::quiet_NaN() (or the C macros INFINITY / NAN)

Harbormaster completed remote builds in B87969: Diff 321529.Feb 4 2021, 2:46 PM
ChinouneMehdi added a reviewer: awarzynski.Feb 4 2021, 8:24 PM
ChinouneMehdi added a comment.Feb 17 2021, 8:26 AM

Ping

Meinersbur added a comment.Feb 17 2021, 8:37 AM

Cold you please make the change I requested?

Meinersbur mentioned this in D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..Apr 3 2021, 2:52 PM
MehdiChinoune commandeered this revision.Apr 4 2021, 7:16 AM
MehdiChinoune updated this revision to Diff 335144.
MehdiChinoune added a reviewer: ChinouneMehdi.
Harbormaster completed remote builds in B97042: Diff 335144.Apr 4 2021, 7:51 AM
MehdiChinoune added a comment.Apr 10 2021, 10:18 PM

Ping

goncharov added a subscriber: goncharov.Apr 12 2021, 7:39 AM
Meinersbur accepted this revision.Apr 13 2021, 11:51 PM

Sorry for the wait. Patch LGTM.

Would you like me to push it top main?

This revision is now accepted and ready to land.Apr 13 2021, 11:51 PM
MehdiChinoune added a comment.Apr 14 2021, 1:25 AM
In D96069#2687939, @Meinersbur wrote:

Sorry for the wait. Patch LGTM.

Would you like me to push it top main?

Yes, of course.
Thanks

Closed by commit rG0a7d2b5f50a1: [flang][msvc] Fix compilation of external-hello-world test with MSVC. (authored by Mehdi Chinoune <chinoune.mehdi@hotmail.com>, committed by Meinersbur). · Explain WhyApr 21 2021, 1:19 PM
This revision was automatically updated to reflect the committed changes.
Meinersbur added a commit: rG0a7d2b5f50a1: [flang][msvc] Fix compilation of external-hello-world test with MSVC..

Revision Contents

PathSize
flang/
unittests/
Runtime/
7 lines

Diff 335144

flang/unittests/Runtime/external-hello.cpp

Context not available.
#include "../../runtime/main.h" #include "../../runtime/main.h"
#include "../../runtime/stop.h" #include "../../runtime/stop.h"
#include <cstring> #include <cstring>
#include <limits>
using namespace Fortran::runtime::io; using namespace Fortran::runtime::io;
Context not available.
IONAME(OutputReal64)(io, 0.0); IONAME(OutputReal64)(io, 0.0);
IONAME(OutputReal64)(io, 2.0 / 3.0); IONAME(OutputReal64)(io, 2.0 / 3.0);
IONAME(OutputReal64)(io, 1.0e99); IONAME(OutputReal64)(io, 1.0e99);
IONAME(OutputReal64)(io, 1.0 / 0.0); IONAME(OutputReal64)(io, std::numeric_limits<double>::infinity());
IONAME(OutputReal64)(io, -1.0 / 0.0); IONAME(OutputReal64)(io, -std::numeric_limits<double>::infinity());
IONAME(OutputReal64)(io, 0.0 / 0.0); IONAME(OutputReal64)(io, std::numeric_limits<double>::quiet_NaN());
IONAME(OutputComplex64)(io, 123.0, -234.0); IONAME(OutputComplex64)(io, 123.0, -234.0);
IONAME(OutputLogical)(io, false); IONAME(OutputLogical)(io, false);
IONAME(OutputLogical)(io, true); IONAME(OutputLogical)(io, true);
Context not available.