Page MenuHomePhabricator

ChinouneMehdi (مهدي شينون (Mehdi Chinoune))
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2020, 12:37 AM (6 w, 6 d)

Recent Activity

Mon, May 11

ChinouneMehdi added a comment to D78356: [flang] Replace ATTRIBUTE_UNUSED with LLVM_ATTRIBUTE_UNUSED..

Ping

Mon, May 11, 10:46 AM · Restricted Project, Unknown Object (Project)

Tue, May 5

ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

@isuruf Could you add /Zc:__cplusplus to MSVC flags with D78306.

Tue, May 5, 6:58 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

I don't think this preserves the intended behavior of the original code -- now MSVC will never check for C++17 mode. I believe the correct way to fix this is to set /Zc:__cplusplus when compiling with MSVC, unless there's a reason that's not possible?

Well, C++17 mode is already checked with CMake, so there is no need to check it with the compiler. I excluded MSVC just because @sscalpone insisted to preserve the original code.

There's a small chance someone could skip CMake entirely and use these files directly (that happens with LLVM support code from time to time, for instance), so I think preserving the behavior of the original code is a reasonable idea. If we set up the CMake to tell MSVC to use the right value for __cplusplus, then the code in idioms.h requires no changes and will do the right thing.

Tue, May 5, 5:20 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

I don't think this preserves the intended behavior of the original code -- now MSVC will never check for C++17 mode. I believe the correct way to fix this is to set /Zc:__cplusplus when compiling with MSVC, unless there's a reason that's not possible?

Tue, May 5, 4:48 AM · Restricted Project, Unknown Object (Project)

Mon, May 4

ChinouneMehdi added a project to D79370: [flang] update tools/f18 to use LLVM_LINK_COMPONENTS.: Unknown Object (Project).
Mon, May 4, 9:02 PM · Unknown Object (Project), Restricted Project

Fri, May 1

ChinouneMehdi updated subscribers of D78356: [flang] Replace ATTRIBUTE_UNUSED with LLVM_ATTRIBUTE_UNUSED..
Fri, May 1, 5:11 PM · Restricted Project, Unknown Object (Project)

Thu, Apr 30

ChinouneMehdi updated the diff for D78186: [flang] Don't check __cplusplus value with MSVC..
Thu, Apr 30, 2:33 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi updated the diff for D78186: [flang] Don't check __cplusplus value with MSVC..

Preserve the original code.

Thu, Apr 30, 2:32 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi updated the diff for D78356: [flang] Replace ATTRIBUTE_UNUSED with LLVM_ATTRIBUTE_UNUSED..

Put llvm/include first.

Thu, Apr 30, 10:08 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a project to D79092: [Flang][Driver]Add new flang driver main() entrypoint: Unknown Object (Project).
Thu, Apr 30, 8:29 AM · Unknown Object (Project), Restricted Project

Apr 29 2020

ChinouneMehdi updated the diff for D78356: [flang] Replace ATTRIBUTE_UNUSED with LLVM_ATTRIBUTE_UNUSED..

Use LLVM_ATTRIBUTE_UNUSED

Apr 29 2020, 10:41 PM · Restricted Project, Unknown Object (Project)

Apr 24 2020

ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

Please, Someone commit this change.
email: chinoune.mehdi@hotmail.com

Apr 24 2020, 11:57 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added projects to D78713: [WIP][mlir][flang] use OpBuilder in <Op>::build methods: Restricted Project, Unknown Object (Project).
Apr 24 2020, 11:57 PM · Unknown Object (Project), Restricted Project, Restricted Project
ChinouneMehdi added a comment to D78356: [flang] Replace ATTRIBUTE_UNUSED with LLVM_ATTRIBUTE_UNUSED..

Please, Someone commit this change.
email: chinoune.mehdi@hotmail.com

Apr 24 2020, 11:25 PM · Restricted Project, Unknown Object (Project)

Apr 21 2020

ChinouneMehdi added a reviewer for D78578: [flang] Fix handling of files without terminating newlines.: Restricted Project.
Apr 21 2020, 9:04 PM · Unknown Object (Project), Restricted Project

Apr 20 2020

ChinouneMehdi abandoned D78185: [flang] Use the equivalent compilation flags with MSVC..

Superseded by D78306

Apr 20 2020, 1:00 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

Do you mean whole Flang or this particular case?

Just this case. I mean, preserve the original code in this change for non-windows systems.

Apr 20 2020, 11:21 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..
Apr 20 2020, 10:49 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

Are you able to wrap the original code in such a way that it doesn't fail under VC++?

Apr 20 2020, 9:43 AM · Restricted Project, Unknown Object (Project)

Apr 19 2020

ChinouneMehdi added a comment to D78215: [flang] Use the Flang cmake-functions to add targets..

flang still can't be build with -DBUILD_SHARED_LIBS=ON, at link time it fails. As of now I see following libraries libFortranDecimal libFortranCommon libFortranLower libLLVMDemangle and libLLVMSupport are getting building fine. I suspect there is some circular dependency between libFortranParser libFortranSemantics and libFortranEvaluate ?
Static build's are fine.

Apr 19 2020, 1:21 PM · Restricted Project, Unknown Object (Project)

Apr 18 2020

ChinouneMehdi updated the summary of D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 18 2020, 1:28 PM · Restricted Project, Unknown Object (Project)

Apr 17 2020

ChinouneMehdi changed the edit policy for D78185: [flang] Use the equivalent compilation flags with MSVC..
Apr 17 2020, 11:53 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi changed the edit policy for D78186: [flang] Don't check __cplusplus value with MSVC..
Apr 17 2020, 11:53 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi abandoned D78354: [flang] Fix FIRSupport dependencies..
Apr 17 2020, 6:59 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78340: [Flang] fix dependency issues after D78215.

I think this change will fix your problem: D78354
Just a question: Have you try to investigate where the problem is before making these changes?

Of course I did. Do you think I just randomly try something to fix it. I find your comment quite offensive, please try to think before asking this kind of question. Your patch for sure doesn't fix my problem with FIRSemantics.

Apr 17 2020, 6:59 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi added inline comments to D78340: [Flang] fix dependency issues after D78215.
Apr 17 2020, 6:27 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi added a comment to D78340: [Flang] fix dependency issues after D78215.
Apr 17 2020, 6:27 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi added a project to D78340: [Flang] fix dependency issues after D78215: Unknown Object (Project).
Apr 17 2020, 4:50 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi added inline comments to D78340: [Flang] fix dependency issues after D78215.
Apr 17 2020, 4:49 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi created D78356: [flang] Replace ATTRIBUTE_UNUSED with LLVM_ATTRIBUTE_UNUSED..
Apr 17 2020, 3:45 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi changed the edit policy for D78354: [flang] Fix FIRSupport dependencies..
Apr 17 2020, 3:45 AM · Restricted Project, Unknown Object (Project)

Apr 16 2020

ChinouneMehdi added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 11:41 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi added a project to D78306: [flang] Use LLVM's flags: Unknown Object (Project).
Apr 16 2020, 10:02 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi closed D78215: [flang] Use the Flang cmake-functions to add targets..

@DavidTruby
Thanks!

Apr 16 2020, 8:21 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78215: [flang] Use the Flang cmake-functions to add targets..

@ChinouneMehdi this looks good to me and I can commit it for you, could you let me know what email address you want used?
Thanks!

Apr 16 2020, 7:16 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi updated the diff for D78185: [flang] Use the equivalent compilation flags with MSVC..
Apr 16 2020, 4:30 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78215: [flang] Use the Flang cmake-functions to add targets..

I don't have commit access.
Please, Someone who has commit access commit these changes.

Apr 16 2020, 12:47 AM · Restricted Project, Unknown Object (Project)

Apr 15 2020

ChinouneMehdi added inline comments to D78215: [flang] Use the Flang cmake-functions to add targets..
Apr 15 2020, 7:52 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi changed the visibility for D78185: [flang] Use the equivalent compilation flags with MSVC..
Apr 15 2020, 2:19 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi changed the visibility for D78186: [flang] Don't check __cplusplus value with MSVC..
Apr 15 2020, 2:19 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi changed the visibility for D78215: [flang] Use the Flang cmake-functions to add targets..
Apr 15 2020, 12:36 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

What is the motivation for this change?

To make it compile with MSVC.

Apr 15 2020, 12:36 PM · Restricted Project, Unknown Object (Project)
ChinouneMehdi changed the visibility for D78215: [flang] Use the Flang cmake-functions to add targets..
Apr 15 2020, 9:16 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a project to rG29e71ceaee1a: [flang] Add return statement to Logical opeator=.: Unknown Object (Project).
Apr 15 2020, 5:59 AM · Unknown Object (Project)
ChinouneMehdi added a comment to D78185: [flang] Use the equivalent compilation flags with MSVC..

Using https://github.com/flang-compiler/f18/pull/1095/files should add -fno-rtti and -fno-exceptions automatically on unix and add the equivalent flags on windows as well.

Apr 15 2020, 5:59 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi added a project to D77812: [flang] Semantic checks for OpenMP combined constructs.: Unknown Object (Project).
Apr 15 2020, 5:59 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi added a project to D78008: [flang] Added Semantic Checks for 5 Data Constraints: Unknown Object (Project).
Apr 15 2020, 5:59 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi added a project to D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative: Unknown Object (Project).
Apr 15 2020, 5:59 AM · Unknown Object (Project), Restricted Project
ChinouneMehdi created D78186: [flang] Don't check __cplusplus value with MSVC..
Apr 15 2020, 2:41 AM · Restricted Project, Unknown Object (Project)
ChinouneMehdi created D78185: [flang] Use the equivalent compilation flags with MSVC..
Apr 15 2020, 2:41 AM · Restricted Project, Unknown Object (Project)