Page MenuHomePhabricator

goncharov (Mikhail Goncharov)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 22 2019, 5:54 AM (127 w, 2 d)
Roles
Administrator

Recent Activity

Wed, Jul 28

goncharov updated the diff for D106955: brake build to test pre-merge.

.

Wed, Jul 28, 7:26 AM · Restricted Project
goncharov updated subscribers of D106955: brake build to test pre-merge.
Wed, Jul 28, 7:12 AM · Restricted Project
goncharov requested review of D106955: brake build to test pre-merge.
Wed, Jul 28, 7:12 AM · Restricted Project

Jun 4 2021

goncharov committed rGb109172d993e: [clang] use a different name for generated test cdb (authored by goncharov).
[clang] use a different name for generated test cdb
Jun 4 2021, 9:14 AM

May 31 2021

goncharov added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Sorry, had to revert it as this fails under sanitizer : https://lab.llvm.org/buildbot/#/builders/5/builds/8150

May 31 2021, 6:36 AM · Restricted Project
goncharov added a reverting change for rG818338add774: [clang] Add support for the "abstract" contextual keyword of MSVC: rGc36ff6424f24: Revert "[clang] Add support for the "abstract" contextual keyword of MSVC".
May 31 2021, 6:35 AM
goncharov committed rGc36ff6424f24: Revert "[clang] Add support for the "abstract" contextual keyword of MSVC" (authored by goncharov).
Revert "[clang] Add support for the "abstract" contextual keyword of MSVC"
May 31 2021, 6:35 AM
goncharov added a reverting change for D102517: [clang] Add support for the "abstract" contextual keyword of MSVC: rGc36ff6424f24: Revert "[clang] Add support for the "abstract" contextual keyword of MSVC".
May 31 2021, 6:34 AM · Restricted Project
goncharov committed rG8006ac7fe449: fix test for symlinked clang c1ee4fb5af49a (authored by goncharov).
fix test for symlinked clang c1ee4fb5af49a
May 31 2021, 4:31 AM

Apr 21 2021

goncharov accepted D100936: [doc] added documentation for pre-merge testing.
Apr 21 2021, 3:27 AM · Restricted Project
goncharov added a comment to D100936: [doc] added documentation for pre-merge testing.

Thank you, Christian!

Apr 21 2021, 3:27 AM · Restricted Project

Mar 24 2021

goncharov added a comment to D99093: [libcxx] [ci] Add a Windows CI buildkite configuration.

That's a lot of failed tests reported. If you want to add this step before fixing all tests I would probably need to modify test result processing to ignore all from the jobs that are "soft failed". Otherwise every review author will see them. WDYT?

Mar 24 2021, 2:11 AM · Restricted Project

Mar 19 2021

goncharov accepted D98858: [lit] Pass the USERPROFILE variable through on Windows.
Mar 19 2021, 12:37 AM · Restricted Project

Feb 23 2021

goncharov added a comment to D96773: [VPlan] Manage pairs of incoming (VPValue, VPBB) in VPWidenPHIRecipe..

Hi @fhahn , build is still failing with sanitizers: http://lab.llvm.org:8011/#/builders/5, e.g. http://lab.llvm.org:8011/#/builders/5/builds/4885

Feb 23 2021, 8:46 AM · Restricted Project

Feb 22 2021

goncharov added a comment to D96665: Revert "Implement nullPointerConstant() using a better API.".

I have relanded this in https://github.com/llvm/llvm-project/commit/3b148d6f991181a1b8f089c4bc2126e1a6c1212d . My apologies

Feb 22 2021, 5:38 AM · Restricted Project
goncharov added a reverting change for rGba1d9546ee38: Revert "Revert "Implement nullPointerConstant() using a better API."": rG3b148d6f9911: Revert "Revert "Revert "Implement nullPointerConstant() using a better API.""".
Feb 22 2021, 5:37 AM
goncharov committed rG3b148d6f9911: Revert "Revert "Revert "Implement nullPointerConstant() using a better API.""" (authored by goncharov).
Revert "Revert "Revert "Implement nullPointerConstant() using a better API."""
Feb 22 2021, 5:37 AM
goncharov added a comment to D96665: Revert "Implement nullPointerConstant() using a better API.".

Hi @steveire! Sorry but I reverted this revert. Could you please give some context of "discussed elsewhere" and "pre-existing unit test for the matcher"? @aaron.ballman for cc

Feb 22 2021, 4:46 AM · Restricted Project
goncharov committed rGba1d9546ee38: Revert "Revert "Implement nullPointerConstant() using a better API."" (authored by goncharov).
Revert "Revert "Implement nullPointerConstant() using a better API.""
Feb 22 2021, 4:44 AM
goncharov added a reverting change for rG6984e0d43985: Revert "Implement nullPointerConstant() using a better API.": rGba1d9546ee38: Revert "Revert "Implement nullPointerConstant() using a better API."".
Feb 22 2021, 4:44 AM
goncharov added a reverting change for D96665: Revert "Implement nullPointerConstant() using a better API.": rGba1d9546ee38: Revert "Revert "Implement nullPointerConstant() using a better API."".
Feb 22 2021, 4:44 AM · Restricted Project
goncharov added inline comments to D96202: [lldb/test] Automatically find debug servers to test.
Feb 22 2021, 2:57 AM · Restricted Project

Nov 26 2020

goncharov added a comment to D90068: [libc++] Perform libc++ CI directly in the pipeline instead of triggering our own pipeline.

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Gentle ping.

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Yes, that should be possible. Will add a link soon! Sorry for the late reply

Nov 26 2020, 12:03 AM · Restricted Project

Nov 23 2020

goncharov added a comment to D90228: [libcxx] Don't truncate intermediates to wchar_t when widening.

CI doesn't trigger a second time -- maybe it's because the diff hasn't changed, or because the revision was accepted. @goncharov Do you know?

Nov 23 2020, 8:38 AM · Restricted Project
goncharov abandoned D90673: yet another commit.
Nov 23 2020, 8:22 AM · Restricted Project
goncharov abandoned D90618: chained diff.
Nov 23 2020, 8:22 AM · Restricted Project
goncharov added a comment to D90068: [libc++] Perform libc++ CI directly in the pipeline instead of triggering our own pipeline.

If you think it's possible to keep the libcxx-ci in a separate pipeline, do you think it would be possible to have the link here point to the libcxx-ci pipeline directly?

Gentle ping.

Nov 23 2020, 8:21 AM · Restricted Project
goncharov abandoned D90389: Test commit, please ignore.
Nov 23 2020, 8:19 AM · Restricted Project

Nov 20 2020

goncharov added a reverting change for rGf8284d21a8e2: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers): rG0caa82e2ac53: Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)".
Nov 20 2020, 4:13 AM
goncharov added a reverting change for rG0c59f51592ef: [mlir][Linalg] NFC: Expose some utility functions used for promotion.: rG0caa82e2ac53: Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)".
Nov 20 2020, 4:13 AM
goncharov added a reverting change for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers): rG0caa82e2ac53: Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)".
Nov 20 2020, 4:13 AM · Restricted Project
goncharov committed rG0caa82e2ac53: Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)" (authored by goncharov).
Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)"
Nov 20 2020, 4:13 AM
goncharov added a reverting change for D91838: Remove unused isZero function: rG0caa82e2ac53: Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)".
Nov 20 2020, 4:13 AM · Restricted Project
goncharov added a reverting change for D91503: [mlir][Linalg] Expose some utility functions used for promotion.: rG0caa82e2ac53: Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)".
Nov 20 2020, 4:13 AM · Restricted Project
goncharov added a reverting change for rG0f9f0a4046e1: Remove unused isZero function: rG0caa82e2ac53: Revert "[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)".
Nov 20 2020, 4:13 AM

Nov 19 2020

goncharov added a reverting change for rG40267cc989e6: [libc++] ADL-proof <vector> by adding _VSTD:: qualification on calls.: rG620adacf87a3: Revert "[libc++] ADL-proof <vector> by adding _VSTD:: qualification on calls.".
Nov 19 2020, 6:38 AM
goncharov added a reverting change for D91708: [libc++] ADL-proof <vector> by adding _VSTD:: qualification on calls.: rG620adacf87a3: Revert "[libc++] ADL-proof <vector> by adding _VSTD:: qualification on calls.".
Nov 19 2020, 6:38 AM · Restricted Project
goncharov committed rG620adacf87a3: Revert "[libc++] ADL-proof <vector> by adding _VSTD:: qualification on calls." (authored by goncharov).
Revert "[libc++] ADL-proof <vector> by adding _VSTD:: qualification on calls."
Nov 19 2020, 6:38 AM
goncharov added a reverting change for rGc43abf043692: [lldb] Use translated full ftag values: rG193a9b374e24: Revert "[lldb] Use translated full ftag values".
Nov 19 2020, 6:25 AM
goncharov committed rG193a9b374e24: Revert "[lldb] Use translated full ftag values" (authored by goncharov).
Revert "[lldb] Use translated full ftag values"
Nov 19 2020, 6:25 AM
goncharov added a reverting change for D91504: [lldb] Use translated full ftag values: rG193a9b374e24: Revert "[lldb] Use translated full ftag values".
Nov 19 2020, 6:25 AM · Restricted Project
goncharov added a comment to D91504: [lldb] Use translated full ftag values.

Hi @mgorny! http://lab.llvm.org:8011/#/builders/68/builds/2298 build failed. Could you please fix the test?

Nov 19 2020, 6:13 AM · Restricted Project

Nov 18 2020

goncharov added a comment to D90930: [lib/Support/YAMLTraits] - Don't print leading zeroes when dumping Hex8/Hex16/Hex32 types..

@grimar this one slipped through https://github.com/llvm/llvm-project/commit/8c1e3cbebfe9ff14829a279b9d229d4fc3f190b1

Nov 18 2020, 8:24 AM · Restricted Project
goncharov committed rG8c1e3cbebfe9: [llvm] fix global_downgraded_to_static test (authored by goncharov).
[llvm] fix global_downgraded_to_static test
Nov 18 2020, 8:22 AM
goncharov committed rGf45c052c9e62: Fix unused variables in release build (authored by goncharov).
Fix unused variables in release build
Nov 18 2020, 6:19 AM
goncharov closed D91705: Fix unused variables in release build.
Nov 18 2020, 6:18 AM · Restricted Project
goncharov requested review of D91705: Fix unused variables in release build.
Nov 18 2020, 6:11 AM · Restricted Project

Nov 16 2020

goncharov committed rG47c17bcd0e8e: [lld] Use %t file in test (authored by goncharov).
[lld] Use %t file in test
Nov 16 2020, 1:50 AM
goncharov closed D91521: [lld] Use %t file in test.
Nov 16 2020, 1:49 AM · Restricted Project
goncharov updated the diff for D91521: [lld] Use %t file in test.

reword

Nov 16 2020, 1:42 AM · Restricted Project
goncharov updated the summary of D91521: [lld] Use %t file in test.
Nov 16 2020, 1:39 AM · Restricted Project
goncharov added a reviewer for D91521: [lld] Use %t file in test: sbc100.
Nov 16 2020, 1:39 AM · Restricted Project
goncharov requested review of D91521: [lld] Use %t file in test.
Nov 16 2020, 1:38 AM · Restricted Project

Nov 3 2020

goncharov removed a project from D90673: yet another commit: Restricted Project.
Nov 3 2020, 2:02 AM · Restricted Project
goncharov requested review of D90673: yet another commit.
Nov 3 2020, 2:02 AM · Restricted Project

Nov 2 2020

goncharov removed a project from D90618: chained diff: Restricted Project.
Nov 2 2020, 8:00 AM · Restricted Project
goncharov requested review of D90618: chained diff.
Nov 2 2020, 7:59 AM · Restricted Project

Oct 29 2020

goncharov updated the diff for D90389: Test commit, please ignore.

tres

Oct 29 2020, 8:10 AM · Restricted Project
goncharov updated the diff for D90389: Test commit, please ignore.

second

Oct 29 2020, 8:04 AM · Restricted Project
goncharov removed a project from D90389: Test commit, please ignore: Restricted Project.
Oct 29 2020, 6:17 AM · Restricted Project
goncharov requested review of D90389: Test commit, please ignore.
Oct 29 2020, 6:17 AM · Restricted Project
goncharov abandoned D88560: Testing CI for libcxxdo not submit.
Oct 29 2020, 3:40 AM · Restricted Project
goncharov added a comment to D90068: [libc++] Perform libc++ CI directly in the pipeline instead of triggering our own pipeline.

As we've discussed before, I would prefer to keep the libc++ CI pipeline separate since it provides a nicer view of everything that has run recently for libc++, without being cluttered by other projects. We're losing this here, but we're gaining proper reporting in Phabricator reviews, which I think is more important.

However, another way we could perhaps achieve proper reporting is if we moved the reporting step that's currently run in the premerge-checks pipeline into the libcxx-ci pipeline. Would that work? I assume the reporting step isn't strongly tied to the premerge-checks pipeline?

Oct 29 2020, 3:39 AM · Restricted Project

Oct 27 2020

goncharov updated subscribers of D88560: Testing CI for libcxxdo not submit.

I think this can be dropped to clean up the libc++ review queue.

Oct 27 2020, 1:43 AM · Restricted Project
goncharov removed a reviewer for D88560: Testing CI for libcxxdo not submit: Restricted Project.
Oct 27 2020, 1:42 AM · Restricted Project

Oct 22 2020

goncharov committed rG40f360c2e90b: [libc++] Update continous integration scripts (authored by goncharov).
[libc++] Update continous integration scripts
Oct 22 2020, 2:00 AM
goncharov closed D89113: Update libc++ CI scripts to use updated pipeline logic.
Oct 22 2020, 2:00 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

updated commit wording, rebased

Oct 22 2020, 1:55 AM · Restricted Project

Oct 21 2020

goncharov added a comment to D89113: Update libc++ CI scripts to use updated pipeline logic.

IIUC, I can now disable my own libcxx-trigger pipeline, correct?

Oct 21 2020, 1:42 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

update "generic-no-random_device" step in yaml

Oct 21 2020, 1:40 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

rebased on master

Oct 21 2020, 1:38 AM · Restricted Project

Oct 13 2020

goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

Make build message similar to "buildkite-pipeline-trigger.sh"

Oct 13 2020, 10:47 AM · Restricted Project

Oct 12 2020

goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

ditto

Oct 12 2020, 2:09 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

Trigger a pipeline instead of appending steps

Oct 12 2020, 2:04 AM · Restricted Project

Oct 9 2020

goncharov updated the summary of D89113: Update libc++ CI scripts to use updated pipeline logic.
Oct 9 2020, 7:08 AM · Restricted Project
goncharov added a reviewer for D89113: Update libc++ CI scripts to use updated pipeline logic: ldionne.
Oct 9 2020, 4:34 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

revert test, add artifacts params to every step

Oct 9 2020, 4:26 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

update yml

Oct 9 2020, 3:38 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

fix script DIR resolution

Oct 9 2020, 3:31 AM · Restricted Project
goncharov updated the diff for D89113: Update libc++ CI scripts to use updated pipeline logic.

capture artifacts

Oct 9 2020, 3:26 AM · Restricted Project
goncharov requested review of D89113: Update libc++ CI scripts to use updated pipeline logic.
Oct 9 2020, 3:24 AM · Restricted Project

Sep 30 2020

goncharov retitled D88560: Testing CI for libcxxdo not submit from Testing CI for libcxx do not submit to Testing CI for libcxxdo not submit.
Sep 30 2020, 5:21 AM · Restricted Project
goncharov requested review of D88560: Testing CI for libcxxdo not submit.
Sep 30 2020, 5:21 AM · Restricted Project

Sep 17 2020

goncharov added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.
Sep 17 2020, 12:52 AM · Restricted Project

Jul 6 2020

goncharov added a reverting change for rG2c16100e6f72: [ScalarEvolution] createSCEV(): recognize `udiv`/`urem` disguised as an…: D83230: Revert "[ScalarEvolution] createSCEV(): recognize `udiv`/`urem` disguised as an `sdiv`/`srem`".
Jul 6 2020, 7:27 AM
Herald added a project to D83230: Revert "[ScalarEvolution] createSCEV(): recognize `udiv`/`urem` disguised as an `sdiv`/`srem`": Restricted Project.
Jul 6 2020, 7:27 AM · Restricted Project

Jun 23 2020

goncharov added a comment to D81408: [builtins] Improve compatibility with 16 bit targets.

@goncharov

Meanwhile, looking at the latest Buildkite build for this review, we have:

artifacts/CMakeCache.txt (Linux)
...
LLVM_ENABLE_PROJECTS:STRING=clang;compiler-rt;llvm
...

and

artifacts/CMakeCache.txt (Windows)
...
LLVM_ENABLE_PROJECTS:STRING=clang;llvm
...

So, isn't Windows build here just wasting CPU time?

Jun 23 2020, 1:00 AM · Restricted Project

Jun 4 2020

goncharov abandoned D71594: testing clang-tidy.
Jun 4 2020, 1:02 AM · Restricted Project, Restricted Project
goncharov abandoned D73265: header file warning.
Jun 4 2020, 1:02 AM · Restricted Project
goncharov abandoned D71661: I broke clangd.
Jun 4 2020, 1:02 AM · Restricted Project
goncharov abandoned D80509: buildkite test 2.
Jun 4 2020, 1:02 AM · Restricted Project
goncharov abandoned D79412: buildkite test.
Jun 4 2020, 1:02 AM · Restricted Project
goncharov abandoned D81086: buildkite is open for beta.
Jun 4 2020, 1:02 AM · Restricted Project
goncharov abandoned D71197: llvm premerge: clang format test.
Jun 4 2020, 1:02 AM · Restricted Project

Jun 3 2020

goncharov created D81086: buildkite is open for beta.
Jun 3 2020, 5:27 AM · Restricted Project
goncharov updated subscribers of D81086: buildkite is open for beta.
Jun 3 2020, 5:27 AM · Restricted Project

Jun 2 2020

goncharov updated the diff for D80509: buildkite test 2.

update

Jun 2 2020, 6:36 AM · Restricted Project

May 25 2020

goncharov updated subscribers of D80509: buildkite test 2.
May 25 2020, 2:38 AM · Restricted Project
goncharov created D80509: buildkite test 2.
May 25 2020, 2:38 AM · Restricted Project

May 20 2020

goncharov updated the diff for D79412: buildkite test.

2

May 20 2020, 8:10 AM · Restricted Project