Page MenuHomePhabricator

[flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect
ClosedPublic

Authored by SouraVX on Feb 3 2021, 6:34 AM.

Diff Detail

Event Timeline

SouraVX created this revision.Feb 3 2021, 6:34 AM
SouraVX requested review of this revision.Feb 3 2021, 6:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2021, 6:34 AM

Built and tested locally.

schweitz added a comment.EditedFeb 3 2021, 8:12 AM

Built and tested locally.

I think the fir-ops.fir test might need to be updated. (Actually, it looks like that part was already upstreamed.)

Thanks for the renaming merge!

Built and tested locally.

I think the fir-ops.fir test might need to be updated.

Thanks for the renaming merge!

I noticed following snippet in fir-ops.fir, Suggesting some changes are already there ?

// CHECK-LABEL: func @loop() {
func @loop() {
...

// CHECK: fir.do_loop [[VAL_65:%.*]] = [[VAL_62]] to [[VAL_63]] step [[VAL_62]] {
...
    }
  }
  fir.unreachable
}
schweitz accepted this revision.Feb 3 2021, 9:24 AM
This revision is now accepted and ready to land.Feb 3 2021, 9:24 AM
SouraVX added a comment.EditedFeb 3 2021, 9:25 AM

@schweitz, fir-ops.fir is marked as Unsupported. Seems like tco is not ready ?

// RUN: tco -emit-fir %s | tco -emit-fir | FileCheck %s
// UNSUPPORTED: !fir

Enabled tests for this in: https://reviews.llvm.org/D95958
Builds clean.
@mehdi_amini Apologies, I totally forgot and landed without your approval :(, if you have any concerns please share I'll try to address as a post commit thing or if you want I can revert it.