Page MenuHomePhabricator

AMDGPU/LLD: Add target id and code object v4 support to linker
ClosedPublic

Authored by kzhuravl on Feb 1 2021, 12:21 PM.

Diff Detail

Event Timeline

kzhuravl created this revision.Feb 1 2021, 12:21 PM
kzhuravl requested review of this revision.Feb 1 2021, 12:21 PM
MaskRay added inline comments.Feb 1 2021, 12:39 PM
lld/ELF/Arch/AMDGPU.cpp
78

(retXnack == EF_AMDGPU_FEATURE_XNACK_UNSUPPORTED_V4) =>
retXnack == EF_AMDGPU_FEATURE_XNACK_UNSUPPORTED_V4

ditto for tothers

109

D71101: objectFiles can be empty

kzhuravl updated this revision to Diff 320583.Feb 1 2021, 1:38 PM
kzhuravl marked an inline comment as done.

Address review feedback.

lld/ELF/Arch/AMDGPU.cpp
109

But thats only if emulation is supported? And amdgpu emulation is not supported. Otherwise, how will lld determine its an amdgpu arch with objectFiles being empty?

I can change it to

if (objectFiles.empty())
  return 0;

But I wont be able to add a test without adding emulation support for amdgpu.

tra added a subscriber: tra.Feb 1 2021, 2:07 PM
MaskRay accepted this revision.Feb 10 2021, 5:16 PM

Looks great!

This revision is now accepted and ready to land.Feb 10 2021, 5:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 10:41 AM