Page MenuHomePhabricator

[mlir][Linalg] Replace SimplePad with PadTensor in hoist-padding
ClosedPublic

Authored by hanchung on Feb 1 2021, 7:32 AM.

Details

Summary

This is the last revision to migrate using SimplePadOp to PadTensorOp, and the
SimplePadOp is removed in the patch. Update a bit in SliceAnalysis because the
PadTensorOp takes a region different from SimplePadOp. This is not covered by
LinalgOp because it is not a structured op.

Also, remove a duplicated comment from cpp file, which is already described in a
header file. And update the pseudo-mlir in the comment.

This is as same as D95615 but fixing one dep in CMakeLists.txt

Different from D95671, the fix was applied to run target.

Diff Detail

Event Timeline

hanchung created this revision.Feb 1 2021, 7:32 AM
hanchung requested review of this revision.Feb 1 2021, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2021, 7:32 AM

It was failed in post-submit buildbot check (in flang-aarch64-ubuntu-clang and mlir-nvidia). I could repro the failure with the same config in flang-aarch64-ubuntu-clang, and checked it locally. It's passing now. The errors in flang-aarch64-ubuntu-clang and mlir-nvidia are the same. I didn't test the config in mlir-nvidia yet because there are some issues in cmake configuration on my machine.

If you strongly feel that I should also test the config in mlir-nvidia, I will try to make it happy. (but it takes times)

hanchung added a comment.EditedFeb 1 2021, 7:35 AM

It was failed in post-submit buildbot check (in flang-aarch64-ubuntu-clang and mlir-nvidia). I could repro the failure with the same config in flang-aarch64-ubuntu-clang, and checked it locally. It's passing now. The errors in flang-aarch64-ubuntu-clang and mlir-nvidia are the same. I didn't test the config in mlir-nvidia yet because there are some issues in cmake configuration on my machine.

If you strongly feel that I should also test the config in mlir-nvidia, I will try to make it happy. (but it takes times)

The buildbot failures were:
http://lab.llvm.org:8011/#/builders/33/builds/2257
http://lab.llvm.org:8011/#/builders/61/builds/4767

mravishankar accepted this revision.Feb 1 2021, 11:37 AM
This revision is now accepted and ready to land.Feb 1 2021, 11:37 AM