Page MenuHomePhabricator

[mlir][Linalg] Replace SimplePad with PadTensor in hoist-padding
ClosedPublic

Authored by hanchung on Jan 29 2021, 12:35 AM.

Details

Summary

This is the last revision to migrate using SimplePadOp to PadTensorOp, and the
SimplePadOp is removed in the patch. Update a bit in SliceAnalysis because the
PadTensorOp takes a region different from SimplePadOp. This is not covered by
LinalgOp because it is not a structured op.

Also, remove a duplicated comment from cpp file, which is already described in a
header file. And update the pseudo-mlir in the comment.

Diff Detail

Event Timeline

hanchung created this revision.Jan 29 2021, 12:35 AM
hanchung requested review of this revision.Jan 29 2021, 12:35 AM

This is as same as D95615 but fixing one dep in CMakeLists.txt. I couldn't repro the issue on local side, so would wait until the builds pass in remote lab.

nicolasvasilache accepted this revision.Jan 29 2021, 5:30 AM
This revision is now accepted and ready to land.Jan 29 2021, 5:30 AM