This was suggested in https://reviews.llvm.org/D87657 as a better
alternative which doesn't require having to guess separators.
Details
Details
- Reviewers
dblaikie jhenderson
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Does this address @rnk's feedback about symlinks? ( https://reviews.llvm.org/D87657#2296028 )
Comment Actions
It doesn't, I think if we want to handle that case, we'd need to use sys::fs::real_path rather than sys::path::remove_dots. That should produce correct result but it's more expensive.
While working on coverage mapping, I've noticed that we already use sys::path::remove_dots with remove_dots_dots=true to normalize filenames there. Whichever way we decide on, I think it'd be useful to unify the two.