This is an archive of the discontinued LLVM Phabricator instance.

Differential D95627

[OpenMP] libomp: fix Windows build by vs2019
ClosedPublic

Authored by AndreyChurbanov on Jan 28 2021, 8:46 AM.

Download Raw Diff

Details

Reviewers

Nawrin
hbae
jlpeyton
jdoerfert

Commits

rG7f5ad0e07162: [OpenMP] libomp: fix build by cl with vs2019

Summary

This is a fix for https://bugs.llvm.org/show_bug.cgi?id=48919.
VLA replaced with alloca.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

AndreyChurbanov created this revision.Jan 28 2021, 8:46 AM

Herald added subscribers: guansong, yaxunl. · View Herald TranscriptJan 28 2021, 8:46 AM

AndreyChurbanov requested review of this revision.Jan 28 2021, 8:46 AM

Herald added a reviewer: jdoerfert. · View Herald TranscriptJan 28 2021, 8:46 AM

Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript

ABataev added a subscriber: ABataev.Jan 28 2021, 8:49 AM

ABataev added inline comments.

openmp/runtime/src/kmp_settings.cpp
3381	Mem leak without free

AndreyChurbanov added inline comments.Jan 28 2021, 8:56 AM

openmp/runtime/src/kmp_settings.cpp
3381	The memory allocated with alloca is automatically feed, as it is just a stack.

Harbormaster completed remote builds in B87043: Diff 319884.Jan 28 2021, 10:09 AM

Looks good to me.

This revision is now accepted and ready to land.Jan 28 2021, 5:11 PM

This revision was landed with ongoing or failed builds.Jan 29 2021, 2:17 AM

Closed by commit rG7f5ad0e07162: [OpenMP] libomp: fix build by cl with vs2019 (authored by AndreyChurbanov). · Explain Why

This revision was automatically updated to reflect the committed changes.

AndreyChurbanov added a commit: rG7f5ad0e07162: [OpenMP] libomp: fix build by cl with vs2019.

Revision Contents

Path

Size

openmp/

runtime/

src/

kmp_settings.cpp

3 lines

Diff 320082

openmp/runtime/src/kmp_settings.cpp

	Show First 20 Lines • Show All 3,371 Lines • ▼ Show 20 Lines		static void __kmp_stg_parse_allocator(char const name, char const value,
	// Count the number of traits in the env var string			// Count the number of traits in the env var string
	if (delim) {			if (delim) {
	ntraits = 1;			ntraits = 1;
	for (scan = buf; *scan != '\0'; scan++) {			for (scan = buf; *scan != '\0'; scan++) {
	if (*scan == ',')			if (*scan == ',')
	ntraits++;			ntraits++;
	}			}
	}			}
	omp_alloctrait_t traits[ntraits];			omp_alloctrait_t *traits =
				(omp_alloctrait_t )KMP_ALLOCA(ntraits sizeof(omp_alloctrait_t));
				ABataevUnsubmitted Not Done Reply Inline Actions Mem leak without free ABataev: Mem leak without free
				AndreyChurbanovAuthorUnsubmitted Done Reply Inline Actions The memory allocated with alloca is automatically feed, as it is just a stack. AndreyChurbanov: The memory allocated with alloca is automatically feed, as it is just a stack.

	// Helper macros			// Helper macros
	#define IS_POWER_OF_TWO(n) (((n) & ((n)-1)) == 0)			#define IS_POWER_OF_TWO(n) (((n) & ((n)-1)) == 0)

	#define GET_NEXT(sentinel) \			#define GET_NEXT(sentinel) \
	{ \			{ \
	SKIP_WS(next); \			SKIP_WS(next); \
	if (*next == sentinel) \			if (*next == sentinel) \
	▲ Show 20 Lines • Show All 2,736 Lines • Show Last 20 Lines