This is an archive of the discontinued LLVM Phabricator instance.

[mlir][NFC] Add missing include guards to MlirOptMain.h
ClosedPublic

Authored by vinograd47 on Jan 27 2021, 7:57 AM.

Diff Detail

Event Timeline

vinograd47 created this revision.Jan 27 2021, 7:57 AM
vinograd47 requested review of this revision.Jan 27 2021, 7:57 AM

I think we are using _ for / int the pass, but not to separate words, so we'll have MLIR_SUPPORT_MLIROPTMAIN_H even if it doesn't read nicely.

mehdi_amini accepted this revision.Jan 27 2021, 1:55 PM

LG with fixing the wording as Alex suggests (and clang-tidy flags)

This revision is now accepted and ready to land.Jan 27 2021, 1:55 PM

Fixed include guard macro name to match preferred style.
Rebased on latest main branch.

@mehdi_amini I don't have commit access to the repo. Could you please land the change by yourself?

This revision was automatically updated to reflect the committed changes.