This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Return new Operation from `Rewriter::replaceOpWithNewOp`
ClosedPublic

Authored by vinograd47 on Jan 27 2021, 7:02 AM.

Details

Summary

It will allow to perform additional manipulation with the newly created Operation.
For example, custom attributes propagation/changes.

Diff Detail

Event Timeline

vinograd47 created this revision.Jan 27 2021, 7:02 AM
vinograd47 requested review of this revision.Jan 27 2021, 7:02 AM
ftynse accepted this revision.Jan 27 2021, 8:19 AM

This has been bothering be for some time, thanks!

This revision is now accepted and ready to land.Jan 27 2021, 8:19 AM

Rebased to latest main branch.

@ftynse I don't have commit access to the repo. Could you please land the change by yourself?