Unfortunately this treats overrides declarations as declarations, not as
references. I don't plan to land this until I have a fix for that issue.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D95450
[clangd] Respect ReferencesParams.context.includeDeclarations ClosedPublic Authored by sammccall on Jan 26 2021, 8:30 AM.
Details Summary Unfortunately this treats overrides declarations as declarations, not as
Diff Detail
Event TimelineHerald added subscribers: usaxena95, kadircet, arphaman. · View Herald TranscriptJan 26 2021, 8:30 AM This revision is now accepted and ready to land.Jan 29 2021, 4:11 AM This revision was landed with ongoing or failed builds.Feb 1 2021, 8:07 AM Closed by commit rGff4832dbff0c: [clangd] Respect ReferencesParams.context.includeDeclarations (authored by sammccall). · Explain Why This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done.
Revision Contents
Diff 320472 clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/Protocol.h
clang-tools-extra/clangd/Protocol.cpp
clang-tools-extra/clangd/XRefs.h
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/clangd/test/references.test
clang-tools-extra/clangd/unittests/PreambleTests.cpp
clang-tools-extra/clangd/unittests/XRefsTests.cpp
|
nit: are these two needed? I can't see any usages of symbols defined there.