[clangd] NFC Silence some buildbot warnings

[njames93]

Summary

clang-tools-extra/clangd/unittests/FindTargetTests.cpp:343:29: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
clang-tools-extra/clangd/unittests/FindTargetTests.cpp:947:35: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
clang-tools-extra/clangd/unittests/SelectionTests.cpp:646:17: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]

clang-tools-extra/clangd/unittests/FindTargetTests.cpp

 // It takes the expected decls as varargs to work around comma-in-macro issues.
 #define EXPECT_DECLS(NodeType, ...)                                            \
   EXPECT_THAT(assertNodeAndPrintDecls(NodeType),                               \
               ::testing::UnorderedElementsAreArray(                            \
                   std::vector<PrintedDecl>({__VA_ARGS__})))                    \
       << Code
 using ExpectedDecls = std::vector<PrintedDecl>;
 
+#define EXPECT_NO_DECLS(NodeType)                                              \
+  EXPECT_THAT(assertNodeAndPrintDecls(NodeType), ::testing::IsEmpty()) << Code
+
 TEST_F(TargetDeclTest, Exprs) {
   Code = R"cpp(
     int f();
     int x = [[f]]();
   )cpp";
   EXPECT_DECLS("DeclRefExpr", "int f()");
 
   Code = R"cpp(
TEST_F(TargetDeclTest, Types) {
   )cpp";
   EXPECT_DECLS("DecltypeTypeLoc", {"struct S", Rel::Underlying});
 
   Code = R"cpp(
     struct S{};
     [[auto]] X = S{};
   )cpp";
   // FIXME: deduced type missing in AST. https://llvm.org/PR42914
-  EXPECT_DECLS("AutoTypeLoc");
+  EXPECT_NO_DECLS("AutoTypeLoc");
 
   Code = R"cpp(
     template <typename... E>
     struct S {
       static const int size = sizeof...([[E]]);
     };
   )cpp";
   EXPECT_DECLS("SizeOfPackExpr", "typename ...E");
TEST_F(TargetDeclTest, ObjC) {
 
   Code = R"cpp(
     @class C;
     @protocol Foo
     @end
     void test(C<[[Foo]]> *p);
   )cpp";
   // FIXME: there's no AST node corresponding to 'Foo', so we're stuck.
-  EXPECT_DECLS("ObjCObjectTypeLoc");
+  EXPECT_NO_DECLS("ObjCObjectTypeLoc");
 }
 
 class FindExplicitReferencesTest : public ::testing::Test {
 protected:
   struct AllRefs {
     std::string AnnotatedCode;
     std::string DumpedReferences;
   };

clang-tools-extra/clangd/unittests/SelectionTests.cpp

 TEST(SelectionTest, CreateAll) {
   llvm::Annotations Test("int$unique^ a=1$ambiguous^+1; $empty^");
   auto AST = TestTU::withCode(Test.code()).build();
   unsigned Seen = 0;
   SelectionTree::createEach(
       AST.getASTContext(), AST.getTokens(), Test.point("ambiguous"),
       Test.point("ambiguous"), [&](SelectionTree T) {
         // Expect to see the right-biased tree first.
-        if (Seen == 0)
+        if (Seen == 0) {
           EXPECT_EQ("BinaryOperator", nodeKind(T.commonAncestor()));
-        else if (Seen == 1)
+        } else if (Seen == 1) {
           EXPECT_EQ("IntegerLiteral", nodeKind(T.commonAncestor()));
+        }
         ++Seen;
         return false;
       });
   EXPECT_EQ(2u, Seen);
 
   Seen = 0;
   SelectionTree::createEach(AST.getASTContext(), AST.getTokens(),
                             Test.point("ambiguous"), Test.point("ambiguous"),