Page MenuHomePhabricator

[NFC][PowerPC] Update PC-Relative Load/Store Patterns to use the refactored Load/Store Implementation
AcceptedPublic

Authored by amyk on Jan 20 2021, 11:01 PM.

Details

Reviewers
power-llvm-team
nemanjai
bsaleil
Group Reviewers
Restricted Project
Summary

This patch updates the PC-Relative load and store patterns to utilize the refactored load/store implementation introduced in D93370.
PC-Relative implementation has been added to PPCISelLowering.cpp, and also the patterns in PPCInstrPrefix.td have been updated and no longer require AddedComplexity.
All existing test cases pass with this update.

Depends on D95115

Diff Detail

Event Timeline

amyk created this revision.Jan 20 2021, 11:01 PM
amyk requested review of this revision.Jan 20 2021, 11:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 11:01 PM
bsaleil accepted this revision.Jan 22 2021, 3:44 PM
bsaleil added a subscriber: bsaleil.

LGTM, I only have a minor comment.

llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp
258

Could you rename the P argument to Parent like in the other Select* functions ?

This revision is now accepted and ready to land.Jan 22 2021, 3:44 PM
amyk updated this revision to Diff 320767.Tue, Feb 2, 6:05 AM

Update patch to:

  • rebase patch
  • Update the naming of the variable to Parent
amyk updated this revision to Diff 323318.Fri, Feb 12, 6:57 AM

Update patch to rebase from latest change on D93370.

amyk updated this revision to Diff 323860.Mon, Feb 15, 6:06 PM

Update patch based on dependent patches, and update a comment when checking for P10 specific flags.