Page MenuHomePhabricator

[MLIR][Standard] Add log1p operation to std
ClosedPublic

Authored by frgossen on Jan 20 2021, 6:07 AM.

Diff Detail

Event Timeline

frgossen created this revision.Jan 20 2021, 6:07 AM
frgossen requested review of this revision.Jan 20 2021, 6:07 AM
pifon2a accepted this revision.Jan 20 2021, 8:13 AM
pifon2a added inline comments.
mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
1958

nit: base-e logarithm of one plus the given value,

just to be consistent with everything above.

This revision is now accepted and ready to land.Jan 20 2021, 8:13 AM
frgossen updated this revision to Diff 317913.Jan 20 2021, 9:53 AM

Address comments

frgossen marked an inline comment as done.Jan 20 2021, 9:53 AM

Thanks

This revision was landed with ongoing or failed builds.Jan 20 2021, 9:57 AM
This revision was automatically updated to reflect the committed changes.

Since the split of the standard dialect has begun, can you create a math dialect and move this kind of operations there?

Since the split of the standard dialect has begun, can you create a math dialect and move this kind of operations there?

See https://llvm.discourse.group/t/rfc-split-the-math-dialect-from-std/2620.

This comment was removed by frgossen.