This is an archive of the discontinued LLVM Phabricator instance.

[AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal()
AbandonedPublic

Authored by DiggerLin on Jan 19 2021, 10:27 AM.

Details

Summary

since the patch "[TargetMachine] Drop implied dso_local for definitions in ELF static relocation" delete some elf related code. some xcoff related can also be simplified after that patch

Diff Detail

Event Timeline

DiggerLin created this revision.Jan 19 2021, 10:27 AM
DiggerLin requested review of this revision.Jan 19 2021, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2021, 10:27 AM
llvm/lib/Target/TargetMachine.cpp
153

I think this looks right, but I'm not sure an extra assert is entirely "NFC".

DiggerLin retitled this revision from [NFC][AIX] not functionality changing of function TargetMachine::shouldAssumeDSOLocal() to [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal() .Jan 21 2021, 1:46 PM
DiggerLin edited the summary of this revision. (Show Details)
DiggerLin updated this revision to Diff 318309.Jan 21 2021, 1:49 PM
DiggerLin marked an inline comment as done.
DiggerLin abandoned this revision.EditedOct 16 2023, 11:58 AM

since the commit did the same change , I closed the patch

commit c5ee3123685ca5d555f80ed6e1bb8eeefca3dfbf
Author: Fangrui Song <i@maskray.me>
Date:   Sat Aug 21 12:37:29 2021 -0700

    [TargetMachine] Simplify shouldAssumeDSOLocal. NFC
llvm/lib/Target/TargetMachine.cpp
153

thanks.

Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2023, 11:58 AM