since the patch "[TargetMachine] Drop implied dso_local for definitions in ELF static relocation" delete some elf related code. some xcoff related can also be simplified after that patch
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/TargetMachine.cpp | ||
---|---|---|
154 | I think this looks right, but I'm not sure an extra assert is entirely "NFC". |
Comment Actions
since the commit did the same change , I closed the patch
commit c5ee3123685ca5d555f80ed6e1bb8eeefca3dfbf Author: Fangrui Song <i@maskray.me> Date: Sat Aug 21 12:37:29 2021 -0700 [TargetMachine] Simplify shouldAssumeDSOLocal. NFC
llvm/lib/Target/TargetMachine.cpp | ||
---|---|---|
154 | thanks. |
I think this looks right, but I'm not sure an extra assert is entirely "NFC".