We have no lowering for VSELECT vXi1, vXi1, vXi1, so mark them as expanded to turn them into a series of logical operations.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/Analysis/CostModel/ARM/arith-overflow.ll | ||
---|---|---|
387–388 | More of a curiosity, how was this lowered before? Given the added codegen tests, I guess this is not only a cost-model tweak? And some of these costs are extremely high. Do they make sense? |
llvm/test/Analysis/CostModel/ARM/arith-overflow.ll | ||
---|---|---|
387–388 | Yep. The costs are based on whether the operation is legal and add.with.overflow checks the cost of selects of predicates (v4i1). There is no legal instruction for them for MVE, so a high cost is probably fine. D94958 updates the similar costs for sadd.sat and friends, which also have costs based in sadd.with.overflow by default. |
llvm/test/Analysis/CostModel/ARM/arith-overflow.ll | ||
---|---|---|
387–388 |
Yeah, thanks, now this is more consistent with each other; I was asking because of this difference. LGTM |
More of a curiosity, how was this lowered before? Given the added codegen tests, I guess this is not only a cost-model tweak? And some of these costs are extremely high. Do they make sense?