Page MenuHomePhabricator

[mlir] Add better support for f80 and f128
ClosedPublic

Authored by clementval on Jan 14 2021, 6:11 PM.

Diff Detail

Event Timeline

clementval created this revision.Jan 14 2021, 6:11 PM
clementval requested review of this revision.Jan 14 2021, 6:11 PM
rriddle accepted this revision.Jan 14 2021, 6:18 PM

Did a pass through, and looks good to me.

mlir/test/Dialect/LLVMIR/types.mlir
6–7

Can you add a usage in IR/parser.mlir now that these are builtin types? All of these checks here look like they should go away now that the types have been replaced.

This revision is now accepted and ready to land.Jan 14 2021, 6:18 PM

Add usage in IR/parser.mlir

mlir/test/Dialect/LLVMIR/types.mlir
6–7

Should we also remove the checks for f16, bf16, f32, f64?

rriddle added inline comments.Jan 14 2021, 6:46 PM
mlir/test/Dialect/LLVMIR/types.mlir
6–7

Yeah, I don't think any of those are useful anymore.

Remove useless checks now that types have been replaced

clementval marked 2 inline comments as done.Jan 14 2021, 7:02 PM
clementval added inline comments.
mlir/test/Dialect/LLVMIR/types.mlir
6–7

Ok. Thanks for the quick review. I just removed the checks.

ftynse accepted this revision.Jan 15 2021, 12:27 AM
ftynse added inline comments.
mlir/docs/Dialects/LLVM.md
217–218

Please add f80 and f128 here

clementval marked an inline comment as done.

Add f80 and f128 to LLVM.md

clementval marked an inline comment as done.Jan 15 2021, 5:46 AM
This revision was automatically updated to reflect the committed changes.