This is an archive of the discontinued LLVM Phabricator instance.

Differential D94683

[Doc] Fix syntax error in CodeGenerator documentation example
ClosedPublic

Authored by Kai on Jan 14 2021, 5:13 AM.

Details

Reviewers
seaneveson
uweigand
kbarton
rnk
abhina.sreeskantharajan
Commits
rG9399681a57ce: [Doc] Fix example in codegen doc.
Summary

The attributes in the example are placed wrong:
They belong after the type, not after the parameter name.

Diff Detail

Event Timeline

Kai requested review of this revision.Jan 14 2021, 5:13 AM
Kai created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2021, 5:13 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
abhina.sreeskantharajan accepted this revision.Jan 14 2021, 5:58 AM

LGTM

This revision is now accepted and ready to land.Jan 14 2021, 5:58 AM
Harbormaster completed remote builds in B85158: Diff 316633.Jan 14 2021, 6:15 AM
Closed by commit rG9399681a57ce: [Doc] Fix example in codegen doc. (authored by Kai). · Explain WhyJan 18 2021, 5:26 AM
This revision was automatically updated to reflect the committed changes.
Kai added a commit: rG9399681a57ce: [Doc] Fix example in codegen doc..

Revision Contents

PathSize
llvm/
docs/
2 lines

Diff 316633

llvm/docs/CodeGenerator.rst

Context not available.
define fastcc i32 @tailcaller(i32 %in1, i32 %in2) { define fastcc i32 @tailcaller(i32 %in1, i32 %in2) {
%l1 = add i32 %in1, %in2 %l1 = add i32 %in1, %in2
%tmp = tail call fastcc i32 @tailcallee(i32 %in1 inreg, i32 %in2 inreg, i32 %in1, i32 %l1) %tmp = tail call fastcc i32 @tailcallee(i32 inreg %in1, i32 inreg %in2, i32 %in1, i32 %l1)
ret i32 %tmp ret i32 %tmp
} }
Context not available.