Page MenuHomePhabricator

seaneveson (Sean Eveson)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 25 2015, 7:34 AM (208 w, 1 d)

Recent Activity

Jan 17 2018

seaneveson committed rL322619: [MC] Fix -stack-size-section on ARM.
[MC] Fix -stack-size-section on ARM
Jan 17 2018, 1:03 AM
seaneveson closed D42108: [MC] Fix -stack-size-section on ARM.
Jan 17 2018, 1:03 AM

Jan 16 2018

seaneveson retitled D42108: [MC] Fix -stack-size-section on ARM from [MC] Fix -fstack-size-section on ARM to [MC] Fix -stack-size-section on ARM.
Jan 16 2018, 8:57 AM
seaneveson created D42108: [MC] Fix -stack-size-section on ARM.
Jan 16 2018, 8:56 AM

Jan 8 2018

seaneveson committed rC322000: Fix test added in r321992 failing on some buildbots (again), test requires x86..
Fix test added in r321992 failing on some buildbots (again), test requires x86.
Jan 8 2018, 7:47 AM
seaneveson committed rL322000: Fix test added in r321992 failing on some buildbots (again), test requires x86..
Fix test added in r321992 failing on some buildbots (again), test requires x86.
Jan 8 2018, 7:47 AM
seaneveson committed rC321995: Fix test added in r321992 failing on some buildbots..
Fix test added in r321992 failing on some buildbots.
Jan 8 2018, 6:44 AM
seaneveson committed rL321995: Fix test added in r321992 failing on some buildbots..
Fix test added in r321992 failing on some buildbots.
Jan 8 2018, 6:44 AM
seaneveson committed rC321992: [Driver] Add flag enabling the function stack size section that was added in….
[Driver] Add flag enabling the function stack size section that was added in…
Jan 8 2018, 5:43 AM
seaneveson committed rL321992: [Driver] Add flag enabling the function stack size section that was added in….
[Driver] Add flag enabling the function stack size section that was added in…
Jan 8 2018, 5:43 AM
seaneveson closed D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.
Jan 8 2018, 5:43 AM

Jan 5 2018

seaneveson updated the diff for D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.

Thanks Bruno,

Jan 5 2018, 6:35 AM

Jan 2 2018

seaneveson added a comment to D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.

Ping.

Jan 2 2018, 3:58 AM

Dec 13 2017

seaneveson added a comment to D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.

I also wonder whether it would be possible to move the fact that it defaults to on for PS4 into the PS4CPU.cpp file somehow (not that things are distributed that cleanly right now anyway).

Dec 13 2017, 2:07 AM

Dec 11 2017

seaneveson updated the diff for D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.

Improve tests.

Dec 11 2017, 6:11 AM
seaneveson retitled D40712: [Driver] Add flag enabling the function stack size section that was added in r319430 from Add cc1 flag enabling the function stack size section that was added in r319430 to [Driver] Add flag enabling the function stack size section that was added in r319430.
Dec 11 2017, 2:15 AM

Dec 8 2017

seaneveson added a comment to D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.

Ping.

Dec 8 2017, 3:22 AM

Dec 1 2017

seaneveson created D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.
Dec 1 2017, 4:07 AM

Nov 30 2017

seaneveson committed rL319430: [MC] Function stack size section..
[MC] Function stack size section.
Nov 30 2017, 5:05 AM
seaneveson added a comment to rL319423: [MC] Function stack size section..

I messed up the diff (obviously), so I have reverted the change and will resubmit.

Nov 30 2017, 4:54 AM
seaneveson committed rL319429: Revert r319423: [MC] Function stack size section..
Revert r319423: [MC] Function stack size section.
Nov 30 2017, 4:44 AM
seaneveson committed rL319423: [MC] Function stack size section..
[MC] Function stack size section.
Nov 30 2017, 4:01 AM
seaneveson closed D39788: [MC] Function stack size section..
Nov 30 2017, 4:01 AM

Nov 29 2017

seaneveson added inline comments to D39788: [MC] Function stack size section..
Nov 29 2017, 2:55 AM
seaneveson updated the diff for D39788: [MC] Function stack size section..
  • Rebase
  • Add documentation to CodeGenerator.rst
  • Move test checks above corresponding functions
Nov 29 2017, 2:43 AM

Nov 27 2017

seaneveson added a comment to D39788: [MC] Function stack size section..

I'd defer to others to comment on the highlevel whether this is a good or helpful idea.

Nov 27 2017, 3:57 AM

Nov 17 2017

seaneveson updated the diff for D39788: [MC] Function stack size section..
  • Add documentation to the llc CommandGuide
  • Skip functions with dynamic stack allocation
Nov 17 2017, 6:32 AM

Nov 16 2017

seaneveson added a comment to D39788: [MC] Function stack size section..

Thanks for the feedback!

Nov 16 2017, 10:15 AM

Nov 15 2017

seaneveson added a comment to D39788: [MC] Function stack size section..

Ping.

Nov 15 2017, 5:50 AM

Nov 8 2017

seaneveson updated the diff for D39788: [MC] Function stack size section..

Add context to diff. The arc tool doesn't seem to do that for me anymore.

Nov 8 2017, 3:30 AM
seaneveson created D39788: [MC] Function stack size section..
Nov 8 2017, 3:27 AM

Oct 4 2017

seaneveson committed rL314885: [llvm-cov] Fix showing title when filtering and not outputting to a directory.
[llvm-cov] Fix showing title when filtering and not outputting to a directory
Oct 4 2017, 1:56 AM
seaneveson closed D38507: [llvm-cov] Fix showing title when filtering and not outputting to a directory by committing rL314885: [llvm-cov] Fix showing title when filtering and not outputting to a directory.
Oct 4 2017, 1:56 AM

Oct 3 2017

seaneveson updated the diff for D38507: [llvm-cov] Fix showing title when filtering and not outputting to a directory.

Extend a test that already checked for this to cover filtered output as well.

Oct 3 2017, 10:58 AM
seaneveson created D38507: [llvm-cov] Fix showing title when filtering and not outputting to a directory.
Oct 3 2017, 8:36 AM
seaneveson committed rL314782: [llvm-cov] Hide files with no coverage from the index when filtering by name.
[llvm-cov] Hide files with no coverage from the index when filtering by name
Oct 3 2017, 4:07 AM
seaneveson closed D38457: [llvm-cov] Hide files with no coverage from the index when filtering by name by committing rL314782: [llvm-cov] Hide files with no coverage from the index when filtering by name.
Oct 3 2017, 4:07 AM

Oct 2 2017

seaneveson updated the diff for D38457: [llvm-cov] Hide files with no coverage from the index when filtering by name.

Improve test to check for absence of "Files which contain no functions" message.

Oct 2 2017, 9:17 AM
seaneveson added inline comments to D38457: [llvm-cov] Hide files with no coverage from the index when filtering by name.
Oct 2 2017, 9:11 AM
seaneveson updated the diff for D38457: [llvm-cov] Hide files with no coverage from the index when filtering by name.

Add context.

Oct 2 2017, 9:07 AM
seaneveson created D38457: [llvm-cov] Hide files with no coverage from the index when filtering by name.
Oct 2 2017, 7:04 AM

Sep 28 2017

seaneveson committed rL314396: [llvm-cov] Create directory structure when filtering using -name*= options.
[llvm-cov] Create directory structure when filtering using -name*= options
Sep 28 2017, 3:09 AM

Sep 27 2017

seaneveson committed rL314314: Revert "[llvm-cov] Create directory structure when filtering using -name*=….
Revert "[llvm-cov] Create directory structure when filtering using -name*=…
Sep 27 2017, 9:21 AM
seaneveson committed rL314310: [llvm-cov] Create directory structure when filtering using -name*= options.
[llvm-cov] Create directory structure when filtering using -name*= options
Sep 27 2017, 8:39 AM
seaneveson closed D38280: [llvm-cov] Create HTML directory structure when filtering using -name*= options by committing rL314310: [llvm-cov] Create directory structure when filtering using -name*= options.
Sep 27 2017, 8:39 AM
seaneveson updated the diff for D38280: [llvm-cov] Create HTML directory structure when filtering using -name*= options.
  • Make the changes to text as well as HTML
  • Address review comments
  • Upload the right diff ...
Sep 27 2017, 7:24 AM
seaneveson committed rL314281: [llvm-cov] Improve const-correctness of filters. NFC..
[llvm-cov] Improve const-correctness of filters. NFC.
Sep 27 2017, 1:34 AM

Sep 26 2017

seaneveson created D38280: [llvm-cov] Create HTML directory structure when filtering using -name*= options.
Sep 26 2017, 3:30 PM

Sep 13 2017

seaneveson accepted D36690: [StaticAnalyzer] LoopWidening: Invalidate only the possibly changed regions.

I didn't mark this as accepted in case anyone else wanted/needed to review this before you put it in, but I'm happy with it.

Sep 13 2017, 2:25 AM

Aug 31 2017

seaneveson committed rL312227: [llvm-cov] Read in function names for filtering from a text file..
[llvm-cov] Read in function names for filtering from a text file.
Aug 31 2017, 2:12 AM
seaneveson closed D37111: [llvm-cov] Read in function names for filtering from a text file..
Aug 31 2017, 2:12 AM

Aug 30 2017

seaneveson updated the diff for D37111: [llvm-cov] Read in function names for filtering from a text file..

Change to use SpecialCaseList and add documentation of new option.

Aug 30 2017, 4:11 AM
seaneveson added a comment to D36690: [StaticAnalyzer] LoopWidening: Invalidate only the possibly changed regions.

LGTM, Thanks :)

Aug 30 2017, 1:36 AM

Aug 25 2017

seaneveson added inline comments to D37111: [llvm-cov] Read in function names for filtering from a text file..
Aug 25 2017, 2:53 AM

Aug 24 2017

seaneveson added a comment to D36690: [StaticAnalyzer] LoopWidening: Invalidate only the possibly changed regions.

I would still personally rather replace widen-loops, but if its just me I'm happy for it to be a separate option for now.

Aug 24 2017, 8:35 AM
seaneveson created D37111: [llvm-cov] Read in function names for filtering from a text file..
Aug 24 2017, 7:59 AM

Aug 14 2017

seaneveson added a comment to D36690: [StaticAnalyzer] LoopWidening: Invalidate only the possibly changed regions.

Nice! Thanks again for working on this.

Aug 14 2017, 10:29 AM
seaneveson committed rL310836: [llvm-cov] Fix compiler-rt tests failing in build bots after rL310827..
[llvm-cov] Fix compiler-rt tests failing in build bots after rL310827.
Aug 14 2017, 5:44 AM
seaneveson committed rL310827: [llvm-cov] Add an option which maps the location of source directories on….
[llvm-cov] Add an option which maps the location of source directories on…
Aug 14 2017, 3:22 AM
seaneveson closed D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.
Aug 14 2017, 3:22 AM
seaneveson updated the diff for D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.

Fix typo and rebase.

Aug 14 2017, 3:11 AM

Aug 11 2017

seaneveson updated the diff for D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.

Address some review comments and tidy up removeUnmappedInputs.

Aug 11 2017, 5:55 AM

Aug 10 2017

seaneveson updated the diff for D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.
  • Address review comments
  • Move the creation of the mapping into its own method, and call that inside load(), so it works properly for report as well as show
Aug 10 2017, 7:10 AM

Aug 8 2017

seaneveson added a comment to D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.

Thanks for your feedback, I think I've addressed all your comments (or replied to them).

Aug 8 2017, 8:30 AM
seaneveson updated the diff for D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.

Update based on review comments.

Aug 8 2017, 8:07 AM

Aug 7 2017

seaneveson updated the diff for D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.

Add missing file.

Aug 7 2017, 2:54 AM
seaneveson created D36391: [llvm-cov] Add an option which maps the location of source directories on another machine to your local copies.
Aug 7 2017, 2:49 AM

Jul 5 2017

seaneveson committed rL307162: [ELF] Fix nullptr dereference when creating an error message for a synthetic….
[ELF] Fix nullptr dereference when creating an error message for a synthetic…
Jul 5 2017, 7:56 AM
seaneveson closed D34752: [LLD][ELF] Fix nullptr dereference when creating an error message. by committing rL307162: [ELF] Fix nullptr dereference when creating an error message for a synthetic….
Jul 5 2017, 7:56 AM

Jul 3 2017

seaneveson updated the diff for D34752: [LLD][ELF] Fix nullptr dereference when creating an error message..
  • Added a test
  • Fixed a missing brace in the error message string
Jul 3 2017, 7:33 AM

Jun 29 2017

seaneveson updated the diff for D34752: [LLD][ELF] Fix nullptr dereference when creating an error message..

Changed to early return as requested.

Jun 29 2017, 7:23 AM

Jun 28 2017

seaneveson created D34752: [LLD][ELF] Fix nullptr dereference when creating an error message..
Jun 28 2017, 7:50 AM

Jun 22 2017

seaneveson added inline comments to D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option .
Jun 22 2017, 3:03 AM

Jun 20 2017

seaneveson added a comment to D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option .

Thanks for looking at this.

Jun 20 2017, 9:01 AM

Nov 18 2016

seaneveson added inline comments to D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts..
Nov 18 2016, 1:40 AM

May 26 2016

seaneveson closed D19866: [Analyzer] Correct stack address escape diagnostic.

Committed: http://reviews.llvm.org/rL270849

May 26 2016, 7:22 AM
seaneveson committed rL270849: [Analyzer] Correct stack address escape diagnostic.
[Analyzer] Correct stack address escape diagnostic
May 26 2016, 7:08 AM

Jan 6 2016

seaneveson committed rL256926: [Analyzer] Change the default SA checkers for PS4.
[Analyzer] Change the default SA checkers for PS4
Jan 6 2016, 2:07 AM
seaneveson closed D15888: [Analyzer] Change the default SA checkers for PS4.
Jan 6 2016, 2:07 AM
seaneveson updated the diff for D15888: [Analyzer] Change the default SA checkers for PS4.

Removing old "experimental" comment

Jan 6 2016, 12:56 AM

Jan 5 2016

seaneveson retitled D15888: [Analyzer] Change the default SA checkers for PS4 from to [Analyzer] Change the default SA checkers for PS4.
Jan 5 2016, 4:17 AM

Nov 26 2015

seaneveson added a comment to D14919: Fix IssueHash generation.

I did not create a test checker for the NormalizeLine error in the patch.
Should I add a test checker for this?

Nov 26 2015, 1:49 AM

Nov 24 2015

seaneveson added a comment to D14919: Fix IssueHash generation.

If the Decl *D pointer is nullptr the NormalizeLine would crash while getting the LangOptions.

Do you have a reproducible test case for this?

Nov 24 2015, 8:18 AM

Nov 12 2015

seaneveson added a comment to D10305: [Clang Static Analyzer] Bug identification.

If you have multiple users using a bug suppression system, I would design such system using only a single hash version across all users; using a mix seems error prone.. Once all of your users upgrade to a version of the analyzer where a new hash version is available, you upgrade the hash in the database to reflect that.

Nov 12 2015, 8:32 AM

Nov 11 2015

seaneveson added a comment to D10305: [Clang Static Analyzer] Bug identification.

The reason I like names more than the numbers is that we may use different solutions for issue hash generation and some users might prefer one over the other. It is not necessarily clear which one is the best. Numbers would obfuscate the heuristic used to produce the hash and the quality of the hash and would be mainly based on the time when the hash was introduced.

Nov 11 2015, 8:37 AM

Nov 10 2015

seaneveson added a comment to D10305: [Clang Static Analyzer] Bug identification.

A third alternative would be to have both semantic names (containing hash) and a number suffix which indicates the ordering.

Nov 10 2015, 6:56 AM
seaneveson added a comment to D10305: [Clang Static Analyzer] Bug identification.

We are working on tools that use the new hash for bug suppression. There seems to be no way to predict the names of future hashes. We have products (that will use the bug identification) that are on a different release schedule to our clang compiler. These tools will not be able to take advantage of new hashes, unless they know the future hash names.

Nov 10 2015, 6:10 AM
seaneveson committed rL252599: [Analyzer] Fix comments and formatting. NFC..
[Analyzer] Fix comments and formatting. NFC.
Nov 10 2015, 3:51 AM
seaneveson abandoned D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392).

Fixed by r252506. Thanks Devin.

Nov 10 2015, 12:39 AM

Nov 9 2015

seaneveson added a comment to D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392).

Fix an assertion which occurs when getCXXThisVal() returns an Unknown SVal and the Analyzer tries to get the corresponding memory region.

Nov 9 2015, 7:35 AM
seaneveson updated D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392).
Nov 9 2015, 7:32 AM
seaneveson updated subscribers of D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392).
Nov 9 2015, 7:26 AM
seaneveson added reviewers for D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392): dcoughlin, zaks.anna.
Nov 9 2015, 7:06 AM
seaneveson retitled D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392) from to [Analyzer] Fix an assertion caused by r250237 (PR25392).
Nov 9 2015, 7:02 AM

Oct 30 2015

seaneveson committed rL251702: Reapply r251621 "[Analyzer] Widening loops which do not exit".
Reapply r251621 "[Analyzer] Widening loops which do not exit"
Oct 30 2015, 8:26 AM
seaneveson committed rL251697: Revert r251621 "[Analyzer] Widening loops which do not exit" (bot failure).
Revert r251621 "[Analyzer] Widening loops which do not exit" (bot failure)
Oct 30 2015, 4:15 AM

Oct 29 2015

seaneveson committed rL251621: [Analyzer] Widening loops which do not exit.
[Analyzer] Widening loops which do not exit
Oct 29 2015, 3:07 AM
seaneveson closed D12358: [Analyzer] Widening loops which do not exit by committing rL251621: [Analyzer] Widening loops which do not exit.
Oct 29 2015, 3:07 AM
seaneveson updated the diff for D12358: [Analyzer] Widening loops which do not exit.

Updated to latest revision

Oct 29 2015, 3:00 AM

Oct 27 2015

seaneveson added inline comments to D12358: [Analyzer] Widening loops which do not exit.
Oct 27 2015, 3:57 AM