Modify libunwind to support SjLj exception handling routines for VE.
In order to do that, we need to implement not only SjLj exception
handling routines but also a Registers_ve class. This implementation
of Registers_ve is incomplete. We will work on it later when we need
backtrace in libunwind.
Details
Details
- Reviewers
simoll k-ishizaka mhorne luismarques MaskRay compnerd lenary - Group Reviewers
Restricted Project - Commits
- rG3cbd476c5488: [VE] Support VE in libunwind
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libunwind/src/Unwind-sjlj.c | ||
---|---|---|
41 | If you are guaranteed to require 64-bits, I think that it would be better to use uint64_t rather than uintptr_t which is pointer-width sized. That is subtly different, even if in practice it means that it will be 64-bit currently. Alternatively, changing the comment is entirely reasonable to do as well. |
libunwind/src/Unwind-sjlj.c | ||
---|---|---|
41 | Thank you. I'll change it to uint64_t. |
If you are guaranteed to require 64-bits, I think that it would be better to use uint64_t rather than uintptr_t which is pointer-width sized. That is subtly different, even if in practice it means that it will be 64-bit currently. Alternatively, changing the comment is entirely reasonable to do as well.