The FreeBSD API usage looks correct to me, but I can't comment on too much more than that. The code could benefit from fewer unnamed constants.

To add to the discussion a little, I have recently been looking at this __clear_cache problem on FreeBSD. I don't really see a viable workaround other than adding a new system call like Linux has done. It's unfortunate that a shortcoming in the ISA will force a change of this nature to be made on every platform, at least until better cache maintenance instructions are defined.

Hi, sorry for the delay in review. It would be helpful if you could go through the inline comments and mark them as "done" if they have been addressed. I see there are still a few comments that have been ignored.

@kamleshbhalui thanks for this, it looks to be shaping up well. I have only a couple of small comments first.

This looks fine to me based on your description of the issue and how the libgcc implementation achieves this. Someone else will need to sign off on this however.

Thanks Sam and Luis for the review. Could I ask that one of you commit this if you are able?

Add some libunwind contributors for additional review.

Convert checks for __riscv_float_abi_double to __riscv_flen == 64.

Thanks for the review!

Address lenary's comments.

This has been handled more correctly and completely with recent patches.

Apologies if I didn't tag the right reviewers; I took a look at those who seemed to be most involved with the RISC-V target, but if there's anyone more appropriate to review clang changes then feel free to add them instead :)