- User Since
- Apr 24 2019, 1:56 PM (97 w, 1 d)
Thu, Feb 18
The FreeBSD API usage looks correct to me, but I can't comment on too much more than that. The code could benefit from fewer unnamed constants.
Dec 7 2020
To add to the discussion a little, I have recently been looking at this __clear_cache problem on FreeBSD. I don't really see a viable workaround other than adding a new system call like Linux has done. It's unfortunate that a shortcoming in the ISA will force a change of this nature to be made on every platform, at least until better cache maintenance instructions are defined.
Jul 26 2020
Hi, sorry for the delay in review. It would be helpful if you could go through the inline comments and mark them as "done" if they have been addressed. I see there are still a few comments that have been ignored.
Jun 22 2020
Jun 16 2020
@kamleshbhalui thanks for this, it looks to be shaping up well. I have only a couple of small comments first.
May 4 2020
This looks fine to me based on your description of the issue and how the libgcc implementation achieves this. Someone else will need to sign off on this however.
Dec 16 2019
Thanks Sam and Luis for the review. Could I ask that one of you commit this if you are able?
Dec 7 2019
Nov 17 2019
Add some libunwind contributors for additional review.
Nov 11 2019
Convert checks for __riscv_float_abi_double to __riscv_flen == 64.
Oct 15 2019
Oct 8 2019
Thanks for the review!
Address lenary's comments.
Oct 2 2019
Aug 26 2019
This has been handled more correctly and completely with recent patches.
May 25 2019
Apr 24 2019
Apologies if I didn't tag the right reviewers; I took a look at those who seemed to be most involved with the RISC-V target, but if there's anyone more appropriate to review clang changes then feel free to add them instead :)