Page MenuHomePhabricator

mhorne (Mitchell Horne)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2019, 1:56 PM (112 w, 5 d)

Recent Activity

Mar 4 2021

mhorne added inline comments to D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support.
Mar 4 2021, 5:29 PM · Restricted Project

Feb 18 2021

mhorne added a comment to D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support.

The FreeBSD API usage looks correct to me, but I can't comment on too much more than that. The code could benefit from fewer unnamed constants.

Feb 18 2021, 7:07 AM · Restricted Project

Dec 7 2020

mhorne added a comment to D92464: [compiler-rt][builtins][RISCV] Port __clear_cache to RISC-V baremetal.

To add to the discussion a little, I have recently been looking at this __clear_cache problem on FreeBSD. I don't really see a viable workaround other than adding a new system call like Linux has done. It's unfortunate that a shortcoming in the ISA will force a change of this nature to be made on every platform, at least until better cache maintenance instructions are defined.

Dec 7 2020, 1:11 PM · Restricted Project

Jul 26 2020

mhorne added a comment to D80690: [RISCV] Support libunwind for riscv32.

Hi, sorry for the delay in review. It would be helpful if you could go through the inline comments and mark them as "done" if they have been addressed. I see there are still a few comments that have been ignored.

Jul 26 2020, 11:42 AM · Restricted Project, Restricted Project

Jun 22 2020

mhorne added inline comments to D80690: [RISCV] Support libunwind for riscv32.
Jun 22 2020, 5:52 AM · Restricted Project, Restricted Project

Jun 16 2020

mhorne added a comment to D80690: [RISCV] Support libunwind for riscv32.

@kamleshbhalui thanks for this, it looks to be shaping up well. I have only a couple of small comments first.

Jun 16 2020, 11:32 AM · Restricted Project, Restricted Project

May 4 2020

mhorne accepted D78931: [libunwind][RISCV] Track PC separately from RA.

This looks fine to me based on your description of the issue and how the libgcc implementation achieves this. Someone else will need to sign off on this however.

May 4 2020, 4:41 PM · Restricted Project, Restricted Project

Dec 16 2019

mhorne added a comment to D68362: [libunwind][RISCV] Add 64-bit RISC-V support.

Thanks Sam and Luis for the review. Could I ask that one of you commit this if you are able?

Dec 16 2019, 8:34 AM · Restricted Project

Dec 7 2019

mhorne updated the diff for D68362: [libunwind][RISCV] Add 64-bit RISC-V support.
Dec 7 2019, 2:02 PM · Restricted Project

Nov 17 2019

mhorne added reviewers for D68362: [libunwind][RISCV] Add 64-bit RISC-V support: compnerd, phosek.

Add some libunwind contributors for additional review.

Nov 17 2019, 12:27 PM · Restricted Project

Nov 11 2019

mhorne added inline comments to D68362: [libunwind][RISCV] Add 64-bit RISC-V support.
Nov 11 2019, 8:25 PM · Restricted Project
mhorne updated the diff for D68362: [libunwind][RISCV] Add 64-bit RISC-V support.

Convert checks for __riscv_float_abi_double to __riscv_flen == 64.

Nov 11 2019, 7:49 PM · Restricted Project

Oct 15 2019

mhorne added inline comments to D68362: [libunwind][RISCV] Add 64-bit RISC-V support.
Oct 15 2019, 6:33 PM · Restricted Project

Oct 8 2019

mhorne added a comment to D68362: [libunwind][RISCV] Add 64-bit RISC-V support.

Thanks for the review!

Oct 8 2019, 6:29 PM · Restricted Project
mhorne updated the diff for D68362: [libunwind][RISCV] Add 64-bit RISC-V support.

Address lenary's comments.

Oct 8 2019, 6:28 PM · Restricted Project

Oct 2 2019

mhorne created D68362: [libunwind][RISCV] Add 64-bit RISC-V support.
Oct 2 2019, 5:25 PM · Restricted Project

Aug 26 2019

mhorne abandoned D61098: [clang] [RISC-V] Add validation for inline assembly constraints.

This has been handled more correctly and completely with recent patches.

Aug 26 2019, 5:55 PM · Restricted Project

May 25 2019

Herald added a project to D54091: [RISCV] Add inline asm constraints I, J & K for RISC-V: Restricted Project.
May 25 2019, 1:17 PM · Restricted Project, Restricted Project

Apr 24 2019

mhorne added a comment to D61098: [clang] [RISC-V] Add validation for inline assembly constraints.

Apologies if I didn't tag the right reviewers; I took a look at those who seemed to be most involved with the RISC-V target, but if there's anyone more appropriate to review clang changes then feel free to add them instead :)

Apr 24 2019, 3:19 PM · Restricted Project
mhorne created D61098: [clang] [RISC-V] Add validation for inline assembly constraints.
Apr 24 2019, 3:15 PM · Restricted Project