This is an archive of the discontinued LLVM Phabricator instance.

Differential D94407

[mlir] Fix for LIT tests
ClosedPublic

Authored by vinograd47 on Jan 11 2021, 5:31 AM.

Details

Reviewers
mehdi_amini
Commits
rG9667d15e7496: [mlir] Fix for LIT tests
Summary

Add MLIR_SPIRV_CPU_RUNNER_ENABLED to llvm_canonicalize_cmake_booleans.

Diff Detail

Event Timeline

vinograd47 created this revision.Jan 11 2021, 5:31 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptJan 11 2021, 5:31 AM
vinograd47 requested review of this revision.Jan 11 2021, 5:31 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptJan 11 2021, 5:31 AM
Harbormaster completed remote builds in B84671: Diff 315768.Jan 11 2021, 6:07 AM
mehdi_amini accepted this revision.Jan 11 2021, 9:05 AM

LGTM

This revision is now accepted and ready to land.Jan 11 2021, 9:05 AM
vinograd47 added a comment.Jan 12 2021, 5:41 AM

I believe I don't have commit rights to LLVM repository. Could someone commit this change to main repository?

ftynse added a subscriber: ftynse.Jan 12 2021, 8:07 AM

I took your name and email from Github commits. Please consider sending patches with Arcanist to preserve author (and base revision) info.

Closed by commit rG9667d15e7496: [mlir] Fix for LIT tests (authored by vinograd47, committed by ftynse). · Explain WhyJan 12 2021, 8:07 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG9667d15e7496: [mlir] Fix for LIT tests.
antiagainst added a comment.Jan 12 2021, 8:09 AM

Thanks for fixing this!

Revision Contents

PathSize
mlir/
test/
1 line

Diff 316097

mlir/test/CMakeLists.txt

add_subdirectory(Bindings) add_subdirectory(Bindings)
add_subdirectory(CAPI) add_subdirectory(CAPI)
add_subdirectory(EDSC) add_subdirectory(EDSC)
add_subdirectory(mlir-cpu-runner) add_subdirectory(mlir-cpu-runner)
add_subdirectory(SDBM) add_subdirectory(SDBM)
add_subdirectory(lib) add_subdirectory(lib)
llvm_canonicalize_cmake_booleans( llvm_canonicalize_cmake_booleans(
MLIR_BINDINGS_PYTHON_ENABLED MLIR_BINDINGS_PYTHON_ENABLED
LLVM_BUILD_EXAMPLES LLVM_BUILD_EXAMPLES
MLIR_CUDA_CONVERSIONS_ENABLED MLIR_CUDA_CONVERSIONS_ENABLED
MLIR_CUDA_RUNNER_ENABLED MLIR_CUDA_RUNNER_ENABLED
MLIR_ROCM_CONVERSIONS_ENABLED MLIR_ROCM_CONVERSIONS_ENABLED
MLIR_ROCM_RUNNER_ENABLED MLIR_ROCM_RUNNER_ENABLED
MLIR_SPIRV_CPU_RUNNER_ENABLED
MLIR_VULKAN_RUNNER_ENABLED MLIR_VULKAN_RUNNER_ENABLED
) )
# Passed to lit.site.cfg.py.in to set up the path where to find the libraries # Passed to lit.site.cfg.py.in to set up the path where to find the libraries
# for linalg integration tests. # for linalg integration tests.
set(MLIR_DIALECT_LINALG_INTEGRATION_TEST_LIB_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}) set(MLIR_DIALECT_LINALG_INTEGRATION_TEST_LIB_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
set(MLIR_RUNNER_UTILS_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}) set(MLIR_RUNNER_UTILS_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
▲ Show 20 Lines • Show All 95 Lines • Show Last 20 Lines