Page MenuHomePhabricator

[NFC] Disallow unused prefixes in CodeGen/PowerPC tests.
ClosedPublic

Authored by mtrofin on Jan 10 2021, 8:17 PM.

Details

Summary

Also removed where applicable.

Diff Detail

Event Timeline

mtrofin created this revision.Jan 10 2021, 8:17 PM
mtrofin requested review of this revision.Jan 10 2021, 8:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2021, 8:17 PM
lkail added reviewers: nemanjai, Restricted Project.Jan 10 2021, 10:33 PM
jsji accepted this revision as: jsji.Jan 11 2021, 6:53 AM

LGTM , thanks for cleaning up .

llvm/test/CodeGen/PowerPC/ppc32-pic.ll
4

Looks like this is typo, should be SMALL-SECURE instead of SMALL-SECUREPLT.

4

Maybe update it to SMALL-SECURE instead.

This revision is now accepted and ready to land.Jan 11 2021, 6:53 AM
nemanjai accepted this revision.Jan 11 2021, 7:11 AM

Thanks for doing this. I think it is useful for test cases to fail if a check prefix is unused (or becomes unused). LGTM.

llvm/test/CodeGen/PowerPC/testComparesigeus.ll
5

I imagine this was done by a script that ended up leaving these behind, but can you please remove empty RUN: lines?

mtrofin updated this revision to Diff 315827.Jan 11 2021, 9:10 AM
mtrofin marked 3 inline comments as done.

feedback

llvm/test/CodeGen/PowerPC/ppc32-pic.ll
4

Yup, and there was a bug in the test. Fixed.

This revision was landed with ongoing or failed builds.Jan 11 2021, 9:25 AM
This revision was automatically updated to reflect the committed changes.