This is an archive of the discontinued LLVM Phabricator instance.

[NewPM] Don't error when there's an unrecognized pass name
ClosedPublic

Authored by aeubanks on Jan 7 2021, 8:23 PM.

Details

Summary

This currently blocks --print-before/after with a legacy PM pass, for
example when we use the new PM for the optimization pipeline but the
legacy PM for the codegen pipeline. Also in the future when the codegen
pipeline works with the new PM there will be multiple places to specify
passes, so even when everything is using the new PM, there will still be
multiple places that can accept different pass names.

Diff Detail

Event Timeline

aeubanks created this revision.Jan 7 2021, 8:23 PM
aeubanks requested review of this revision.Jan 7 2021, 8:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2021, 8:23 PM
ychen accepted this revision.Jan 7 2021, 10:20 PM

LGTM. I still think we should get back to the legacy names so that translation is avoided.

This revision is now accepted and ready to land.Jan 7 2021, 10:20 PM

LGTM. I still think we should get back to the legacy names so that translation is avoided.

We definitely should, but it'll be a big change. I'll see if I have time to get to it.

hoy accepted this revision.Jan 7 2021, 10:26 PM

Thanks for the quick fix. LGTM.