This is an archive of the discontinued LLVM Phabricator instance.

Differential D94162

[PowerPC] Add variants of 64-bit vector types for vec_sel.
ClosedPublic

Authored by Esme on Jan 6 2021, 2:28 AM.

Details

Reviewers
steven.zhang
nemanjai
qiucf
shchenz
Group Reviewers
Restricted Project
Commits
rGffa67873a3f9: [PowerPC] Add variants of 64-bit vector types for vec_sel.
Summary

This patch added the following variants of vec_sel.

vector bool long long
vec_sel(vector bool long long
        vector bool long long,
        vector bool long long);

vector bool long long
vec_sel(vector bool long long
        vector bool long long,
        vector unsigned long long);

vector signed long long
vec_sel(vector signed long long
        vector signed long long,
        vector bool long long);

vector signed long long
vec_sel(vector signed long long
        vector signed long long,
        vector unsigned long long);

vector unsigned long long
vec_sel(vector unsigned long long
        vector unsigned long long,
        vector bool long long);

vector unsigned long long
vec_sel(vector unsigned long long
        vector unsigned long long,
        vector unsigned long long);

It fixed https://bugs.llvm.org/show_bug.cgi?id=46770

Diff Detail

Unit TestsFailed

TimeTest
30 msx64 debian > LLVM.CodeGen/AArch64::debug-info-sve-dbg-value.mir
50 msx64 windows > LLVM.CodeGen/AArch64::debug-info-sve-dbg-value.mir

Event Timeline

Esme created this revision.Jan 6 2021, 2:28 AM
Herald added a subscriber: kbarton. · View Herald TranscriptJan 6 2021, 2:28 AM
Esme requested review of this revision.Jan 6 2021, 2:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2021, 2:28 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B84176: Diff 314829.Jan 6 2021, 3:09 AM
qiucf added a comment.Jan 7 2021, 8:10 AM
This comment was removed by qiucf.
steven.zhang edited the summary of this revision. (Show Details)Jan 7 2021, 6:18 PM
nemanjai accepted this revision.Jan 8 2021, 3:02 AM

Kind of bizarre that we missed these, thanks for adding them. LGTM.

This revision is now accepted and ready to land.Jan 8 2021, 3:02 AM
This revision was landed with ongoing or failed builds.Jan 10 2021, 7:56 PM
Closed by commit rGffa67873a3f9: [PowerPC] Add variants of 64-bit vector types for vec_sel. (authored by Esme). · Explain Why
This revision was automatically updated to reflect the committed changes.
Esme added a commit: rGffa67873a3f9: [PowerPC] Add variants of 64-bit vector types for vec_sel..

Revision Contents

PathSize
clang/
lib/
Headers/
40 lines
test/
CodeGen/
60 lines

Diff 314829

clang/lib/Headers/altivec.h

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
/*===---- altivec.h - Standard header for type generic math ---------------===*\ /*===---- altivec.h - Standard header for type generic math ---------------===*\
* *
* Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
* See https://llvm.org/LICENSE.txt for license information. * See https://llvm.org/LICENSE.txt for license information.
* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
* *
\*===----------------------------------------------------------------------===*/ \*===----------------------------------------------------------------------===*/
#ifndef __ALTIVEC_H #ifndef __ALTIVEC_H
#define __ALTIVEC_H #define __ALTIVEC_H
#ifndef __ALTIVEC__ #ifndef __ALTIVEC__
#error "AltiVec support not enabled" #error "AltiVec support not enabled"
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: "AltiVec support not enabled" [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: "AltiVec support not enabled" [clang-diagnostic-error] [[https://github.
#endif #endif
/* Constants for mapping CR6 bits to predicate result. */ /* Constants for mapping CR6 bits to predicate result. */
#define __CR6_EQ 0 #define __CR6_EQ 0
#define __CR6_EQ_REV 1 #define __CR6_EQ_REV 1
#define __CR6_LT 2 #define __CR6_LT 2
#define __CR6_LT_REV 3 #define __CR6_LT_REV 3
Show All 18 Lines#define __VEC_CLASS_FP_NOT_NORMAL (__VEC_CLASS_FP_NAN | \
__VEC_CLASS_FP_INFINITY) __VEC_CLASS_FP_INFINITY)
#define __ATTRS_o_ai __attribute__((__overloadable__, __always_inline__)) #define __ATTRS_o_ai __attribute__((__overloadable__, __always_inline__))
#ifdef __POWER9_VECTOR__ #ifdef __POWER9_VECTOR__
#include <stddef.h> #include <stddef.h>
#endif #endif
static __inline__ vector signed char __ATTRS_o_ai vec_perm( static __inline__ vector signed char __ATTRS_o_ai vec_perm(
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vector signed char __a, vector signed char __b, vector unsigned char __c); vector signed char __a, vector signed char __b, vector unsigned char __c);
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful
clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful
clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
static __inline__ vector unsigned char __ATTRS_o_ai static __inline__ vector unsigned char __ATTRS_o_ai
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vec_perm(vector unsigned char __a, vector unsigned char __b, vec_perm(vector unsigned char __a, vector unsigned char __b,
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful
clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vector unsigned char __c); vector unsigned char __c);
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
static __inline__ vector bool char __ATTRS_o_ai static __inline__ vector bool char __ATTRS_o_ai
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vec_perm(vector bool char __a, vector bool char __b, vector unsigned char __c); vec_perm(vector bool char __a, vector bool char __b, vector unsigned char __c);
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful
clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful
clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
static __inline__ vector short __ATTRS_o_ai vec_perm(vector signed short __a, static __inline__ vector short __ATTRS_o_ai vec_perm(vector signed short __a,
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful
clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vector signed short __b, vector signed short __b,
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vector unsigned char __c); vector unsigned char __c);
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
static __inline__ vector unsigned short __ATTRS_o_ai static __inline__ vector unsigned short __ATTRS_o_ai
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vec_perm(vector unsigned short __a, vector unsigned short __b, vec_perm(vector unsigned short __a, vector unsigned short __b,
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: unknown type name 'vector' [clang-diagnostic-error] [[https://github.
vector unsigned char __c); vector unsigned char __c);
static __inline__ vector bool short __ATTRS_o_ai vec_perm( static __inline__ vector bool short __ATTRS_o_ai vec_perm(
vector bool short __a, vector bool short __b, vector unsigned char __c); vector bool short __a, vector bool short __b, vector unsigned char __c);
static __inline__ vector pixel __ATTRS_o_ai vec_perm(vector pixel __a, static __inline__ vector pixel __ATTRS_o_ai vec_perm(vector pixel __a,
vector pixel __b, vector pixel __b,
vector unsigned char __c); vector unsigned char __c);
▲ Show 20 Lines • Show All 8,204 Lines • ▼ Show 20 Lines
} }
static __inline__ vector double __ATTRS_o_ai static __inline__ vector double __ATTRS_o_ai
vec_sel(vector double __a, vector double __b, vector unsigned long long __c) { vec_sel(vector double __a, vector double __b, vector unsigned long long __c) {
vector long long __res = ((vector long long)__a & ~(vector long long)__c) | vector long long __res = ((vector long long)__a & ~(vector long long)__c) |
((vector long long)__b & (vector long long)__c); ((vector long long)__b & (vector long long)__c);
return (vector double)__res; return (vector double)__res;
} }
static __inline__ vector bool long long __ATTRS_o_ai
vec_sel(vector bool long long __a, vector bool long long __b,
vector bool long long __c) {
return (__a & ~__c) | (__b & __c);
}
static __inline__ vector bool long long __ATTRS_o_ai
vec_sel(vector bool long long __a, vector bool long long __b,
vector unsigned long long __c) {
return (__a & ~(vector bool long long)__c) |
(__b & (vector bool long long)__c);
}
static __inline__ vector signed long long __ATTRS_o_ai
vec_sel(vector signed long long __a, vector signed long long __b,
vector bool long long __c) {
return (__a & ~(vector signed long long)__c) |
(__b & (vector signed long long)__c);
}
static __inline__ vector signed long long __ATTRS_o_ai
vec_sel(vector signed long long __a, vector signed long long __b,
vector unsigned long long __c) {
return (__a & ~(vector signed long long)__c) |
(__b & (vector signed long long)__c);
}
static __inline__ vector unsigned long long __ATTRS_o_ai
vec_sel(vector unsigned long long __a, vector unsigned long long __b,
vector bool long long __c) {
return (__a & ~(vector unsigned long long)__c) |
(__b & (vector unsigned long long)__c);
}
static __inline__ vector unsigned long long __ATTRS_o_ai
vec_sel(vector unsigned long long __a, vector unsigned long long __b,
vector unsigned long long __c) {
return (__a & ~__c) | (__b & __c);
}
#endif #endif
/* vec_vsel */ /* vec_vsel */
static __inline__ vector signed char __ATTRS_o_ai vec_vsel( static __inline__ vector signed char __ATTRS_o_ai vec_vsel(
vector signed char __a, vector signed char __b, vector unsigned char __c) { vector signed char __a, vector signed char __b, vector unsigned char __c) {
return (__a & ~(vector signed char)__c) | (__b & (vector signed char)__c); return (__a & ~(vector signed char)__c) | (__b & (vector signed char)__c);
} }
▲ Show 20 Lines • Show All 9,908 Lines • Show Last 20 Lines

clang/test/CodeGen/builtins-ppc-vsx.c

Show First 20 Lines • Show All 922 Lines • ▼ Show 20 Lines
// CHECK: or <2 x i64> // CHECK: or <2 x i64>
// CHECK: bitcast <2 x i64> %{{[0-9]+}} to <2 x double> // CHECK: bitcast <2 x i64> %{{[0-9]+}} to <2 x double>
// CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1> // CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, // CHECK-LE: and <2 x i64> %{{[0-9]+}},
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}} // CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK-LE: or <2 x i64> // CHECK-LE: or <2 x i64>
// CHECK-LE: bitcast <2 x i64> %{{[0-9]+}} to <2 x double> // CHECK-LE: bitcast <2 x i64> %{{[0-9]+}} to <2 x double>
res_vbll = vec_sel(vbll, vbll, vbll);
// CHECK: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK: and <2 x i64> %{{[0-9]+}},
// CHECK: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK: or <2 x i64>
// CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK-LE: and <2 x i64> %{{[0-9]+}},
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK-LE: or <2 x i64>
res_vbll = vec_sel(vbll, vbll, vull);
// CHECK: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK: and <2 x i64> %{{[0-9]+}},
// CHECK: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK: or <2 x i64>
// CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK-LE: and <2 x i64> %{{[0-9]+}},
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK-LE: or <2 x i64>
res_vsll = vec_sel(vsll, vsll, vbll);
// CHECK: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK: and <2 x i64> %{{[0-9]+}},
// CHECK: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK: or <2 x i64>
// CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK-LE: and <2 x i64> %{{[0-9]+}},
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK-LE: or <2 x i64>
res_vsll = vec_sel(vsll, vsll, vull);
// CHECK: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK: and <2 x i64> %{{[0-9]+}},
// CHECK: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK: or <2 x i64>
// CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK-LE: and <2 x i64> %{{[0-9]+}},
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK-LE: or <2 x i64>
res_vull = vec_sel(vull, vull, vbll);
// CHECK: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK: and <2 x i64> %{{[0-9]+}},
// CHECK: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK: or <2 x i64>
// CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK-LE: and <2 x i64> %{{[0-9]+}},
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK-LE: or <2 x i64>
res_vull = vec_sel(vull, vull, vull);
// CHECK: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK: and <2 x i64> %{{[0-9]+}},
// CHECK: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK: or <2 x i64>
// CHECK-LE: xor <2 x i64> %{{[0-9]+}}, <i64 -1, i64 -1>
// CHECK-LE: and <2 x i64> %{{[0-9]+}},
// CHECK-LE: and <2 x i64> %{{[0-9]+}}, %{{[0-9]+}}
// CHECK-LE: or <2 x i64>
res_vf = vec_sqrt(vf); res_vf = vec_sqrt(vf);
// CHECK: call <4 x float> @llvm.sqrt.v4f32(<4 x float> %{{[0-9]+}}) // CHECK: call <4 x float> @llvm.sqrt.v4f32(<4 x float> %{{[0-9]+}})
// CHECK-LE: call <4 x float> @llvm.sqrt.v4f32(<4 x float> %{{[0-9]+}}) // CHECK-LE: call <4 x float> @llvm.sqrt.v4f32(<4 x float> %{{[0-9]+}})
res_vd = vec_sqrt(vd); res_vd = vec_sqrt(vd);
// CHECK: call <2 x double> @llvm.sqrt.v2f64(<2 x double> %{{[0-9]+}}) // CHECK: call <2 x double> @llvm.sqrt.v2f64(<2 x double> %{{[0-9]+}})
// CHECK-LE: call <2 x double> @llvm.sqrt.v2f64(<2 x double> %{{[0-9]+}}) // CHECK-LE: call <2 x double> @llvm.sqrt.v2f64(<2 x double> %{{[0-9]+}})
▲ Show 20 Lines • Show All 958 Lines • Show Last 20 Lines