This is an archive of the discontinued LLVM Phabricator instance.

Differential D93996

Nit: fix spacing
ClosedPublic

Authored by sanjoy.google on Jan 3 2021, 10:34 AM.

Details

Reviewers
csigg
herhut
mehdi_amini
Commits
rGbd166c813c55: Nit: fix spacing

Diff Detail

Event Timeline

sanjoy.google created this revision.Jan 3 2021, 10:34 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptJan 3 2021, 10:34 AM
sanjoy.google requested review of this revision.Jan 3 2021, 10:34 AM
Herald added a reviewer: herhut. · View Herald TranscriptJan 3 2021, 10:34 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B83853: Diff 314294.Jan 3 2021, 10:54 AM
mehdi_amini accepted this revision.Jan 3 2021, 8:08 PM

LGTM

Feel free to push this kind of minor tweak directly.

This revision is now accepted and ready to land.Jan 3 2021, 8:08 PM
herhut accepted this revision.Jan 5 2021, 12:55 AM
Closed by commit rGbd166c813c55: Nit: fix spacing (authored by sanjoy). · Explain WhyJan 6 2021, 9:43 AM
This revision was automatically updated to reflect the committed changes.
sanjoy added a commit: rGbd166c813c55: Nit: fix spacing.

Revision Contents

PathSize
mlir/
test/
Dialect/
GPU/
2 lines

Diff 314294

mlir/test/Dialect/GPU/async-region.mlir

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines func @defer_wait_pass_through(%sz : index) {
// CHECK: async.await %[[a1]] // CHECK: async.await %[[a1]]
// CHECK: %[[t:.*]] = async.await %[[f1]] // CHECK: %[[t:.*]] = async.await %[[f1]]
// CHECK: gpu.wait [%[[t]]] // CHECK: gpu.wait [%[[t]]]
async.await %a1 : !async.token async.await %a1 : !async.token
return return
} }
// CHECK-LABEL:func @async_execute_with_result(%{{.*}}: index) // CHECK-LABEL:func @async_execute_with_result(%{{.*}}: index)
func @async_execute_with_result(%sz : index) -> index { func @async_execute_with_result(%sz : index) -> index {
// CHECK: %[[a0:.*]], %[[f0:.*]]:2 = async.execute // CHECK: %[[a0:.*]], %[[f0:.*]]:2 = async.execute
// CHECK-SAME: -> (!async.value<index>, !async.value<!gpu.async.token>) // CHECK-SAME: -> (!async.value<index>, !async.value<!gpu.async.token>)
%a0, %f0 = async.execute -> !async.value<index> { %a0, %f0 = async.execute -> !async.value<index> {
// CHECK: %[[t:.*]] = gpu.launch_func async // CHECK: %[[t:.*]] = gpu.launch_func async
gpu.launch_func @kernels::@kernel gpu.launch_func @kernels::@kernel
blocks in (%sz, %sz, %sz) threads in (%sz, %sz, %sz) blocks in (%sz, %sz, %sz) threads in (%sz, %sz, %sz)
// CHECK-NOT: gpu.wait // CHECK-NOT: gpu.wait
Show All 14 Lines