This is an archive of the discontinued LLVM Phabricator instance.

[CMake][tsan] Remove --sysroot=.
ClosedPublic

Authored by MaskRay on Dec 29 2020, 2:06 PM.

Details

Reviewers
vitalybuka
Group Reviewers
Restricted Project
Commits
rG9c0c123b0b48: [CMake][tsan] Remove --sysroot=.
Summary

rL254966 added --sysroot=. to prevent accidental including system headers.
It caused hassle to FreeBSD (D17383)/NetBSD. The next problem is that
we want to include features.h (usually /usr/include/features.h) to detect __GLIBC__.

At this point it seems that --sysroot=. adds lots of inconvenience so we disable it for now.
If there are better ways preventing accidental system header inclusion
we can consider it again.

Diff Detail