Page MenuHomePhabricator

[SimplifyCFG] Enabled hoisting late in LTO pipeline.
ClosedPublic

Authored by fhahn on Dec 22 2020, 3:26 AM.

Details

Summary

bb7d3af1139c disabled hoisting in SimplifyCFG by default, but enabled it
late in the pipeline. But it appears as if the LTO pipelines got missed.

This patch adjusts the LTO pipelines to also enable hoisting in the
later stages.

Unfortunately there's no easy way to add a test for the change I think.

Diff Detail

Event Timeline

fhahn created this revision.Dec 22 2020, 3:26 AM
fhahn requested review of this revision.Dec 22 2020, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2020, 3:26 AM

Definitely makes sense to me.
Is this changing only the old-pm?

fhahn updated this revision to Diff 313304.Dec 22 2020, 5:23 AM

Definitely makes sense to me.
Is this changing only the old-pm?

yeah, the first version just changed the legacy PM. I guess it makes sense for the new PM as well, although the pipeline looks quite different. Updated.

lebedev.ri accepted this revision.Jan 4 2021, 4:11 AM
lebedev.ri added a reviewer: tejohnson.

Looks good to me, thanks.

This revision is now accepted and ready to land.Jan 4 2021, 4:11 AM
This revision was automatically updated to reflect the committed changes.